mirror of
https://git.proxmox.com/git/fwupd
synced 2025-06-28 14:33:10 +00:00
078beafb2d
It is far too easy to forget to set FWUPD_DEVICE_FLAG_NO_GUID_MATCHING for new
plugins, and without it it all works really well *until* a user has two devices
of the same type installed at the same time and then one 'disappears' for hard
to explain reasons. Typically we only need it for replug anyway!
Explicitly opt-in to this rarely-required behaviour, with the default to just
use the physical and logical IDs. Also document the update behavior for each
plugin to explain why the flag is being used.
This allows you to have two identical Unifying plugged in without one of them
being hidden from the user, at the same time allowing a HIDRAW<->USB transition
when going to and from bootloader and runtime modes.
This removes the workaround added in 99eb3f06b6.
Fixes https://github.com/fwupd/fwupd/issues/2915
92 lines
2.7 KiB
C
92 lines
2.7 KiB
C
/*
|
|
* Copyright (C) 2017 Christian J. Kellner <christian@kellner.me>
|
|
*
|
|
* SPDX-License-Identifier: LGPL-2.1+
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <sys/utsname.h>
|
|
|
|
#include "fu-plugin-vfuncs.h"
|
|
#include "fu-thunderbolt-device.h"
|
|
#include "fu-thunderbolt-firmware.h"
|
|
#include "fu-thunderbolt-firmware-update.h"
|
|
|
|
static gboolean
|
|
fu_plugin_thunderbolt_safe_kernel (FuPlugin *plugin, GError **error)
|
|
{
|
|
g_autofree gchar *minimum_kernel = NULL;
|
|
struct utsname name_tmp;
|
|
|
|
memset (&name_tmp, 0, sizeof(struct utsname));
|
|
if (uname (&name_tmp) < 0) {
|
|
g_debug ("Failed to read current kernel version");
|
|
return TRUE;
|
|
}
|
|
|
|
minimum_kernel = fu_plugin_get_config_value (plugin, "MinimumKernelVersion");
|
|
if (minimum_kernel == NULL) {
|
|
g_debug ("Ignoring kernel safety checks");
|
|
return TRUE;
|
|
}
|
|
|
|
if (fu_common_vercmp_full (name_tmp.release,
|
|
minimum_kernel,
|
|
FWUPD_VERSION_FORMAT_TRIPLET) < 0) {
|
|
g_set_error (error,
|
|
FWUPD_ERROR,
|
|
FWUPD_ERROR_INTERNAL,
|
|
"kernel %s may not have full Thunderbolt support",
|
|
name_tmp.release);
|
|
return FALSE;
|
|
}
|
|
g_debug ("Using kernel %s (minimum %s)", name_tmp.release, minimum_kernel);
|
|
|
|
return TRUE;
|
|
}
|
|
|
|
gboolean
|
|
fu_plugin_device_created (FuPlugin *plugin, FuDevice *dev, GError **error)
|
|
{
|
|
fu_plugin_add_rule (plugin, FU_PLUGIN_RULE_INHIBITS_IDLE,
|
|
"thunderbolt requires device wakeup");
|
|
fu_device_set_quirks (dev, fu_plugin_get_quirks (plugin));
|
|
return TRUE;
|
|
}
|
|
|
|
void
|
|
fu_plugin_device_registered (FuPlugin *plugin, FuDevice *device)
|
|
{
|
|
if (g_strcmp0 (fu_device_get_plugin (device), "thunderbolt") != 0)
|
|
return;
|
|
|
|
/* Operating system will handle finishing updates later */
|
|
if (fu_plugin_get_config_value_boolean (plugin, "DelayedActivation") &&
|
|
!fu_device_has_flag (device, FWUPD_DEVICE_FLAG_USABLE_DURING_UPDATE)) {
|
|
g_debug ("Turning on delayed activation for %s",
|
|
fu_device_get_name (device));
|
|
fu_device_add_flag (device, FWUPD_DEVICE_FLAG_USABLE_DURING_UPDATE);
|
|
fu_device_add_flag (device, FWUPD_DEVICE_FLAG_SKIPS_RESTART);
|
|
fu_device_remove_internal_flag (device, FU_DEVICE_INTERNAL_FLAG_REPLUG_MATCH_GUID);
|
|
}
|
|
}
|
|
|
|
void
|
|
fu_plugin_init (FuPlugin *plugin)
|
|
{
|
|
fu_plugin_set_build_hash (plugin, FU_BUILD_HASH);
|
|
fu_plugin_add_udev_subsystem (plugin, "thunderbolt");
|
|
fu_plugin_set_device_gtype (plugin, FU_TYPE_THUNDERBOLT_DEVICE);
|
|
fu_plugin_add_firmware_gtype (plugin, NULL, FU_TYPE_THUNDERBOLT_FIRMWARE);
|
|
fu_plugin_add_firmware_gtype (plugin, NULL, FU_TYPE_THUNDERBOLT_FIRMWARE_UPDATE);
|
|
/* dell-dock plugin uses a slower bus for flashing */
|
|
fu_plugin_add_rule (plugin, FU_PLUGIN_RULE_BETTER_THAN, "dell_dock");
|
|
}
|
|
|
|
gboolean
|
|
fu_plugin_startup (FuPlugin *plugin, GError **error)
|
|
{
|
|
return fu_plugin_thunderbolt_safe_kernel (plugin, error);
|
|
}
|