fwupd/plugins/rts54hub/fu-rts54hub-rtd21xx-device.c
Richard Hughes 1981c63d58 Remove FuFirmwareImage and just use FuFirmware instead
This allows us to 'nest' firmware formats, and removes a ton of duplication.

The aim here is to deprecate FuFirmwareImage -- it's almost always acting
as a 'child' FuFirmware instance, and even copies most of the vfuncs to allow
custom types. If I'm struggling to work out what should be a FuFirmware and
what should be a FuFirmwareImage then a plugin author has no hope.

For simple payloads we were adding bytes into an image and then the image into
a firmware. This gets really messy when most plugins are treating the FuFirmware
*as* the binary firmware file.

The GBytes saved in the FuFirmware would be considered the payload with the
aim of not using FuFirmwareImage in the single-image case.
2021-03-09 21:14:12 +00:00

606 lines
17 KiB
C

/*
* Copyright (C) 2021 Realtek Corporation
* Copyright (C) 2021 Ricky Wu <ricky_wu@realtek.com> <spring1527@gmail.com>
*
* SPDX-License-Identifier: LGPL-2.1+
*/
#include "config.h"
#include "fu-chunk.h"
#include "fu-rts54hub-rtd21xx-device.h"
#include "fu-rts54hub-device.h"
struct _FuRts54hubRtd21xxDevice
{
FuDevice parent_instance;
guint8 target_addr;
guint8 i2c_speed;
guint8 register_addr_len;
};
G_DEFINE_TYPE (FuRts54hubRtd21xxDevice, fu_rts54hub_rtd21xx_device, FU_TYPE_DEVICE)
#define I2C_DELAY_AFTER_SEND 5000 /* us */
#define UC_FOREGROUND_SLAVE_ADDR 0x3A
#define UC_FOREGROUND_STATUS 0x31
#define UC_FOREGROUND_OPCODE 0x33
#define UC_FOREGROUND_ISP_DATA_OPCODE 0x34
#define ISP_DATA_BLOCKSIZE 256
#define ISP_PACKET_SIZE 257
typedef enum {
ISP_STATUS_BUSY = 0xBB, /* host must wait for device */
ISP_STATUS_IDLE_SUCCESS = 0x11, /* previous command was OK */
ISP_STATUS_IDLE_FAILURE = 0x12, /* previous command failed */
} IspStatus;
typedef enum {
ISP_CMD_ENTER_FW_UPDATE = 0x01,
ISP_CMD_GET_PROJECT_ID_ADDR = 0x02,
ISP_CMD_SYNC_IDENTIFY_CODE = 0x03,
ISP_CMD_GET_FW_INFO = 0x04,
ISP_CMD_FW_UPDATE_START = 0x05,
ISP_CMD_FW_UPDATE_ISP_DONE = 0x06,
ISP_CMD_FW_UPDATE_EXIT = 0x07,
ISP_CMD_FW_UPDATE_RESET = 0x08,
} IspCmd;
typedef enum {
VENDOR_CMD_DISABLE = 0x00,
VENDOR_CMD_ENABLE = 0x01,
VENDOR_CMD_ACCESS_FLASH = 0x02,
} VendorCmd;
static void
fu_rts54hub_rtd21xx_device_to_string (FuDevice *module, guint idt, GString *str)
{
FuRts54hubRtd21xxDevice *self = FU_RTS54HUB_RTD21XX_DEVICE (module);
fu_common_string_append_kx (str, idt, "TargetAddr", self->target_addr);
fu_common_string_append_kx (str, idt, "I2cSpeed", self->i2c_speed);
fu_common_string_append_kx (str, idt, "RegisterAddrLen", self->register_addr_len);
}
static FuRts54HubDevice *
fu_rts54hub_rtd21xx_device_get_parent (FuRts54hubRtd21xxDevice *self, GError **error)
{
FuDevice *parent = fu_device_get_parent (FU_DEVICE (self));
if (parent == NULL) {
g_set_error_literal (error,
FWUPD_ERROR,
FWUPD_ERROR_INTERNAL,
"no parent set");
return NULL;
}
return FU_RTS54HUB_DEVICE (parent);
}
static gboolean
fu_rts54hub_rtd21xx_device_set_quirk_kv (FuDevice *device,
const gchar *key,
const gchar *value,
GError **error)
{
FuRts54hubRtd21xxDevice *self = FU_RTS54HUB_RTD21XX_DEVICE (device);
/* load target address from quirks */
if (g_strcmp0 (key, "Rts54TargetAddr") == 0) {
guint64 tmp = fu_common_strtoull (value);
if (tmp <= 0xff) {
self->target_addr = tmp;
return TRUE;
}
g_set_error_literal (error,
G_IO_ERROR,
G_IO_ERROR_INVALID_DATA,
"invalid target address");
return FALSE;
}
/* load i2c speed from quirks */
if (g_strcmp0 (key, "Rts54I2cSpeed") == 0) {
guint64 tmp = fu_common_strtoull (value);
if (tmp < FU_RTS54HUB_I2C_SPEED_LAST) {
self->i2c_speed = tmp;
return TRUE;
}
g_set_error_literal (error,
G_IO_ERROR,
G_IO_ERROR_INVALID_DATA,
"invalid I²C speed");
return FALSE;
}
/* load register address length from quirks */
if (g_strcmp0 (key, "Rts54RegisterAddrLen") == 0) {
guint64 tmp = fu_common_strtoull (value);
if (tmp <= 0xff) {
self->register_addr_len = tmp;
return TRUE;
}
g_set_error_literal (error,
G_IO_ERROR,
G_IO_ERROR_INVALID_DATA,
"invalid register address length");
return FALSE;
}
/* failed */
g_set_error_literal (error,
G_IO_ERROR,
G_IO_ERROR_NOT_SUPPORTED,
"quirk key not supported");
return FALSE;
}
static gboolean
fu_rts54hub_rtd21xx_device_i2c_write (FuRts54hubRtd21xxDevice *self,
guint8 target_addr, guint8 sub_addr,
const guint8 *data, gsize datasz,
GError **error)
{
FuRts54HubDevice *parent;
parent = fu_rts54hub_rtd21xx_device_get_parent (self, error);
if (parent == NULL)
return FALSE;
if (!fu_rts54hub_device_vendor_cmd (parent, VENDOR_CMD_ENABLE, error))
return FALSE;
if (target_addr != self->target_addr) {
if (!fu_rts54hub_device_i2c_config (parent, target_addr, 1,
FU_RTS54HUB_I2C_SPEED_200K,
error))
return FALSE;
self->target_addr = target_addr;
}
if (!fu_rts54hub_device_i2c_write (parent, sub_addr, data, datasz, error)) {
g_prefix_error (error,
"failed to write I2C @0x%02x:%02x: ",
target_addr, sub_addr);
return FALSE;
}
g_usleep (I2C_DELAY_AFTER_SEND);
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_i2c_read (FuRts54hubRtd21xxDevice *self,
guint8 target_addr, guint8 sub_addr,
guint8 *data, gsize datasz,
GError **error)
{
FuRts54HubDevice *parent;
parent = fu_rts54hub_rtd21xx_device_get_parent (self, error);
if (parent == NULL)
return FALSE;
if (!fu_rts54hub_device_vendor_cmd (parent, VENDOR_CMD_ENABLE, error))
return FALSE;
if (target_addr != self->target_addr) {
if (!fu_rts54hub_device_i2c_config (parent, target_addr, 1,
FU_RTS54HUB_I2C_SPEED_200K,
error))
return FALSE;
self->target_addr = target_addr;
}
if (!fu_rts54hub_device_i2c_read (parent, sub_addr, data, datasz, error)) {
g_prefix_error (error, "failed to read I2C: ");
return FALSE;
}
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_read_status_raw (FuRts54hubRtd21xxDevice *self,
guint8 *status,
GError **error)
{
guint8 buf = 0x00;
if (!fu_rts54hub_rtd21xx_device_i2c_read (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_STATUS,
&buf, sizeof(buf),
error))
return FALSE;
if (status != NULL)
*status = buf;
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_read_status_cb (FuDevice *device,
gpointer user_data,
GError **error)
{
FuRts54hubRtd21xxDevice *self = FU_RTS54HUB_RTD21XX_DEVICE (device);
guint8 status = 0xfd;
if (!fu_rts54hub_rtd21xx_device_read_status_raw (self, &status, error))
return FALSE;
if (status == ISP_STATUS_BUSY) {
g_set_error (error,
FWUPD_ERROR,
FWUPD_ERROR_INTERNAL,
"status was 0x%02x", status);
return FALSE;
}
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_read_status (FuRts54hubRtd21xxDevice *self,
guint8 *status,
GError **error)
{
return fu_device_retry (FU_DEVICE (self),
fu_rts54hub_rtd21xx_device_read_status_cb,
4200, status, error);
}
static gboolean
fu_rts54hub_rtd21xx_ensure_version_unlocked (FuRts54hubRtd21xxDevice *self,
GError **error)
{
guint8 buf_rep[7] = { 0x00 };
guint8 buf_req[] = { ISP_CMD_GET_FW_INFO };
guint8 buf[] = { ISP_CMD_FW_UPDATE_RESET };
g_autofree gchar *version = NULL;
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_OPCODE,
buf_req, sizeof(buf_req),
error)) {
g_prefix_error (error, "failed to get version number: ");
return FALSE;
}
/* wait for device ready */
g_usleep(300000);
if (!fu_rts54hub_rtd21xx_device_i2c_read (self,
UC_FOREGROUND_SLAVE_ADDR,
0x00,
buf_rep, sizeof(buf_rep),
error)) {
g_prefix_error (error, "failed to get version number: ");
return FALSE;
}
/* set version */
version = g_strdup_printf ("%u.%u", buf_rep[1], buf_rep[2]);
fu_device_set_version (FU_DEVICE (self), version);
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_OPCODE,
buf, sizeof(buf),
error)) {
g_prefix_error (error, "failed to ISP_CMD_FW_UPDATE_RESET: ");
return FALSE;
}
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_detach_raw (FuRts54hubRtd21xxDevice *self, GError **error)
{
guint8 buf = 0x03;
if (!fu_rts54hub_rtd21xx_device_i2c_write (self, 0x6A, 0x31,
&buf, sizeof(buf), error)) {
g_prefix_error (error, "failed to detach: ");
return FALSE;
}
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_detach_cb (FuDevice *device,
gpointer user_data,
GError **error)
{
FuRts54hubRtd21xxDevice *self = FU_RTS54HUB_RTD21XX_DEVICE (device);
guint8 status = 0xfe;
if (!fu_rts54hub_rtd21xx_device_detach_raw (self, error))
return FALSE;
if (!fu_rts54hub_rtd21xx_device_read_status_raw (self, &status, error))
return FALSE;
if (status != ISP_STATUS_IDLE_SUCCESS) {
g_set_error (error,
FWUPD_ERROR,
FWUPD_ERROR_INTERNAL,
"detach status was 0x%02x", status);
return FALSE;
}
/* success */
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_setup (FuDevice *device, GError **error)
{
FuRts54hubRtd21xxDevice *self = FU_RTS54HUB_RTD21XX_DEVICE (device);
g_autoptr(FuDeviceLocker) locker = NULL;
/* get version */
locker = fu_device_locker_new_full (device,
(FuDeviceLockerFunc) fu_device_detach,
(FuDeviceLockerFunc) fu_device_attach,
error);
if (locker == NULL)
return FALSE;
if (!fu_rts54hub_rtd21xx_ensure_version_unlocked (self, error))
return FALSE;
/* success */
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_reload (FuDevice *device, GError **error)
{
FuRts54HubDevice *parent = FU_RTS54HUB_DEVICE (fu_device_get_parent (device));
g_autoptr(FuDeviceLocker) locker = NULL;
/* open parent device */
locker = fu_device_locker_new (parent, error);
if (locker == NULL)
return FALSE;
return fu_rts54hub_rtd21xx_device_setup (device, error);
}
static gboolean
fu_rts54hub_rtd21xx_device_detach (FuDevice *device, GError **error)
{
FuRts54HubDevice *parent = FU_RTS54HUB_DEVICE (fu_device_get_parent (device));
g_autoptr(FuDeviceLocker) locker = NULL;
/* open device */
locker = fu_device_locker_new (parent, error);
if (locker == NULL)
return FALSE;
if (!fu_device_retry (device,
fu_rts54hub_rtd21xx_device_detach_cb,
100, NULL, error))
return FALSE;
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_write_firmware (FuDevice *device,
FuFirmware *firmware,
FwupdInstallFlags flags,
GError **error)
{
FuRts54hubRtd21xxDevice *self = FU_RTS54HUB_RTD21XX_DEVICE (device);
const guint8 *fwbuf;
gsize fwbufsz = 0;
guint32 project_addr;
guint8 project_id_count;
guint8 read_buf[10] = { 0x0 };
guint8 write_buf[ISP_PACKET_SIZE] = { 0x0 };
g_autoptr(FuDeviceLocker) locker = NULL;
g_autoptr(GBytes) fw = NULL;
g_autoptr(GPtrArray) chunks = NULL;
/* open device */
locker = fu_device_locker_new (self, error);
if (locker == NULL)
return FALSE;
/* simple image */
fw = fu_firmware_get_bytes (firmware, error);
if (fw == NULL)
return FALSE;
fwbuf = g_bytes_get_data (fw, &fwbufsz);
/* enable ISP high priority */
write_buf[0] = ISP_CMD_ENTER_FW_UPDATE;
write_buf[1] = 0x01;
fu_device_set_status (device, FWUPD_STATUS_DEVICE_BUSY);
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_OPCODE,
write_buf, 2,
error)) {
g_prefix_error (error, "failed to enable ISP: ");
return FALSE;
}
if (!fu_rts54hub_rtd21xx_device_read_status (self, NULL, error))
return FALSE;
/* get project ID address */
write_buf[0] = ISP_CMD_GET_PROJECT_ID_ADDR;
fu_device_set_status (device, FWUPD_STATUS_DEVICE_READ);
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_OPCODE,
write_buf, 1,
error)) {
g_prefix_error (error, "failed to get project ID address: ");
return FALSE;
}
/* read back 6 bytes data */
g_usleep (I2C_DELAY_AFTER_SEND * 40);
if (!fu_rts54hub_rtd21xx_device_i2c_read (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_STATUS,
read_buf, 6,
error)) {
g_prefix_error (error, "failed to read project ID: ");
return FALSE;
}
if (read_buf[0] != ISP_STATUS_IDLE_SUCCESS) {
g_set_error (error, G_IO_ERROR, G_IO_ERROR_INVALID_DATA,
"failed project ID with error 0x%02x: ",
read_buf[0]);
return FALSE;
}
/* verify project ID */
project_addr = fu_common_read_uint32 (read_buf + 1, G_BIG_ENDIAN);
project_id_count = read_buf[5];
write_buf[0] = ISP_CMD_SYNC_IDENTIFY_CODE;
if (!fu_memcpy_safe (write_buf, sizeof(write_buf), 0x1, /* dst */
fwbuf, fwbufsz, project_addr, /* src */
project_id_count, error)) {
g_prefix_error (error,
"failed to write project ID from 0x%04x: ",
project_addr);
return FALSE;
}
fu_device_set_status (device, FWUPD_STATUS_DEVICE_BUSY);
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_OPCODE,
write_buf,
project_id_count + 1,
error)) {
g_prefix_error (error, "failed to send fw update start cmd: ");
return FALSE;
}
if (!fu_rts54hub_rtd21xx_device_read_status (self, NULL, error))
return FALSE;
/* background FW update start command */
write_buf[0] = ISP_CMD_FW_UPDATE_START;
fu_common_write_uint16 (write_buf + 1, ISP_DATA_BLOCKSIZE, G_BIG_ENDIAN);
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_OPCODE,
write_buf, 3,
error)) {
g_prefix_error (error, "failed to send fw update start cmd: ");
return FALSE;
}
/* send data */
fu_device_set_status (device, FWUPD_STATUS_DEVICE_WRITE);
chunks = fu_chunk_array_new_from_bytes (fw,
0x00, /* start addr */
0x00, /* page_sz */
ISP_DATA_BLOCKSIZE);
for (guint i = 0; i < chunks->len; i++) {
FuChunk *chk = g_ptr_array_index (chunks, i);
if (!fu_rts54hub_rtd21xx_device_read_status (self, NULL, error))
return FALSE;
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_ISP_DATA_OPCODE,
fu_chunk_get_data (chk),
fu_chunk_get_data_sz (chk),
error)) {
g_prefix_error (error,
"failed to write @0x%04x: ",
fu_chunk_get_address (chk));
return FALSE;
}
/* update progress */
fu_device_set_progress_full (device, (gsize) i, (gsize) chunks->len);
}
/* update finish command */
fu_device_set_status (device, FWUPD_STATUS_DEVICE_BUSY);
if (!fu_rts54hub_rtd21xx_device_read_status (self, NULL, error))
return FALSE;
write_buf[0] = ISP_CMD_FW_UPDATE_ISP_DONE;
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_OPCODE,
write_buf, 1,
error)) {
g_prefix_error (error, "failed update finish cmd: ");
return FALSE;
}
/* exit background-fw mode */
fu_device_set_status (device, FWUPD_STATUS_DEVICE_RESTART);
fu_device_set_progress (device, 0);
if (!fu_rts54hub_rtd21xx_device_read_status (self, NULL, error))
return FALSE;
write_buf[0] = ISP_CMD_FW_UPDATE_EXIT;
if (!fu_rts54hub_rtd21xx_device_i2c_write (self,
UC_FOREGROUND_SLAVE_ADDR,
UC_FOREGROUND_OPCODE,
write_buf, 1,
error)) {
g_prefix_error (error, "exit background-fw mode: ");
return FALSE;
}
/* the device needs some time to restart with the new firmware before
* it can be queried again */
fu_device_sleep_with_progress (device, 60);
/* success */
return TRUE;
}
static gboolean
fu_rts54hub_rtd21xx_device_open (FuDevice *device, GError **error)
{
FuDevice *parent = fu_device_get_parent (device);
if (parent == NULL) {
g_set_error_literal (error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"no parent device");
return FALSE;
}
return fu_device_open (parent, error);
}
static gboolean
fu_rts54hub_rtd21xx_device_close (FuDevice *device, GError **error)
{
FuDevice *parent = fu_device_get_parent (device);
if (parent == NULL) {
g_set_error_literal (error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"no parent device");
return FALSE;
}
return fu_device_close (parent, error);
}
static void
fu_rts54hub_rtd21xx_device_init (FuRts54hubRtd21xxDevice *self)
{
fu_device_add_icon (FU_DEVICE (self), "video-display");
fu_device_add_protocol (FU_DEVICE (self), "com.realtek.rts54.i2c");
fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_UPDATABLE);
fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_DUAL_IMAGE);
fu_device_set_version_format (FU_DEVICE (self), FWUPD_VERSION_FORMAT_PAIR);
fu_device_set_install_duration (FU_DEVICE (self), 100); /* seconds */
fu_device_set_logical_id (FU_DEVICE (self), "I2C");
fu_device_retry_set_delay (FU_DEVICE (self), 30); /* ms */
}
static void
fu_rts54hub_rtd21xx_device_class_init (FuRts54hubRtd21xxDeviceClass *klass)
{
FuDeviceClass *klass_device = FU_DEVICE_CLASS (klass);
klass_device->setup = fu_rts54hub_rtd21xx_device_setup;
klass_device->reload = fu_rts54hub_rtd21xx_device_reload;
klass_device->detach = fu_rts54hub_rtd21xx_device_detach;
klass_device->write_firmware = fu_rts54hub_rtd21xx_device_write_firmware;
klass_device->to_string = fu_rts54hub_rtd21xx_device_to_string;
klass_device->set_quirk_kv = fu_rts54hub_rtd21xx_device_set_quirk_kv;
klass_device->open = fu_rts54hub_rtd21xx_device_open;
klass_device->close = fu_rts54hub_rtd21xx_device_close;
}
FuRts54hubRtd21xxDevice *
fu_rts54hub_rtd21xx_device_new (void)
{
FuRts54hubRtd21xxDevice *self = NULL;
self = g_object_new (FU_TYPE_RTS54HUB_RTD21XX_DEVICE, NULL);
return self;
}