fwupd/plugins/pci-psp/fu-pci-psp-device.c
Mario Limonciello 52d6c3cb78 Update documentation to indicate that loading "OS Optimized Defaults"
may enable security processor rollback protection on Lenovo systems.

fixes: #5394
2023-01-18 08:08:16 +00:00

289 lines
8.7 KiB
C

/*
* Copyright (C) 2022 Advanced Micro Devices Inc.
*
* SPDX-License-Identifier: LGPL-2.1+
*/
#include "config.h"
#include <fwupdplugin.h>
#include "fu-pci-psp-device.h"
struct _FuPciPspDevice {
FuUdevDevice parent_instance;
};
G_DEFINE_TYPE(FuPciPspDevice, fu_pci_psp_device, FU_TYPE_UDEV_DEVICE)
static gboolean
fu_pci_psp_device_get_attr(FwupdSecurityAttr *attr,
const gchar *path,
const gchar *file,
gboolean *out,
GError **error)
{
guint64 val = 0;
g_autofree gchar *fn = g_build_filename(path, file, NULL);
g_autofree gchar *buf = NULL;
gsize bufsz = 0;
if (!g_file_get_contents(fn, &buf, &bufsz, error)) {
g_prefix_error(error, "could not open %s: ", fn);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_MISSING_DATA);
return FALSE;
}
if (!fu_strtoull(buf, &val, 0, G_MAXUINT32, error))
return FALSE;
*out = val ? TRUE : FALSE;
return TRUE;
}
static void
fu_pci_psp_device_add_security_attrs_tsme(FuDevice *device,
const gchar *path,
FuSecurityAttrs *attrs)
{
g_autoptr(FwupdSecurityAttr) attr = NULL;
g_autoptr(GError) error_local = NULL;
gboolean val;
attr = fu_device_security_attr_new(device, FWUPD_SECURITY_ATTR_ID_ENCRYPTED_RAM);
fu_security_attrs_append(attrs, attr);
if (!fu_pci_psp_device_get_attr(attr, path, "tsme_status", &val, &error_local)) {
g_debug("%s", error_local->message);
return;
}
/* BIOS knob used on Lenovo systems */
fu_security_attr_add_bios_target_value(attr, "com.thinklmi.TSME", "enable");
if (!val) {
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_NOT_ENCRYPTED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_ACTION_CONFIG_FW);
return;
}
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_ENCRYPTED);
fwupd_security_attr_add_obsolete(attr, "msr");
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_SUCCESS);
}
static void
fu_pci_psp_device_add_security_attrs_fused_part(FuDevice *device,
const gchar *path,
FuSecurityAttrs *attrs)
{
g_autoptr(FwupdSecurityAttr) attr = NULL;
g_autoptr(GError) error_local = NULL;
gboolean val;
attr = fu_device_security_attr_new(device, FWUPD_SECURITY_ATTR_ID_PLATFORM_FUSED);
fu_security_attrs_append(attrs, attr);
if (!fu_pci_psp_device_get_attr(attr, path, "fused_part", &val, &error_local)) {
g_debug("%s", error_local->message);
return;
}
if (!val) {
g_debug("part is not fused");
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_NOT_LOCKED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_ACTION_CONTACT_OEM);
return;
}
/* success */
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_LOCKED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_SUCCESS);
}
static void
fu_pci_psp_device_add_security_attrs_debug_locked_part(FuDevice *device,
const gchar *path,
FuSecurityAttrs *attrs)
{
g_autoptr(FwupdSecurityAttr) attr = NULL;
g_autoptr(GError) error_local = NULL;
gboolean val;
attr = fu_device_security_attr_new(device, FWUPD_SECURITY_ATTR_ID_PLATFORM_DEBUG_LOCKED);
fu_security_attrs_append(attrs, attr);
if (!fu_pci_psp_device_get_attr(attr, path, "debug_lock_on", &val, &error_local)) {
g_debug("%s", error_local->message);
return;
}
if (!val) {
g_debug("debug lock disabled");
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_NOT_LOCKED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_ACTION_CONTACT_OEM);
return;
}
/* success */
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_LOCKED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_SUCCESS);
}
static void
fu_pci_psp_device_add_security_attrs_rollback_protection(FuDevice *device,
const gchar *path,
FuSecurityAttrs *attrs)
{
g_autoptr(FwupdSecurityAttr) attr = NULL;
g_autoptr(GError) error_local = NULL;
gboolean val;
attr = fu_device_security_attr_new(device, FWUPD_SECURITY_ATTR_ID_AMD_ROLLBACK_PROTECTION);
fu_security_attrs_append(attrs, attr);
if (!fu_pci_psp_device_get_attr(attr, path, "anti_rollback_status", &val, &error_local)) {
g_debug("%s", error_local->message);
return;
}
if (!val) {
g_debug("rollback protection not enforced");
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_NOT_ENABLED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_ACTION_CONTACT_OEM);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_ACTION_CONFIG_FW);
return;
}
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_ENABLED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_SUCCESS);
}
static void
fu_pci_psp_device_add_security_attrs_rom_armor(FuDevice *device,
const gchar *path,
FuSecurityAttrs *attrs)
{
g_autoptr(FwupdSecurityAttr) attr = NULL;
g_autoptr(GError) error_local = NULL;
gboolean val;
/* create attr */
attr = fu_device_security_attr_new(device, FWUPD_SECURITY_ATTR_ID_AMD_SPI_WRITE_PROTECTION);
fu_security_attrs_append(attrs, attr);
if (!fu_pci_psp_device_get_attr(attr, path, "rom_armor_enforced", &val, &error_local)) {
g_debug("%s", error_local->message);
return;
}
if (!val) {
g_debug("ROM armor not enforced");
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_NOT_ENABLED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_ACTION_CONTACT_OEM);
return;
}
/* success */
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_ENABLED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_SUCCESS);
}
static void
fu_pci_psp_device_add_security_attrs_rpmc(FuDevice *device,
const gchar *path,
FuSecurityAttrs *attrs)
{
g_autoptr(FwupdSecurityAttr) attr = NULL;
g_autoptr(GError) error_local = NULL;
gboolean val;
/* create attr */
attr =
fu_device_security_attr_new(device, FWUPD_SECURITY_ATTR_ID_AMD_SPI_REPLAY_PROTECTION);
fu_security_attrs_append(attrs, attr);
if (!fu_pci_psp_device_get_attr(attr, path, "rpmc_spirom_available", &val, &error_local)) {
g_debug("%s", error_local->message);
return;
}
if (!val) {
g_debug("no RPMC compatible SPI rom present");
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_NOT_SUPPORTED);
return;
}
if (!fu_pci_psp_device_get_attr(attr,
path,
"rpmc_production_enabled",
&val,
&error_local)) {
g_debug("%s", error_local->message);
return;
}
if (!val) {
g_debug("no RPMC compatible SPI rom present");
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_NOT_ENABLED);
return;
}
/* success */
fwupd_security_attr_set_result(attr, FWUPD_SECURITY_ATTR_RESULT_ENABLED);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_SUCCESS);
}
static void
fu_pci_psp_device_set_missing_data(FuDevice *device, FuSecurityAttrs *attrs)
{
g_autoptr(FwupdSecurityAttr) attr = NULL;
attr = fu_device_security_attr_new(device, FWUPD_SECURITY_ATTR_ID_SUPPORTED_CPU);
fwupd_security_attr_add_obsolete(attr, "cpu");
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_MISSING_DATA);
fwupd_security_attr_add_flag(attr, FWUPD_SECURITY_ATTR_FLAG_ACTION_CONTACT_OEM);
fu_security_attrs_append(attrs, attr);
}
static void
fu_pci_psp_device_add_security_attrs(FuDevice *device, FuSecurityAttrs *attrs)
{
const gchar *sysfs_path = NULL;
g_autofree gchar *test_file = NULL;
/* ccp not loaded */
if (device != NULL) {
sysfs_path = fu_udev_device_get_sysfs_path(FU_UDEV_DEVICE(device));
test_file = g_build_filename(sysfs_path, "tsme_status", NULL);
}
if (sysfs_path == NULL || !g_file_test(test_file, G_FILE_TEST_EXISTS)) {
fu_pci_psp_device_set_missing_data(device, attrs);
return;
}
fu_pci_psp_device_add_security_attrs_tsme(device, sysfs_path, attrs);
fu_pci_psp_device_add_security_attrs_fused_part(device, sysfs_path, attrs);
fu_pci_psp_device_add_security_attrs_debug_locked_part(device, sysfs_path, attrs);
fu_pci_psp_device_add_security_attrs_rollback_protection(device, sysfs_path, attrs);
fu_pci_psp_device_add_security_attrs_rpmc(device, sysfs_path, attrs);
fu_pci_psp_device_add_security_attrs_rom_armor(device, sysfs_path, attrs);
}
static void
fu_pci_psp_device_init(FuPciPspDevice *self)
{
fu_device_set_name(FU_DEVICE(self), "Secure Processor");
fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_INTERNAL);
fu_device_add_icon(FU_DEVICE(self), "computer");
fu_device_add_parent_guid(FU_DEVICE(self), "cpu");
fu_device_set_vendor(FU_DEVICE(self), "AMD");
fu_device_set_version_format(FU_DEVICE(self), FWUPD_VERSION_FORMAT_QUAD);
fu_device_set_physical_id(FU_DEVICE(self), "pci-psp");
}
static void
fu_pci_psp_device_class_init(FuPciPspDeviceClass *klass)
{
FuDeviceClass *klass_device = FU_DEVICE_CLASS(klass);
klass_device->add_security_attrs = fu_pci_psp_device_add_security_attrs;
}