mirror of
https://git.proxmox.com/git/fwupd
synced 2025-07-14 05:09:41 +00:00
0c51630991
Some parsers are ignoring the magic when using _FLAG_IGNORE_CHECKSUM (which is wrong; fuzzers have no problem with enforcing a static prefix) and other either disregard the offset or check the magic in an unsafe way. Also, use FWUPD_ERROR_INVALID_FILE consistently for magic failure. Add a vfunc, and move all the clever code into one place.
93 lines
1.9 KiB
C
93 lines
1.9 KiB
C
/*
|
|
* Copyright (C) 2020 Richard Hughes <richard@hughsie.com>
|
|
*
|
|
* SPDX-License-Identifier: LGPL-2.1+
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <fwupdplugin.h>
|
|
|
|
#include <string.h>
|
|
|
|
#include "fu-ep963x-common.h"
|
|
#include "fu-ep963x-firmware.h"
|
|
|
|
struct _FuEp963xFirmware {
|
|
FuFirmware parent_instance;
|
|
};
|
|
|
|
G_DEFINE_TYPE(FuEp963xFirmware, fu_ep963x_firmware, FU_TYPE_FIRMWARE)
|
|
|
|
static gboolean
|
|
fu_ep963x_firmware_check_magic(FuFirmware *firmware, GBytes *fw, gsize offset, GError **error)
|
|
{
|
|
guint8 magic[5] = {0x0};
|
|
|
|
if (!fu_memcpy_safe(magic,
|
|
sizeof(magic),
|
|
0, /* dst */
|
|
g_bytes_get_data(fw, NULL),
|
|
g_bytes_get_size(fw),
|
|
offset + 16,
|
|
sizeof(magic),
|
|
error)) {
|
|
g_prefix_error(error, "failed to read magic: ");
|
|
return FALSE;
|
|
}
|
|
if (memcmp(magic, "EP963", sizeof(magic)) != 0) {
|
|
g_set_error_literal(error,
|
|
FWUPD_ERROR,
|
|
FWUPD_ERROR_INVALID_FILE,
|
|
"invalid EP963x binary file");
|
|
return FALSE;
|
|
}
|
|
|
|
/* success */
|
|
return TRUE;
|
|
}
|
|
|
|
static gboolean
|
|
fu_ep963x_firmware_parse(FuFirmware *firmware,
|
|
GBytes *fw,
|
|
gsize offset,
|
|
FwupdInstallFlags flags,
|
|
GError **error)
|
|
{
|
|
gsize len = g_bytes_get_size(fw);
|
|
|
|
/* check size */
|
|
if (len != FU_EP963_FIRMWARE_SIZE) {
|
|
g_set_error(error,
|
|
FWUPD_ERROR,
|
|
FWUPD_ERROR_INVALID_FILE,
|
|
"firmware size expected 0x%x, got 0x%x",
|
|
(guint)FU_EP963_FIRMWARE_SIZE,
|
|
(guint)len);
|
|
return FALSE;
|
|
}
|
|
|
|
/* success */
|
|
fu_firmware_set_bytes(firmware, fw);
|
|
return TRUE;
|
|
}
|
|
|
|
static void
|
|
fu_ep963x_firmware_init(FuEp963xFirmware *self)
|
|
{
|
|
}
|
|
|
|
static void
|
|
fu_ep963x_firmware_class_init(FuEp963xFirmwareClass *klass)
|
|
{
|
|
FuFirmwareClass *klass_firmware = FU_FIRMWARE_CLASS(klass);
|
|
klass_firmware->check_magic = fu_ep963x_firmware_check_magic;
|
|
klass_firmware->parse = fu_ep963x_firmware_parse;
|
|
}
|
|
|
|
FuFirmware *
|
|
fu_ep963x_firmware_new(void)
|
|
{
|
|
return FU_FIRMWARE(g_object_new(FU_TYPE_EP963X_FIRMWARE, NULL));
|
|
}
|