fwupd/plugins/wacom-usb/fu-wac-module-bluetooth.c
Richard Hughes 5308ea4fae Never use memcpy() in a possibly unsafe way
There are several subtle bugs in various places in fwupd caused by not treating
user-provided offsets into buffers as unsafe. As fwupd runs as root we have to
assume that all user firmware is evil, and also that devices cannot be trusted.

Make a helper to put all the logic into one place and convert all users.
2019-08-12 09:22:09 -05:00

200 lines
5.7 KiB
C

/*
* Copyright (C) 2018 Richard Hughes <richard@hughsie.com>
*
* SPDX-License-Identifier: LGPL-2.1+
*/
#include "config.h"
#include <string.h>
#include "fu-wac-common.h"
#include "fu-wac-device.h"
#include "fu-wac-module-bluetooth.h"
struct _FuWacModuleBluetooth
{
FuWacModule parent_instance;
};
G_DEFINE_TYPE (FuWacModuleBluetooth, fu_wac_module_bluetooth, FU_TYPE_WAC_MODULE)
#define FU_WAC_MODULE_BLUETOOTH_PAYLOAD_SZ 256
#define FU_WAC_MODULE_BLUETOOTH_ADDR_USERDATA_START 0x3000
#define FU_WAC_MODULE_BLUETOOTH_ADDR_USERDATA_STOP 0x8000
typedef struct {
guint8 preamble[7];
guint8 addr[3];
guint8 crc;
guint8 cdata[FU_WAC_MODULE_BLUETOOTH_PAYLOAD_SZ];
} FuWacModuleBluetoothBlockData;
static void
fu_wac_module_bluetooth_calculate_crc_byte (guint8 *crc, guint8 data)
{
guint8 c[8];
guint8 m[8];
guint8 r[8];
/* find out what bits are set */
for (guint i = 0; i < 8; i++) {
c[i] = (*crc & (1 << i)) != 0;
m[i] = (data & (1 << i)) != 0;
}
/* do CRC on byte */
r[7] = (c[7] ^ m[4] ^ c[3] ^ m[3] ^ c[4] ^ m[6] ^ c[1] ^ m[0]);
r[6] = (c[6] ^ m[5] ^ c[2] ^ m[4] ^ c[3] ^ m[7] ^ c[0] ^ m[1]);
r[5] = (c[5] ^ m[6] ^ c[1] ^ m[5] ^ c[2] ^ m[2]);
r[4] = (c[4] ^ m[7] ^ c[0] ^ m[6] ^ c[1] ^ m[3]);
r[3] = (m[7] ^ m[0] ^ c[7] ^ c[0] ^ m[3] ^ c[4] ^ m[6] ^ c[1]);
r[2] = (m[1] ^ c[6] ^ m[0] ^ c[7] ^ m[3] ^ c[4] ^ m[7] ^ c[0] ^ m[6] ^ c[1]);
r[1] = (m[2] ^ c[5] ^ m[1] ^ c[6] ^ m[4] ^ c[3] ^ m[7] ^ c[0]);
r[0] = (m[3] ^ c[4] ^ m[2] ^ c[5] ^ m[5] ^ c[2]);
/* copy back into CRC */
*crc = 0;
for (guint i = 0; i < 8; i++) {
if (r[i] == 0)
continue;
*crc |= (1 << i);
}
}
static guint8
fu_wac_module_bluetooth_calculate_crc (const guint8 *data, gsize sz)
{
guint8 crc = 0;
for (gsize i = 0; i < sz; i++)
fu_wac_module_bluetooth_calculate_crc_byte (&crc, data[i]);
return crc;
}
static GPtrArray *
fu_wac_module_bluetooth_parse_blocks (const guint8 *data, gsize sz, gboolean skip_user_data, GError **error)
{
const guint8 preamble[] = {0x02, 0x00, 0x0f, 0x06, 0x01, 0x08, 0x01};
GPtrArray *blocks = g_ptr_array_new_with_free_func (g_free);
for (guint addr = 0x0; addr < sz; addr += FU_WAC_MODULE_BLUETOOTH_PAYLOAD_SZ) {
FuWacModuleBluetoothBlockData *bd;
gsize cdata_sz = FU_WAC_MODULE_BLUETOOTH_PAYLOAD_SZ;
/* user data area */
if (skip_user_data &&
addr >= FU_WAC_MODULE_BLUETOOTH_ADDR_USERDATA_START &&
addr < FU_WAC_MODULE_BLUETOOTH_ADDR_USERDATA_STOP)
continue;
bd = g_new0 (FuWacModuleBluetoothBlockData, 1);
memcpy (bd->preamble, preamble, sizeof (preamble));
bd->addr[0] = (addr >> 16) & 0xff;
bd->addr[1] = (addr >> 8) & 0xff;
bd->addr[2] = addr & 0xff;
memset (bd->cdata, 0xff, FU_WAC_MODULE_BLUETOOTH_PAYLOAD_SZ);
/* if file is not in multiples of payload size */
if (addr + FU_WAC_MODULE_BLUETOOTH_PAYLOAD_SZ >= sz)
cdata_sz = sz - addr;
if (!fu_memcpy_safe (bd->cdata, sizeof(bd->cdata), 0x0, /* dst */
data, sz, addr, /* src */
cdata_sz, error))
return NULL;
bd->crc = fu_wac_module_bluetooth_calculate_crc (bd->cdata,
FU_WAC_MODULE_BLUETOOTH_PAYLOAD_SZ);
g_ptr_array_add (blocks, bd);
}
return blocks;
}
static gboolean
fu_wac_module_bluetooth_write_firmware (FuDevice *device,
FuFirmware *firmware,
FwupdInstallFlags flags,
GError **error)
{
FuWacModule *self = FU_WAC_MODULE (device);
const guint8 *data;
gsize len = 0;
gsize blocks_total = 0;
const guint8 buf_start[] = { 0x00 };
g_autoptr(GPtrArray) blocks = NULL;
g_autoptr(GBytes) blob_start = g_bytes_new_static (buf_start, 1);
g_autoptr(GBytes) fw = NULL;
/* get default image */
fw = fu_firmware_get_image_default_bytes (firmware, error);
if (fw == NULL)
return FALSE;
/* build each data packet */
data = g_bytes_get_data (fw, &len);
blocks = fu_wac_module_bluetooth_parse_blocks (data, len, TRUE, error);
if (blocks == NULL)
return FALSE;
blocks_total = blocks->len + 2;
/* start, which will erase the module */
fu_device_set_status (device, FWUPD_STATUS_DEVICE_ERASE);
if (!fu_wac_module_set_feature (self, FU_WAC_MODULE_COMMAND_START, blob_start, error))
return FALSE;
/* update progress */
fu_device_set_progress_full (device, 1, blocks_total);
/* data */
fu_device_set_status (device, FWUPD_STATUS_DEVICE_WRITE);
for (guint i = 0; i < blocks->len; i++) {
FuWacModuleBluetoothBlockData *bd = g_ptr_array_index (blocks, i);
guint8 buf[256+11];
g_autoptr(GBytes) blob_chunk = NULL;
/* build data packet */
memset (buf, 0xff, sizeof(buf));
memcpy(&buf[0], bd->preamble, 7);
memcpy(&buf[7], bd->addr, 3);
buf[10] = bd->crc;
memcpy (&buf[11], bd->cdata, sizeof(bd->cdata));
blob_chunk = g_bytes_new (buf, sizeof(buf));
if (!fu_wac_module_set_feature (self, FU_WAC_MODULE_COMMAND_DATA,
blob_chunk, error))
return FALSE;
/* update progress */
fu_device_set_progress_full (device, i + 1, blocks_total);
}
/* end */
if (!fu_wac_module_set_feature (self, FU_WAC_MODULE_COMMAND_END, NULL, error))
return FALSE;
/* update progress */
fu_device_set_progress_full (device, blocks_total, blocks_total);
return TRUE;
}
static void
fu_wac_module_bluetooth_init (FuWacModuleBluetooth *self)
{
fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_UPDATABLE);
fu_device_set_install_duration (FU_DEVICE (self), 30);
}
static void
fu_wac_module_bluetooth_class_init (FuWacModuleBluetoothClass *klass)
{
FuDeviceClass *klass_device = FU_DEVICE_CLASS (klass);
klass_device->write_firmware = fu_wac_module_bluetooth_write_firmware;
}
FuWacModule *
fu_wac_module_bluetooth_new (GUsbDevice *usb_device)
{
FuWacModule *module = NULL;
module = g_object_new (FU_TYPE_WAC_MODULE_BLUETOOTH,
"usb-device", usb_device,
"fw-type", FU_WAC_MODULE_FW_TYPE_BLUETOOTH,
NULL);
return module;
}