mirror of
https://git.proxmox.com/git/fwupd
synced 2025-05-15 14:14:13 +00:00
834b28009d
This allows delaying the activation of Thunderbolt firmware until shutdown/reboot or when the dock is unplugged. This functionality requires features in the kernel: https://lore.kernel.org/linux-usb/20200622143035.25327-1-mario.limonciello@dell.com/T/#t Matrix of cases to support: * Distro Old Linux kernel (doesn't support authenticate on disconnect) - WD19TB: Should have `skips-restart` flag set No flush or activate features called in `thunderbolt` plugin. `dell_dock` plugin will activate at end of composite update - All other devices: Shouldn't have flags set Should authenticate in Thunderbolt plugin. `1 > nvm_authenticate` * Distro New Linux kernel (supports authenticate on disconnect) - WD19TB: Should have `usable-during-update` flag set but not `skips-restart` Should flush image to SPI in `thunderbolt` plugin `2 > nvm_authenticate_on_disconnect` Should configure TBT device for authenticate on disconnect `1 > nvm_authenticate_on_disconnect` `dell_dock` plugin will configure dock for authenticate on disconnect - All other devices: Shouldn't have flags set Should authenticate in `thunderbolt` plugin. `1 > nvm_authenticate` * ChromeOS (supports authenticate on disconnect) - `thunerbolt.conf` will have `DelayedActivation=true`. - WD19TB: Should have `usable-during-update` flag set but not `skips-restart` Should flush image to SPI in `thunderbolt` plugin `2 > nvm_authenticate_on_disconnect` Should configure device for authenticate on disconnect `1 > nvm_authenticate_on_disconnect` `dell_dock` plugin will configure dock for authenticate on disconnect - All other devices: Should have both `usable-during-update` and `skips-restart` set Should flush image to SPI in `thunderbolt` plugin `2 > nvm_authenticate` Will activate upon logout/shutdown/reboot `1 > nvm_authenticate`
91 lines
2.6 KiB
C
91 lines
2.6 KiB
C
/*
|
|
* Copyright (C) 2017 Christian J. Kellner <christian@kellner.me>
|
|
*
|
|
* SPDX-License-Identifier: LGPL-2.1+
|
|
*/
|
|
|
|
#include "config.h"
|
|
|
|
#include <sys/utsname.h>
|
|
|
|
#include "fu-plugin-vfuncs.h"
|
|
#include "fu-hash.h"
|
|
#include "fu-thunderbolt-device.h"
|
|
#include "fu-thunderbolt-firmware.h"
|
|
#include "fu-thunderbolt-firmware-update.h"
|
|
|
|
static gboolean
|
|
fu_plugin_thunderbolt_safe_kernel (FuPlugin *plugin, GError **error)
|
|
{
|
|
g_autofree gchar *minimum_kernel = NULL;
|
|
struct utsname name_tmp;
|
|
|
|
memset (&name_tmp, 0, sizeof(struct utsname));
|
|
if (uname (&name_tmp) < 0) {
|
|
g_debug ("Failed to read current kernel version");
|
|
return TRUE;
|
|
}
|
|
|
|
minimum_kernel = fu_plugin_get_config_value (plugin, "MinimumKernelVersion");
|
|
if (minimum_kernel == NULL) {
|
|
g_debug ("Ignoring kernel safety checks");
|
|
return TRUE;
|
|
}
|
|
|
|
if (fu_common_vercmp_full (name_tmp.release,
|
|
minimum_kernel,
|
|
FWUPD_VERSION_FORMAT_TRIPLET) < 0) {
|
|
g_set_error (error,
|
|
FWUPD_ERROR,
|
|
FWUPD_ERROR_INTERNAL,
|
|
"kernel %s may not have full Thunderbolt support",
|
|
name_tmp.release);
|
|
return FALSE;
|
|
}
|
|
g_debug ("Using kernel %s (minimum %s)", name_tmp.release, minimum_kernel);
|
|
|
|
return TRUE;
|
|
}
|
|
|
|
gboolean
|
|
fu_plugin_device_created (FuPlugin *plugin, FuDevice *dev, GError **error)
|
|
{
|
|
fu_plugin_add_rule (plugin, FU_PLUGIN_RULE_INHIBITS_IDLE,
|
|
"thunderbolt requires device wakeup");
|
|
fu_device_set_quirks (dev, fu_plugin_get_quirks (plugin));
|
|
return TRUE;
|
|
}
|
|
|
|
void
|
|
fu_plugin_device_registered (FuPlugin *plugin, FuDevice *device)
|
|
{
|
|
if (g_strcmp0 (fu_device_get_plugin (device), "thunderbolt") != 0)
|
|
return;
|
|
|
|
/* Operating system will handle finishing updates later */
|
|
if (fu_plugin_get_config_value_boolean (plugin, "DelayedActivation")) {
|
|
g_debug ("Turning on delayed activation for %s",
|
|
fu_device_get_name (device));
|
|
fu_device_add_flag (device, FWUPD_DEVICE_FLAG_USABLE_DURING_UPDATE);
|
|
fu_device_add_flag (device, FWUPD_DEVICE_FLAG_SKIPS_RESTART);
|
|
}
|
|
}
|
|
|
|
void
|
|
fu_plugin_init (FuPlugin *plugin)
|
|
{
|
|
fu_plugin_set_build_hash (plugin, FU_BUILD_HASH);
|
|
fu_plugin_add_udev_subsystem (plugin, "thunderbolt");
|
|
fu_plugin_set_device_gtype (plugin, FU_TYPE_THUNDERBOLT_DEVICE);
|
|
fu_plugin_add_firmware_gtype (plugin, "thunderbolt", FU_TYPE_THUNDERBOLT_FIRMWARE);
|
|
fu_plugin_add_firmware_gtype (plugin, "thunderbolt-update", FU_TYPE_THUNDERBOLT_FIRMWARE_UPDATE);
|
|
/* dell-dock plugin uses a slower bus for flashing */
|
|
fu_plugin_add_rule (plugin, FU_PLUGIN_RULE_BETTER_THAN, "dell_dock");
|
|
}
|
|
|
|
gboolean
|
|
fu_plugin_startup (FuPlugin *plugin, GError **error)
|
|
{
|
|
return fu_plugin_thunderbolt_safe_kernel (plugin, error);
|
|
}
|