Commit Graph

8363 Commits

Author SHA1 Message Date
Mario Limonciello
e828ab4d19 trivial: explicitly install python3-apt for Debian container too 2022-06-26 16:01:10 -05:00
Mario Limonciello
7e007b3bfa trivial: add sudo for debian-i386 CI build 2022-06-26 16:01:10 -05:00
Mario Limonciello
fb701a0426 Fix running fwupdtool security with a plugin allowlist
A number of plugins make assumptions that ->init() was called, but
when an allowlist is used this won't have been called.
2022-06-26 13:57:53 -05:00
Richard Hughes
b8be6daf1f trivial: Use 'priv' for plugin private data to be consistent 2022-06-26 13:57:53 -05:00
Mario Limonciello
f5c7f2b789 trivial: ci: switch libsystemd dependency to systemd 2022-06-23 16:45:06 -05:00
Richard Hughes
a70d005ea3 trivial: Use a better error message disambiguate an error message 2022-06-23 21:56:06 +01:00
Mario Limonciello
030a0d51c1 trivial: quiet the modem manager error about unable to probe
We don't show messages in the logs about unable to probe other
device types by default, MM should be no different.
This gets rid of this message coming up every fwupd startup on a
EM05-G:
"failed to probe MM device: modem cannot be put in programming mode"
2022-06-23 14:53:58 -05:00
Andrii Dushko
8cb70497ac corsair: remove support for some devices
Vendor has decided to remove these devices from the initial supported
device list:
* SABRE RGB PRO WIRELESS Gaming Mouse
* SLIPSTREAM WIRELESS USB Receiver
2022-06-23 20:05:43 +01:00
Richard Hughes
eac80ccac3 trivial: Document the ->set_progress() vfunc
Fixes https://github.com/fwupd/fwupd/issues/4755
2022-06-23 14:16:54 +01:00
daniil-lunev
ab8a0533d8
Add eMMC guids to include FW version
Those are required if we need to re-map FW versions with quirks. Some
devices physical version number are not consecutively mapped to logical
version number.
2022-06-22 15:58:57 +01:00
Andrii Dushko
802105af7f corsair: add HARPOON RGB Wireless mouse 2022-06-22 15:58:12 +01:00
Richard Hughes
dc1730c439 trivial: Some clang-format fixups 2022-06-22 15:55:32 +01:00
Jeremy Soller
751de3f4d2 Add System76 launch_2 2022-06-21 09:58:51 -05:00
Gaël PORTAY
c74b4ec438 trivial: Fix typo 2022-06-21 03:27:38 -04:00
Mario Limonciello
0f07fe16b1 trivial: fix arch CI build 2022-06-21 03:27:38 -04:00
Mario Limonciello
6a2637c823 trivial: fix debian CI build 2022-06-21 03:27:38 -04:00
Gaël PORTAY
299b42fe96 trivial: Make meson.build indentation consistent 2022-06-21 03:27:38 -04:00
Richard Hughes
5e899535d4 amt: Modernize the plugin and split out common functionality
The MEI code is soon going to be used by a new plugin, so split it
out into libfwupdplugin like we did i2c.
2022-06-21 08:10:04 +01:00
Gaël PORTAY
9b969de718 Save serial number and instance-ids when trusted
See commit e3016602f8.
2022-06-20 12:57:40 -04:00
Gaël PORTAY
c73d37fc6f Revert "fu-tool: Save device state to @LOCALSTATEDIR@/lib/fwupd/state.json on actions"
This reverts commit 3143bad0f5.
2022-06-20 12:57:40 -04:00
Gaël PORTAY
97a627b54b Cache list of devices to cache directory 2022-06-20 12:57:40 -04:00
Gaël PORTAY
2cc5449ae8 trivial: Use bash-completion facilities to get arguments 2022-06-20 12:57:40 -04:00
Gaël PORTAY
d893b80bbc trivial: Fix missing bash-completion for firmware-read 2022-06-20 12:57:40 -04:00
Gaël PORTAY
c8987ab100 trivial: Allow mixing modifiers/parameters in bash-completion scripts 2022-06-20 12:57:40 -04:00
Gaël PORTAY
5bdbf0dd0a trivial: Add missing comments in bash-completion scripts
For the sake of consistency.
2022-06-20 12:57:40 -04:00
Gaël PORTAY
4b3352e2f5 trivial: Add bash-completion for device-id
The four commands `get-details`, `install`, `install-blob`, and
`firmware-plugin` use device-id as second command argument but the
fwupdtool bash completion script does not completed it yet.

This calls function `_show_device_ids` to add completion for device-id
if completion the second argument of the commands mention above.
2022-06-20 12:57:40 -04:00
Gaël PORTAY
b670404127 trivial: Fix fwupdtool bash-completion script
The commands `attach`, `detach`, `activate`, `verify-update`,
`reinstall`, and `get-updates` calls `_show_device_ids` but that
function is not defined in the fwduptool bash-completion script.

This defines the function `_show_device_ids` by reusing the function
of the name in the fwupdmgr bash-completion script.

Fixes:

	$ sudo fwupdtool attach
	                        ^-- tabulation
	bash: _show_device_ids: command not found
2022-06-20 12:57:40 -04:00
Gaël PORTAY
2454753cf7 trivial: progress: Fix documentation
This commit cf9ebdb703.
2022-06-20 12:00:40 -04:00
Daniil Lunev
38fb424246 Fix setting version for udev devices
Change-Id: I907bb3958b624ff5f887cbc192f54448354d9d5c
2022-06-17 07:03:58 +01:00
Richard Hughes
87c4163993 trivial: Fix typo when setting the parent status 2022-06-16 19:54:46 +01:00
Richard Hughes
1e31507e82 Allow front-end clients to read the Percentage property 2022-06-16 19:54:46 +01:00
Richard Hughes
b3800609b6 Ensure FuDevice->set_progress() always sets 4 steps 2022-06-16 19:54:46 +01:00
Richard Hughes
60eeb9bd73 Fix a progress regression when installing archives with fwupdtool
Fixes https://github.com/fwupd/fwupd/issues/4749
2022-06-16 19:54:46 +01:00
Mario Limonciello
bb2ea82473 trivial: validate packages exist before installing in helper script 2022-06-15 09:43:42 -05:00
Richard Hughes
362ee83e1b trivial: Fix progress warning if ->backend_device_added failed 2022-06-15 13:09:11 +01:00
Richard Hughes
700ea6cf0d Do not add 'unset' UDev vendor or model information 2022-06-15 13:09:11 +01:00
Richard Hughes
bf256a7ca7 Read the UDev vendor and model as a uint16_t 2022-06-15 13:09:11 +01:00
Norbert Kamiński
7e6b77e12c qubes/test/fwupdmgr: Update cabinets checksums and URLs
Signed-off-by: Norbert Kamiński <norbert.kaminski@3mdeb.com>
2022-06-14 22:20:30 +01:00
Norbert Kamiński
c81094f0ba qubes/src/heads: Update Heads versioning
Signed-off-by: Norbert Kamiński <norbert.kaminski@3mdeb.com>
2022-06-14 22:20:30 +01:00
Richard Hughes
cf9ebdb703 Add startup profiling functionality
Using `sudo FWUPD_PROFILE=10 ./src/fwupd --verbose` will print a
dump of startup times onto the console so that we can debug which
plugin is slowing down system startup. For example:

    ../src/fu-engine.c:5409:plugins-coldplug [108.55ms]:
        ../plugins/amt/fu-plugin-amt.c:437:amt [27.14ms]:
            :create-context [12.66ms]
            :get-version [8.44ms]
            :add-device [3.95ms]
2022-06-14 22:08:02 +01:00
Richard Hughes
7a5964435f Add startup profiling support to FuPlugin->init() 2022-06-14 22:08:02 +01:00
Richard Hughes
faa7871b08 Remove duplicate ->probe() calls to speed up startup by 150ms
Now incorporate is fixed to copy across the properties we need in the
superclass, we don't need to do the subclass ->probe().

Note, we still need to do the subclassed ->probe() when using
FU_UDEV_DEVICE_FLAG_VENDOR_FROM_PARENT or when looking at properties
on the parent device.

This also removes the spurious 'already set GType to FuVliUsbhubDevice,
ignoring FuVliUsbhubDevice' messages when running the daemon.
2022-06-14 21:01:57 +01:00
Richard Hughes
21e3ef4347 optionrom: Reorder plugins FuDevice->probe() to speed up daemon startup
There's no point scanning the baseclass again if we can quickly check
if the device is valid.
2022-06-14 21:01:57 +01:00
Richard Hughes
4655e028a6 Copy more properties when doing FuUdevDevice->incorporate
We're supposed to be copying any private data derived during ->probe()
so we can create a superclass with the same attributes.
2022-06-14 21:01:57 +01:00
Richard Hughes
db01004cd4 Copy the possible plugins when incorporating
I don't think this is required, but seems safer.
2022-06-14 21:01:57 +01:00
Richard Hughes
30aab6f564 Copy the instance ID strings when incorporating
Also, add a test.
2022-06-14 21:01:57 +01:00
Richard Hughes
599e67cd2c trivial: More efficiently incorporate metadata 2022-06-14 21:01:57 +01:00
Richard Hughes
8b3f7a1a52 trivial: Add some self tests for fwupd_device_incorporate()
This was based on a hunch that was proved wrong, but the tests still
seem useful anyway.
2022-06-14 21:01:57 +01:00
Richard Hughes
2203b3ce7b trivial: gi-docgenize some of the function comments 2022-06-14 14:36:52 -05:00
Richard Hughes
2dc6a7ef73 Remove fu_i2c_device_read_full()
Just use the version with the length specified.
2022-06-14 14:36:52 -05:00