Commit Graph

2726 Commits

Author SHA1 Message Date
Richard Hughes
fd399da71b tpm: Fix a critical warning when loading an empty TPM eventlog item 2022-02-09 14:20:55 +00:00
Richard Hughes
2b310fb368 dfu: Downgrade a trivial harmless warning to debug 2022-02-08 11:56:20 +00:00
Richard Hughes
915c4805f5 thunderbolt: Set the update timeout if required
I think this accidentally got inverted during the retimer split.
2022-02-07 14:25:58 +00:00
Richard Hughes
cf5d8db9a4 vli: Set the progress values for the MSP430 update 2022-02-07 14:21:01 +00:00
Kranthi Kuntala
97e6c1d7c2 [thunderbolt] remove the skip-restart flag for retimer
-this is indeed needed to reflect the updated version after system reboot

Signed-off-by: Kranthi Kuntala <kranthi.kuntala@intel.corp-partner.google.com>
Change-Id: Id4751d531528590cc93c08db0d0939a547f4d59f
2022-02-04 20:28:57 +00:00
Mario Limonciello
783e2e0448 Drop the AMD SME check for security attributes (Fixes: #4176)
This method does not indicate whether the kernel has enabled encryption.
That information is only visible from the kernel log at this time.

Continue to read the MSRs though, because if/when we get a method for the
kernel to export it we may use these as a basis of "support" but not a
indication of it being enabled.

encrypted:
```FuPluginMsr          SME/SEV check MSR: eax 01000f, ebx 016f
FuPluginMsr          PCI_MSR_AMD64_SYSCFG: 0f40000, sme_is_enabled=1
FuPluginMsr          PCI_MSR_AMD64_SEV: 00, sev_is_enabled=0
```

not_encrypted:
```
FuPluginMsr          SME/SEV check MSR: eax 01000f, ebx 016f
FuPluginMsr          PCI_MSR_AMD64_SYSCFG: 0f40000, sme_is_enabled=1
FuPluginMsr          PCI_MSR_AMD64_SEV: 00, sev_is_enabled=0
```
2022-02-04 10:41:47 -06:00
Denis Pynkin
cdd280b4d3 plugins/nordic-hid: extend the doc with tested HW 2022-02-04 13:46:59 +03:00
Mario Limonciello
59ef6ef4e2 trivial: synaptics-mst: use environment for quirk override location 2022-02-03 09:40:12 -06:00
Mario Limonciello
3f1dde7911 trivial: thunderbolt: use environment for overriding quirk location 2022-02-03 09:40:12 -06:00
Mario Limonciello
3e3bd334f4 trivial: use src directory for quirks for ata and nvme plugins
Fixes: #4244
2022-02-03 09:40:12 -06:00
Mario Limonciello
9de6adf41f trivial: msr: add more debugging data for register status 2022-02-01 15:58:39 -06:00
Richard Hughes
f3d71a18a5 redfish: Be more robust by retrying IPMI transactions
This fixes creating users when the BMC is otherwise busy.
2022-02-01 16:18:28 +00:00
Richard Hughes
fba2fd62f2 redfish: Add error codes not provided in ipmi_msgdefs.h 2022-02-01 16:18:28 +00:00
Richard Hughes
de874c7d8e redfish: Wait some time after creating the initial IPMI user
It would appear that in reality a delay is required for them to sync state.
2022-02-01 16:18:28 +00:00
Richard Hughes
76dcafee1f redfish: Do not use 'unspecified' for the unknown error 2022-02-01 16:18:28 +00:00
Michał Kopeć
ab06e034c3 plugins/flashrom: add quirk for NovaCustom NV4x
Add a quirk for NovaCustom NV4x devices.
These laptops are running coreboot and are updatable using flashrom.

The HwId GUID matches to both previous Insyde firmware and the current
Dasharo firmware. The Dasharo GUID matches to the devices running
Dasharo firmware. This way the device can be switched from Insyde
to Dasharo using `fwupdmgr switch-branch`.

Homepage: https://configurelaptop.eu/nv40-series/

Signed-off-by: Michał Kopeć <michal.kopec@3mdeb.com>
2022-02-01 14:15:45 +00:00
Richard Hughes
4b48b2ea27 trivial: Fix a warning in the latest clang release 2022-01-31 14:36:38 +00:00
Dylan Van Assche
b5077745a7 modem-manager: use version format from metadata
Some modems use a plain string as version while others use a
standardized version format. If such a format is provided by
the metadata, set it.
2022-01-30 20:01:52 +00:00
xtcui
7dc24a9f20 analogix: Do not hardcode the device vendor 2022-01-27 06:25:13 +00:00
xtcui
ed120c05e7 analogix: Added 3 new supported devices 2022-01-27 06:25:13 +00:00
Crag Wang
36fd4117c6 dell-dock: fix a segfault if device isn't added yet 2022-01-23 17:53:51 +00:00
Norbert Kamiński
7fdf7c60ee fu-uefi-common.h: Fix efivar compatibility with FreeBSD
Signed-off-by: Norbert Kamiński <norbert.kaminski@3mdeb.com>
2022-01-21 16:24:37 +00:00
Mario Limonciello
fa8bfc7f4a msr: make tsme security attribute match kernel doc more closely
The kernel documentation for AMD memory encryption includes information
on both SME and SEV, but they are separate attributes. Read the attributes
separately.

Link: https://www.kernel.org/doc/html/v5.16/x86/amd-memory-encryption.html
2022-01-20 06:52:51 -06:00
Richard Hughes
7657bc365f trivial: Change some problematic language that crept in 2022-01-20 08:54:31 +00:00
Denis Pynkin
e08ead31f5 plugins/nordic-hid: fix the bootloader type detection
The initial name of the varianle has been changed upon review in
[nrf_desktop DFU PR](https://github.com/nrfconnect/sdk-nrf/pull/6343)

This commit align the naming with NRF desktop upstream and fix testing
images URLs for device testing.
2022-01-20 03:16:47 +03:00
Richard Hughes
3917714dd1 redfish: Change an expired password when required 2022-01-19 21:19:01 +00:00
Richard Hughes
0264c29bda modem-manager: Only try to get the branch if there exists an AT port
Fixes https://github.com/fwupd/fwupd/issues/4190
2022-01-19 20:06:25 +00:00
Richard Hughes
4329ddbd76 modem-manager: Fix a segfault on startup for some MBIM-QDU devices
Works around https://github.com/fwupd/fwupd/issues/4190 although we
still need to find the root cause.
2022-01-19 13:46:05 +00:00
Richard Hughes
0cf11b9dc9 trivial: Do not match the legacy bootloader VID/PID
This is the ID assigned to STMicroelectronics... more specifically for
a mini LED display. It also seems to be used by other vendors who also
did not change the default from the devkit, e.g. the Vaydeer Multimedia
Console.

Fixes https://github.com/fwupd/fwupd/issues/4180
2022-01-17 15:41:04 +00:00
Richard Hughes
e74d38bfd3 Fix compiling with new versions of efivar
Fixes https://github.com/fwupd/fwupd/issues/4181
2022-01-17 15:27:05 +00:00
Mario Limonciello
64e7ea25b1 Fix the logic for removable fallback path in uefi-capsule
The logic was built on the presumption of Ubuntu core which doesn't
have /etc/os-release.  Since other distributions do have /etc/os-release
adjust the logic to instead build the path explicitly.
2022-01-15 07:09:04 -06:00
Richard Hughes
d7b682430e thunderbolt: Set the retimer NVM version 2022-01-14 18:04:13 +00:00
Richard Hughes
045bc383a6 thunderbolt: Fix a typo in the USB4 port online 2022-01-14 18:04:13 +00:00
Dylan Van Assche
e3b62e643b modem-manager: uninhibit modem after upgrade
When fastboot is used, the modem is rediscovered through udev
after upgrading. However, the modem-manager plugin did not mark
the modem as unhibited with ModemManager. This resulted into
ModemManager not exposing the modem without restarting ModemManager or
rebooting the device.

Mark the modem as uninhibited and do not take ownership over the
plugin data as this caused segfaults.
2022-01-13 20:30:09 +00:00
Richard Hughes
73f6767d87 trivial: Show why more devices are not marked as updatable 2022-01-13 16:04:31 +00:00
Richard Hughes
ca43733a8c Show why devices are not marked as updatable
At the moment a lot of the failures are only visible when running the
daemon in verbose mode, and the inhibit functionalit provides us a way
to unset FWUPD_DEVICE_FLAG_UPDATABLE from multiple places, as well as
setting the update error for the user to see why.
2022-01-13 12:40:56 +00:00
Richard Hughes
e03b8c46ed thunderbolt: Split the retimer and controller into two different objects
Although they do a lot of the same things, trying to deal with both
kinds of device in the same GObject type was making it very hard to
understand and maintain.

Split out two GObjects that both derive from FuThunderboltDevice.
2022-01-11 20:15:44 +00:00
Richard Hughes
d78ad32f24 trivial: Do not abort with a critical warning for a weird TPM event log
There is one eventlog item per-PCR with zero size.

Fixes https://bugzilla.redhat.com/show_bug.cgi?id=2038167
2022-01-11 20:14:21 +00:00
Richard Hughes
2734f0ab77 redfish: Do not autoload ipmi-si to avoid warning on non-server hardware
This leads to reports of:

    systemd-modules-load[1710]: Failed to insert 'ipmi_si': No such device
    systemd-modules-load.service: Main process exited, code=exited, status=1/FAILURE
2022-01-10 14:06:34 +00:00
Richard Hughes
40dad22388 cros-ec: Add progress completion when writing blocks
Also, simplify the helper that's passed to the retry function.
2022-01-07 07:24:08 +00:00
Richard Hughes
2f8e7dc05c logitech-hidpp: Always hardcode the vendor for FuLogitechHidPpDevice 2022-01-06 19:23:58 +00:00
Richard Hughes
25b1813069 trivial: Fix up some clang-format issues that snuck in recently 2022-01-06 17:04:34 +00:00
Richard Hughes
f885ab6d2a Allow patching firmware files at known offsets
This allows us to replace the 'dfu-tool replace' with a much more
controlled 'fwupdtool firmware-patch' command that patches at a set of
specific offsets.

Drop in the new functionality into the existing firmware ->write()
vfuncs so that the image headers, footers and/or checksums are correct.
2022-01-05 09:51:45 +00:00
Richard Hughes
8df102b7c0 Add fu_usb_device_add_interface() for plugins to use
It's a common action for plugins to call FuUsbDevice->open() then claim
interfaces, and then release them just before FuUsbDevice->close().

It's also something a lot of plugins get wrong, so provide common code
to handle it correctly in one place.
2022-01-04 22:05:37 +00:00
Mario Limonciello
f57a6637c9 trivial: fix man page sections
They're marked in the man page as section 8 but installed into 1.
They should be installed into 1 as they're not admin tools.
2022-01-04 14:17:43 -06:00
Richard Hughes
815a5a8a93 logitech-bulkcontroller: Assign the update interface correctly 2022-01-04 18:13:59 +00:00
Richard Hughes
c725e42e34 trivial: Fix various const issues 2022-01-03 22:46:23 +00:00
Richard Hughes
e17a107ce1 trivial: Cast the g_signal_connect() object to allow static analysis
This is useful when using https://gitlab.freedesktop.org/tartan/tartan
2022-01-03 22:46:23 +00:00
Richard Hughes
7c4eb1bf92 trivial: Fix an impossible-to-hit scan-build warning 2022-01-03 22:46:23 +00:00
Richard Hughes
2e99055d1e trivial: Add some more annotations for language bindings 2022-01-03 22:46:23 +00:00