Mario Limonciello
8c7b98da56
synapticsmst: Iterate all nodes rather than hardcoding to 3
2017-01-26 17:06:22 -06:00
Richard Hughes
7ed92084ac
trivial: Fix make distcheck
2017-01-25 09:54:00 +00:00
Mario Limonciello
493b63f6cc
trivial: shuffle fu-dell-flash into fu-dell-common
...
This will make sharing common functions from the dell plugin with
others easier
2017-01-23 11:27:03 -06:00
Mario Limonciello
ceb0ea9582
trivial: synaptics: don't advertise device remote control out to the plugin or tool
2017-01-20 16:26:56 -06:00
Mario Limonciello
eebf9f9c7d
synapticsmst: fix cascade support in the plugin
...
There was a lot of confusion about when remote control was turned
on or off leading to dsyfunctional cascade support.
This has been confirmed to work for querying and flashing both
VMM3320s in a Rugged Latitude 5414 + dock.
2017-01-20 16:22:31 -06:00
Richard Hughes
67a756c93f
synapticsmst: Refactor away the global state
...
The synapticsmst-common.c file had some global state so that cascade devices
could use the device fd. This made the control flow error prone, and it meant
that the fd could be leaked trivially on any error path.
Moving the fd ownership to the device is the logical place for the control, and
means we can create "connections" to access the main device and the cascade
devices.
This fixes the warnings detected by Coverity.
2017-01-19 13:41:04 +00:00
Richard Hughes
fffa21639b
trivial: unindent a code block
2017-01-19 08:51:16 +00:00
Richard Hughes
d99282f2ca
trivial: Fix an anti-pattern when returning error strings
2017-01-19 08:43:06 +00:00
Mario Limonciello
836ff015b3
trivial: synaptics: on new systems show unknown rather than failing
2017-01-17 16:08:04 -06:00
Mario Limonciello
7d5003e643
trivial: synaptics: don't fail on systems with less DP aux nodes
2017-01-17 13:23:46 -06:00
Mario Limonciello
548c6901c4
trivial: synaptics: add missing ID string for Rugged platforms
2017-01-17 12:13:59 -06:00
Mario Limonciello
0ed79d5455
trivial: synaptics: log invalid board IDs
2017-01-17 12:02:15 -06:00
Richard Hughes
31fd185ecf
trivial: Fix make distcheck
2017-01-17 15:44:52 +00:00
Richard Hughes
8dafc604e0
trivial: Fix up the typedef'd enum style
2017-01-17 14:15:00 +00:00
Richard Hughes
2153cd0f89
trivial: Use guint8 rather than guchar
...
Although it's probably the same, this matches the other plugins.
2017-01-17 14:10:12 +00:00
Richard Hughes
26aade02d2
trivial: Don't use caps in variable names
2017-01-17 13:21:14 +00:00
Pei-Chen Huang
9225270421
trivial: fix synaptics device scan cascade function
2017-01-17 06:23:45 -06:00
Richard Hughes
3d8d48c896
trivial: Remove boilerplate gtk-doc from plugin
2017-01-17 11:17:29 +00:00
Richard Hughes
0c91cb0a94
trivial: Don't output the error domain twice
2017-01-17 11:17:29 +00:00
Richard Hughes
ae040f77b8
trivial: Fix some indenting in synapticsmst
2017-01-17 11:17:29 +00:00
Richard Hughes
94ce14f317
trivial: Use rc for return codes
...
The variable ret is normally reserved for boolean values.
2017-01-17 08:58:40 +00:00
Richard Hughes
1967c6c9ac
trivial: Fix up some missing return value assignments
...
Spotted by coverity.
2017-01-17 08:54:34 +00:00
Richard Hughes
db0a3cb37f
trivial: Fix up some indent issues spotted by coverity
2017-01-17 08:54:03 +00:00
Mario Limonciello
f53e4a2d4b
trivial: synapticsmst: only enable plugin if kernel support is present
2017-01-16 15:37:11 -06:00
Mario Limonciello
8eaf6dbcd6
trivial: synapticsmst: don't proceed if device open fails
2017-01-16 15:14:47 -06:00
Pei-Chen Huang
abac1640a5
synapticsmst: Add cascade support
2017-01-16 11:23:43 -06:00
Mario Limonciello
24afb470f2
Introduce plugin for Synaptics MST hubs
2017-01-16 11:23:43 -06:00
