Commit Graph

6886 Commits

Author SHA1 Message Date
Richard Hughes
a11fefff35 redfish: Don't add the backup BMC device as it shares the same GUIDs
This fixes the problem when the UEFI update depends on a specific BMC
version -- including the backup BMC device means we checking that both
the primary and the backup were above a specific version.

I don't think it's ever useful to show the backup BMC device, so just
don't include it as an enumerated device.

Fixes https://github.com/fwupd/fwupd/issues/4404
2022-03-18 11:03:14 +00:00
Richard Hughes
41bc319331 trivial: Fix -Wundef warning when compiling without libcbor 2022-03-18 10:38:12 +00:00
Richard Hughes
e9454e022f logitech-bulkcontroller: Mark as signed payload 2022-03-17 20:46:43 +00:00
Richard Hughes
4074150d21 trivial: Convert the FreeBSD cbor requirement to a LIB depends 2022-03-17 13:19:43 +00:00
Richard Hughes
b9774c644d Fix the 'Device has been removed' warning incorrectly seen on devices
Uninhibit the returning device if no firmware update has been performed.
2022-03-17 10:06:37 +00:00
Sean Rhodes
d8b6f5f0b3
plugin/flashrom: Change the default format from triplet to pair (#4395)
Flashrom is primarily used with coreboot, which has a pair version number
currently 4.16. As such, chance the default to pair so that fewer quirks
are required.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
2022-03-17 07:58:25 +00:00
Tatsunosuke Tobita
a61f4ec1af plugins/wacom-raw: Add several Lenovo products
wacom-raw is required to support several Lenovo products.
Therefore, some items have been added to "wacom-raw.quirk".

Signed-off-by Tatsunosuke Tobita <tatsunosuke.tobita@wacommfg.corp-patner.google.com>
2022-03-16 18:34:22 -05:00
Richard Hughes
71d111a21f gpio: Return the correct error when there is no device to open 2022-03-16 12:08:32 +00:00
Richard Hughes
013475fc49 trivial: Actually open the GPIO device before querying the chipinfo
Set the GPIO open flags as without the fd is not opened.

Fixes https://github.com/fwupd/fwupd/issues/4388
2022-03-16 12:08:32 +00:00
Sean Rhodes
57862d844e
plugin/flashrom: Add GUIDs for StarLite's (#4392)
* HwId for StarLite Mk IV
* coreboot GUID for StarLite Mk IV
* HwId for StarLite Mk II (under coreboot)
* coreboot GUID for StarLite Mk II

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
2022-03-16 10:18:20 +00:00
Richard Hughes
da37d93eb0 trivial: Remove some long dead docs about fu_plugin_device_add_delay() 2022-03-16 09:18:29 +00:00
Richard Hughes
8b62bf6b64 Set the context in the right place more often 2022-03-16 09:18:29 +00:00
Richard Hughes
945002f7a3 Fix build for MacOS
This is more for curiosity than anything else.
2022-03-15 14:37:28 +00:00
Richard Hughes
92515d193a Add coSWID and uSWID parsers to libfwupdplugin
These parse the structures as defined in:

 * https://datatracker.ietf.org/doc/draft-ietf-sacm-coswid/
 * https://github.com/hughsie/python-uswid
2022-03-15 14:37:02 +00:00
Richard Hughes
6b5d933e99 Do not show unconnected or unreachable devices in the client tools
Fixes https://github.com/fwupd/fwupd/issues/4378
2022-03-15 14:08:17 +00:00
Richard Hughes
e8f0d76da7 Do not leak child processes when cancelling
See https://github.com/fwupd/fwupd/pull/4372
2022-03-15 14:01:45 +00:00
Richard Hughes
b4e88bae49 trivial: Move the UNREACHABLE inhibit to common code 2022-03-15 11:29:00 +00:00
Richard Hughes
75ba49ebf0 ccgx: Add the correct instance IDs to the HPI device
A simple copy+paste typo -- these need to be actual IDs for firmware
matching rather than only for quirks.

Fixes https://github.com/fwupd/fwupd/issues/4382
2022-03-15 09:50:41 +00:00
Mario Limonciello
d6961bfb0d trivial: dell-dock: set package version payload as unsigned
This payload is just 24 bytes with no signature.  It's used as a manifest
to verify that all firmware is installed.
2022-03-14 14:46:37 +00:00
Richard Hughes
a6aef01e49 mtd: Do not try to probe recovery read-only partitions
Ignore devices without a 'flags' file.
2022-03-11 16:51:45 +00:00
Richard Hughes
a239dc8ab8 mtd: Allow the metadata to set the signed payload flag 2022-03-11 16:51:45 +00:00
Richard Hughes
53f75b6ab9 trivial: Fix critical warning when vendor is unset for a SCSI device 2022-03-11 15:25:26 +00:00
Richard Hughes
d3cba9a679 Add fwupd_client_disconnect() for future usage 2022-03-11 13:28:00 +00:00
Richard Hughes
4080ef637e trivial: Do not show SATA drives as SCSI devices
This fixes a regression in c4ca026294
which meant the 'vendor' sysfs attribute wasn't being stripped before
being used as the vendor ID.
2022-03-11 12:33:23 +00:00
Richard Hughes
dd183e9b59 logitech-hidpp: Add support for M550, M650 and K650 2022-03-10 12:57:45 +00:00
Crag Wang
a2b46e15cf Add daemon configuration 'OnlyTrusted' to D-Bus properties 2022-03-10 09:46:54 +00:00
Daniel Campello
61226b49f3 fwupdplugin-self-test: fix spawn tests for qemu
Wrap the spawned script with an explicit call to the /bin/sh
interpreter needed when running tests in a cross compiled enviroment.

Also increase the timeout for the spawned script to execute to give
enough time for the print to happen in the much slower virtualized
environment.

Change-Id: I71ed377e1bc8db4be4c522cdb9562c1662df7266
2022-03-09 17:32:40 -07:00
Richard Hughes
91512925a0 Check for os-release on FWUPD_SYSCONFDIR
Change-Id: I391eabfb1ef6eadbad100273445794172b2cb1fd

Fixes https://github.com/fwupd/fwupd/issues/4366

Based on a patch by Daniel Campello <campello@chromium.org>, many thanks.
2022-03-09 08:10:18 -07:00
Richard Hughes
6fdae41ae0 flashrom: Simplify the plugin to remove the indirection
For a while we flirted with the idea of updating non-internal
libflashrom-derived devices but the impedance mismatch was just too
great.

We removed the extra unused subclasses of FuFlashromDevice, but never
removed the indirection we added for the writing.
Remove the unused code now that we agree on the longer term plan.
2022-03-09 08:13:13 +00:00
Richard Hughes
4ce9972ce5 trivial: Don't leak the string even on critical failure
Not totally sure this is worthwhile, but it triggered a failure in the
RHEL tests we do - and it's less work to fix it than argue.
2022-03-08 16:01:16 +00:00
Richard Hughes
faac369d3a uefi-dbx: No not allow the DBX update for specific motherboards
This list of hardware is provided by Microsoft.
2022-03-07 22:12:06 +00:00
Sean Rhodes
f98acc89b3
plugin/flashrom: Add MaxSize quirk for Lite II and III (#4362)
Add FirmwareSizeMax = 0x800000 for StarLite Mk II and Mk III to allow
switching from AMI to coreboot firmware.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
2022-03-07 14:26:36 +00:00
Richard Hughes
2012a42a1e Do not use /var/run for the socket
The FHS says to use /run everywhere now, so use that to avoid confusion.
See https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch05s13.html
2022-03-07 13:24:58 +00:00
Richard Hughes
14cc2e7ee4 Do not hardcode the libexecdir to /usr/libexec
Fixes https://github.com/fwupd/fwupd/issues/4360
2022-03-07 13:24:58 +00:00
Richard Hughes
4153701d8f usi-dock: Mark as signed payload 2022-03-07 12:40:04 +00:00
Richard Hughes
66cb93c4e2 trivial: Make clear sizes are in hex 2022-03-07 12:38:33 +00:00
Richard Hughes
41e2f93fc7 trivial: Add signed flag for Samsung NVMe devices 2022-03-07 10:45:17 +00:00
Richard Hughes
777103f93a goodix-moc: Mark as signed payload 2022-03-06 12:06:21 +00:00
Richard Hughes
908ccf78ce dfu: Mark various Poly products as signed and unsigned 2022-03-04 23:11:05 +00:00
Richard Hughes
5f4e962d02 cros-ec: Mark as signed payload 2022-03-04 19:21:42 +00:00
Richard Hughes
7043826336 trivial: post branch version bump 2022-03-04 10:03:46 +00:00
Richard Hughes
94d572375f trivial: Clarify the unit for the device remove delay 2022-03-03 11:26:17 +00:00
Richard Hughes
c4ca026294 Allow devices to build instance IDs more easily
Provide a device instance builder that allows plugins to easily
create multiple instance IDs based on parent attributes.

Also fix a lot of the instance ID orders, so that we add more generic
IDs first, and more specific IDs after.
2022-03-03 09:13:29 +00:00
Richard Hughes
de14bc6f0e vli: Do not probe devices with the firmware reference VID and PID
But, leave the products with the VIA VID, but a non-default PID.

Fixes https://github.com/fwupd/fwupd/issues/4352
2022-03-02 19:19:48 +00:00
Richard Hughes
d86b8bc794 Show devices that are updatable and payload signing is still unknown
But, ignore devices like UEFI, NVMe and Redfish as this is specified in
the firmware metadata.
2022-03-02 15:33:42 +00:00
Richard Hughes
1a1fd1b99c vli: Mark the MSP430 as unsigned-payload 2022-03-02 15:33:42 +00:00
Richard Hughes
2085a2a1c3 modem-manager: Detect presence of modem-power driver
Quectel EG25-G modem in the Pine64 PinePhone and PinePhone Pro can be
booted with the eg25-manager (user space) or modem-power (kernel space).

We only support the eg25-manager for upgrading these modems.

Based on a patch by Dylan Van Assche <me@dylanvanassche.be>, thanks.
2022-03-02 13:36:19 +00:00
Richard Hughes
409f2be940 synaptics-cxaudio: Use a more standard instance ID for the chip 2022-03-01 12:52:12 +00:00
Richard Hughes
281eb0227a intel-spi: Use a more standard instance ID for the chipset 2022-03-01 12:52:12 +00:00
Richard Hughes
f9f3d6379e intel-spi: Use a more standard instance ID for the IFD 2022-03-01 12:52:12 +00:00