Philip Withnall
3d626cec07
plugins/amt: Move UUID_LE initialisation into function scope
...
This should hopefully fix the error:
../../checkout/fwupd/plugins/amt/fu-plugin-amt.c:238:1: error: initializer element is not constant
uuid_le MEI_IAMTHIF = UUID_LE(0x12f80028, 0xb4b7, 0x4b2d, \
^
Signed-off-by: Philip Withnall <withnall@endlessm.com>
2017-08-16 12:53:28 +01:00
Philip Withnall
1f68512f18
Revert "plugins/amt: Fix compilation on Jessie machine; UUID_LE is not const"
...
This reverts commit 1a5c7f6fe5
.
The warning is obviously complaining that the value cannot be evaluated
at compile time, rather than that it’s being assigned to a const storage
location.
2017-08-16 12:53:28 +01:00
Philip Withnall
1a5c7f6fe5
plugins/amt: Fix compilation on Jessie machine; UUID_LE is not const
...
Unfortunately it seems that the definition of UUID_LE is not const (or
not evaluatable as const by the compiler) on a Debian Jessie machine,
which causes compilation to fail with:
../../checkout/fwupd/plugins/amt/fu-plugin-amt.c:238:1: error: initializer element is not constant
const uuid_le MEI_IAMTHIF = UUID_LE(0x12f80028, 0xb4b7, 0x4b2d, \
^
Fix that by dropping the const. Sadness.
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
2017-08-16 07:24:25 +01:00
Philip Withnall
7ca5a04105
plugins/unifying: Fix minor const-correctness issue
...
Signed-off-by: Philip Withnall <philip@tecnocode.co.uk>
2017-08-16 07:24:25 +01:00
Richard Hughes
94675b458b
unifying: Use the new bootloader PIDs for pico receivers
...
Fixes: https://github.com/hughsie/fwupd/issues/169
2017-08-14 11:14:14 +01:00
Richard Hughes
a8909ec45b
trivial: Remove the FuDevice plugin symlinks
2017-08-14 10:29:55 +01:00
Richard Hughes
94f939aa4d
trivial: Move the archive decompression to common code
2017-08-09 10:23:23 +01:00
Richard Hughes
d7704d4cc2
Allow plugins to get DMI data from the hardware in a safe way
...
The returned strings are converted to ASCII and have leading and trailing
spaces removed.
2017-08-09 10:19:13 +01:00
Richard Hughes
e7472a22cc
Use a static library to avoid symlinking files for the tests
2017-08-09 10:19:13 +01:00
Chris Lee
f519834bb9
Make flashing ebitdo devices actually work
...
When my SNES30 controller was in bootloader mode, it wouldn't update,
and when it was in controller mode, it tried and failed. Now, it prints
out the instructions on how to reset the device if it's in controller
mode, and if it's in bootloader mode, it successfully installs the
firmware update from the .DAT file.
2017-08-02 06:43:09 +01:00
Richard Hughes
260e970297
Rename the thunderbolt plugin to tbtfwu
2017-07-30 17:39:25 +01:00
Richard Hughes
70d13a5a58
unifying: Make sure the percentage completion goes from 0% to 100%
...
Pre-filter the pending LuDeviceBootloaderRequest's after they are parsed so
that we know exactly how many packets need to be sent to the hardware.
As shown in https://github.com/hughsie/fwupd/issues/155 , people get worried
if the progress bar finishes before 100% as they'll wonder if all the writing
completed successfully.
2017-07-24 12:02:14 +01:00
Richard Hughes
b31791a11f
trivial: Allow setting the unifying bootloader address for self tests
2017-07-24 11:54:31 +01:00
Richard Hughes
da928d1da7
unifying: Fix trivial error handler warning
2017-07-24 11:46:54 +01:00
Richard Hughes
f592b06722
dell: Fix the last of the memory leaks in the self tests
...
Fixes: https://github.com/hughsie/fwupd/issues/158
2017-07-24 10:55:03 +01:00
Richard Hughes
4bfcae2921
trivial: Fix a tiny leak in the Dell plugin
2017-07-24 10:51:29 +01:00
Mario Limonciello
5f6a574fd7
fix some more memory leaks in dell plugin ( #158 )
2017-07-21 13:17:47 -05:00
Richard Hughes
3cca1c65c2
trivial: Remove or downgrade some superfluous warnings
...
Fixes bugs like https://github.com/hughsie/fwupd/issues/159
2017-07-21 13:38:27 +01:00
Richard Hughes
061ad8c5e8
trivial: Make fu_dell_detect_dock() slightly more NULL-deref safe
2017-07-19 09:14:56 +01:00
Mario Limonciello
11ca8122c3
Revert "trivial: fix some more memory leaks in dell plugin ( #158 )"
...
This reverts commit 49aba8cd87
.
That was prematurely committed, my apologies.
2017-07-18 16:00:03 -05:00
Mario Limonciello
32899e5ff7
dell: use plugin hash table instead
2017-07-18 15:53:38 -05:00
Mario Limonciello
49aba8cd87
trivial: fix some more memory leaks in dell plugin ( #158 )
2017-07-18 15:53:38 -05:00
Mario Limonciello
d817c53697
Correct a memory leak in Dell plugin ( Fixes #158 )
2017-07-18 10:35:21 -05:00
Mario Limonciello
c29b398ad0
trivial: fix various spelling errors
2017-07-17 13:07:05 -05:00
Mario Limonciello
e68b118044
uefi: test for kernel support during coldplug
...
The kernel offers two interfaces for manipulation of EFI variables.
Make sure that at least one of these is available.
If another interface is added (and supported by efivar) then this
list will need to be appended as well.
This was raised as a potential problem in #100 .
2017-07-10 14:11:22 -05:00
Mario Limonciello
c7e5322454
dell, uefi: Display all errors recorded by efi_error tracing, not just the first one
2017-07-10 14:11:10 -05:00
Richard Hughes
c633edc773
unifying: Don't log a warning when an unknown report is parsed
...
Fixes: https://github.com/hughsie/fwupd/issues/151
2017-07-07 13:42:45 +01:00
Mario Limonciello
8cb067d528
trivial: uefi: whitespace
2017-07-06 12:39:33 -05:00
Mario Limonciello
f043f1f94b
uefi: record boot variables to system log during updates ( #152 )
...
This doesn't strictly resolve the encountered issue, but
it will aide in debugging these types of issues in the future.
2017-07-06 12:37:10 -05:00
Richard Hughes
79acb58c7e
uefi: Fix crash when the product name is NULL
...
...bad things happen when you try to free a const char...
2017-07-06 18:27:01 +01:00
Mario Limonciello
c1a4bd469d
uefi,dell: make error messages from installing capsules useful
...
Before:
$ fwupdmgr install XPS_test.cab
Retrying as an offline update...
Scheduling… UEFI firmware update failed: -1
After:
$ fwupdmgr install XPS_test.cab
Retrying as an offline update...
Scheduling… UEFI firmware update failed: libfwup.c:733 get_paths(): could not find shim or fwup on ESP: No such file or directory
2017-07-06 11:38:33 -05:00
Mario Limonciello
be3a994922
Display UEFI firmware type
...
This will be more important as devices include more than
one entry in the ESRT.
2017-07-05 17:16:18 -05:00
Richard Hughes
822e134e94
unifying: Split up the HID++2.0 and HID++1.0 functionality
2017-07-04 13:19:09 +01:00
Richard Hughes
2a247e85e3
unifying: Allow flashing in bootloader modes
2017-07-03 20:17:50 +01:00
Richard Hughes
07bdf87b86
trivial: Add defines for the 'very-long' register read/write
2017-07-03 20:17:43 +01:00
Richard Hughes
b1af7496b1
unifying: Show the hardware version when the hardware provides this
2017-06-28 14:19:11 +01:00
Richard Hughes
55e6d9a74f
unifying: Only add the feature Root on HID++2.0 devices
2017-06-28 14:18:56 +01:00
Richard Hughes
42b6439892
unifying: Switch to a floating point HID++ version
2017-06-28 14:17:30 +01:00
Richard Hughes
2c1bd0236c
unifying: Only call HID++2.0 features on version 2+ devices
...
Also, ignore HID++1.0 replies from HID++2.0 devices and use the correct
function ID for getDfuStatus to avoid an error.
2017-06-28 12:10:02 +01:00
Richard Hughes
e97c5eb013
unifying: Manually set the HID++ version for runtime devices
2017-06-28 12:09:51 +01:00
Richard Hughes
653119fef8
unifying: Use a longer timeout for some operations
2017-06-28 12:09:51 +01:00
Richard Hughes
22dc937184
unifying: Use __attribute__((packed)) for structs sent to the hardware
2017-06-28 12:09:51 +01:00
Richard Hughes
f21cda4fed
unifying: Clear the feature map when a device is reprobed
2017-06-28 12:09:51 +01:00
Richard Hughes
695d01ed93
unifying: Keep the devices open, closing in finalize
2017-06-28 12:09:51 +01:00
Richard Hughes
c3b5b24287
unifying: Fix a confusing debug message
2017-06-28 12:05:32 +01:00
Richard Hughes
ae15bc2649
unifying: Filter by SwId when making HID++2.0 requests
...
Using the default value of '0' is what the kernel is using (related, libratbag
is using 0x08) and makes hotplug unreliable.
2017-06-28 12:05:32 +01:00
Richard Hughes
668f91419d
unifying: Allow large HID++ version numbers
...
Apparently, '4.3' is a perfectly valid version number.
2017-06-28 12:05:32 +01:00
Richard Hughes
f1399580b5
unifying: Do not allow closing a non-open device
2017-06-28 12:05:32 +01:00
Richard Hughes
38451999ff
unifying: Actually enforce the device_id checks
2017-06-28 12:05:32 +01:00
Richard Hughes
8884676c5d
unifying: Ping before trying to get the feature indexes
...
This reduces log spew for disconnected-but-paired devices.
2017-06-28 12:05:32 +01:00