Commit Graph

7756 Commits

Author SHA1 Message Date
Denis Pynkin
5b1d66b671 trivial: fix URLs for SteelSeries Aerox3 device test
Some of URLs disappeared. Marked all versions from the
commit as persistent on LVFS to avoid CABs loss.

Signed-off-by: Denis Pynkin <denis.pynkin@collabora.com>
2022-07-19 00:59:49 +03:00
Richard Hughes
62fc515714 Allow loading in emulated host profiles for debugging
This allows us to load sets of different host security attributes
for testing the various front end tools we have now. e.g.

    sudo FWUPD_HOST_EMULATE=thinkpad-p1-iommu.json.gz fwupd

or, using a non-compressed absolute path:

    sudo FWUPD_HOST_EMULATE=/tmp/test/thinkpad-p1-iommu.json fwupd

Data can be created with `./contrib/generate-emulation.py file.json`
and then can be manually modified if required. Running the script on
a file that already exists will just strip out any unneeded data, as
well as piping content into it using stdin.

As a precaution, the org.fwupd.hsi.HostEmulation attribute is added
so we do not ask the user to upload the HSI report. It also allows
the LVFS to ignore any HSI reports with this attribute for clients
that upload HSI reports regardless.

See https://github.com/fwupd/fwupd/discussions/4832
2022-07-18 16:27:59 +01:00
Richard Hughes
de15afe466 trivial: Export all the JSON data the daemon sent
The FWUPD_DEVICE_FLAG_TRUSTED flag is used by the daemon, but if the
information is being set on the GVariant then it's not required to
filter it client-side.
2022-07-18 16:27:59 +01:00
Richard Hughes
7566e56fb5 Add fwupd_device_from_json() for future use 2022-07-18 16:27:59 +01:00
Richard Hughes
6adc60b5ba Ensure the container checksum has always been added before install 2022-07-18 16:12:43 +01:00
Richard Hughes
3487eb223b trivial: Add the container checksums when getting file details
This makes it easier to debug, as this shows what the checksum would be
stored in the history database on successful update.

We're already generating them, and so it's really just being helpful.
2022-07-18 16:12:43 +01:00
Richard Hughes
fdc5131dca Only validate source artifacts at cabinet load time
The LVFS was being over-eager, and setting 'binary' for both -- but
for new firmware it's important to specify the correct thing.
2022-07-18 16:12:43 +01:00
Richard Hughes
62a62f8f0f trivial: Clarify the FwupdRelease::checksum is for the container
In one place we were accidentally setting the contents checksum,
because the LVFS was setting the artifact type of 'binary' for metainfo
export -- which was never going to match on the LVFS.
2022-07-18 16:12:43 +01:00
Richard Hughes
19491c02b7 trivial: Save the release ID in the history database
This was supposed to reduce our dependance on unreliable checksums, but
we were not actually storing it and so it was never being matched.
2022-07-18 16:12:43 +01:00
Richard Hughes
93ba530d07 trivial: Allow getting HSI events when there are no device 2022-07-16 21:43:06 +01:00
Richard Hughes
9b9799f9c6 Use the correct protocol member when converting to JSON 2022-07-16 21:43:01 +01:00
Richard Hughes
0f2298095d trivial: Simplify the engine FuProgress setup 2022-07-16 21:42:23 +01:00
Richard Hughes
4720bb90bb trivial: Do not print the header when using 'fwupdtool security'
This matches the behaviour of fwupdmgr.
2022-07-16 21:42:18 +01:00
Richard Hughes
a5749f4d23 Set the HSI levels in a central place
This means we don't need to worry about changing multiple
implementations if the HSI levels change for a specific ID.

It also means we can fake HSI results in the future without having
to also store the 'correct' level in the input file.
2022-07-15 20:21:22 +01:00
Sean Rhodes
f1aabcf6f7
plugins/intel-spi: (nit) Change APL from pch to ich (#4833)
APL doesn't have a PCH so change it to ich. This change make no
difference, and is just for correctness.

Signed-off-by: Sean Rhodes <sean@starlabs.systems>
2022-07-15 07:27:14 +00:00
Mario Limonciello
611cf51fc8 trivial: lower modem manager probing verbosity in one other place
Fixes: 030a0d51c ("trivial: quiet the modem manager error about unable to probe")
2022-07-14 12:59:53 -05:00
Richard Hughes
a5929cee29 uefi-pk: Use the correct flag when added to the blocklist 2022-07-14 16:05:34 +01:00
Richard Hughes
8e7ad1b188 msr: Fix fwupdmgr security when the plugin is added to the blocklist 2022-07-14 16:05:34 +01:00
Richard Hughes
777b8fed46 pci-mei: Fix fwupdmgr security when the plugin is added to the blocklist 2022-07-14 16:05:34 +01:00
Richard Hughes
58171d46da pci-bcr: Fix fwupdmgr security when the plugin is added to the blocklist 2022-07-14 16:05:34 +01:00
Richard Hughes
7b1204bce0 trivial: Fix outputting the new security attr flags to JSON 2022-07-14 15:43:19 +01:00
Richard Hughes
01304a5fea Do not use MISSING when the iommu was just not found 2022-07-14 15:12:28 +01:00
Richard Hughes
dc91444b46 trivial: Export fu_security_attrs_get_by_appstream_id() for future use 2022-07-14 14:49:00 +01:00
Richard Hughes
26e5ecb567 trivial: Add fwupd_security_attr_remove_flag() for future use 2022-07-14 14:48:51 +01:00
Richard Hughes
0c51630991 Check firmware magic in a more standard way
Some parsers are ignoring the magic when using _FLAG_IGNORE_CHECKSUM
(which is wrong; fuzzers have no problem with enforcing a static prefix)
and other either disregard the offset or check the magic in an unsafe
way. Also, use FWUPD_ERROR_INVALID_FILE consistently for magic failure.

Add a vfunc, and move all the clever code into one place.
2022-07-14 14:48:15 +01:00
Richard Hughes
ae0c3fe38a Add 'action' resolution flags to each FwupdSecurityAttr
We tried to solve this by matching the org.fwupd.hsi AppStream ID, but
in some cases the resolution depends on what actually failed.

Add "the action the user is supposed to do" as flags so that the
front-end can translate this in the appropriate way, for instance,
using a different string for log events and HSI dialogs.
2022-07-14 14:47:44 +01:00
xtcui
d86191c392 analogix: Add support for two new Startech devices. 2022-07-14 11:14:01 +01:00
Richard Hughes
e2f643e08c ccgx: Add quirk entries for the Goshen Ridge EVB 2022-07-14 11:06:28 +01:00
Richard Hughes
a06dedb253 trivial: Add a fu_memread_uint24_safe() to make some code more correct 2022-07-14 11:03:13 +01:00
hugh chao(hugh712)
a7e1307bfd dell-dock: update doc to clarify the hidden inhibited usb4 device 2022-07-14 07:56:47 +01:00
Richard Hughes
77880751cd Do not use CoD even when advertized on non-aarch64 platforms
Fixes https://github.com/fwupd/fwupd/issues/4823
2022-07-14 07:50:42 +01:00
michaelcheng04
8a7c159d31 elanfp: Add new protocol for CFU update
1. Removed usb-control-transfer tag.
2. Removed is_bulk_transfer temp variable.

Signed-off-by: michaelcheng04 <michael.cheng@emc.com.tw>
2022-07-13 22:12:35 +01:00
michaelcheng04
b65844b960 elanfp: Add new protocol for CFU update
1. Using bulk transfer instead of control transfer to send command.
2. Adding header to command format.

Signed-off-by: michaelcheng04 <michael.cheng@emc.com.tw>
2022-07-13 22:12:35 +01:00
michaelcheng04
5621404bda elanfp: Add new protocol for CFU update
Signed-off-by: michaelcheng04 <michael.cheng@emc.com.tw>
2022-07-13 22:12:35 +01:00
Richard Hughes
1ffc2608b0 Check for overflow when copying buffers with huge offset values 2022-07-13 22:04:10 +01:00
Richard Hughes
56e5c1b7a9 Fix critical warning when parsing invalid FDT firmware
Never let firmware_current be NULL by checking for the root node ENDing.

Fixes https://oss-fuzz.com/testcase-detail/5454411320655872
2022-07-13 22:04:01 +01:00
Richard Hughes
2fbadaa95f acpi-phat: Fix a critical warning when parsing an invalid PHAT record
See https://oss-fuzz.com/testcase-detail/6099569951244288 for details.
2022-07-13 22:03:58 +01:00
Richard Hughes
060e40b16c trivial: Remove an unhelpful and untrue error prefix 2022-07-13 20:43:01 +01:00
Mario Limonciello
7a9fffe3a6 Enable protobuf-c (and relevant plugins) based on them in Ubuntu
an MIR has been completed in Ubuntu for this.

https://bugs.launchpad.net/ubuntu/+source/protobuf-c/+bug/1956617
2022-07-13 14:38:04 -05:00
Richard Hughes
34ff01fdf5 trivial: Continue to install the index page to fix the docs deployment 2022-07-11 16:44:12 +01:00
Richard Hughes
74f6faa4a1 trivial: Sync spec file with downstream 2022-07-11 12:49:15 +01:00
Richard Hughes
24e7182af0 trivial: post release version bump 2022-07-11 12:48:54 +01:00
Richard Hughes
4c7ca5f13e Release fwupd 1.8.2 2022-07-11 12:31:14 +01:00
Richard Hughes
011efbb3f3 logitech-hidpp: Fix one more guessed FuProgress step 2022-07-11 11:59:31 +01:00
Richard Hughes
8f3ebe62c2 trivial: Fix downstream spec file 2022-07-11 11:54:14 +01:00
Richard Hughes
d5de92095a trivial: Fix typo in 85c01e1 where the plugin name was removed 2022-07-11 11:46:04 +01:00
Richard Hughes
ab9f27e6db Add a precommit script to check for missing GObject finalizers 2022-07-11 11:16:47 +01:00
Richard Hughes
3b71918346 trivial: Remove some dead code spotted by Coverity 2022-07-11 10:17:59 +01:00
Richard Hughes
acc66316ec steelseries: Fix trivial -Wunused-variable issue 2022-07-11 09:58:00 +01:00
Richard Hughes
3391845660 corsair: Fix trivial -Wformat issue 2022-07-11 09:53:36 +01:00