Commit Graph

2946 Commits

Author SHA1 Message Date
Richard Hughes
97b33f3472 Use a more suitable icon for USB hubs 2022-04-25 14:49:30 +01:00
Richard Hughes
b7bf0a7611 Do not fallback to audio-card
Let the frontend choose the most appropriate icon if unspecified.
2022-04-25 14:49:30 +01:00
PatriciaJonsson
0570829981
dfu: Add support for FlatFrog devices 2022-04-25 10:36:27 +01:00
Richard Hughes
c1d67be0a5 genesys: Fix a potential buffer overread spotted by Coverity
overrun-buffer-arg: Overrunning array buf of 64 bytes by passing it to
a function which accesses it at byte offset 65 using argument len + 3UL
2022-04-25 07:03:26 +01:00
Richard Hughes
492563d5f2 trivial: Ignore the return value of g_strlcpy() when safe 2022-04-23 10:30:50 +01:00
Richard Hughes
4414866d38 genesys: Remove some dead code 2022-04-23 10:28:16 +01:00
Richard Hughes
45b1a0bbe3 modem-manager: Remove unused variable 2022-04-23 10:28:16 +01:00
Richard Hughes
d32bbb0084 genesys: Remove unused variable 2022-04-23 10:28:16 +01:00
Richard Hughes
c38be3aca6 corsair: Use correct format specifier in error message 2022-04-23 10:28:16 +01:00
Richard Hughes
b7bb9c35dd ch341a: Remove unused variable 2022-04-23 10:28:16 +01:00
Richard Hughes
a1517e4875 dfu: Use the correct icon automatically for USB webcams 2022-04-23 08:56:58 +01:00
Mario Limonciello
b7b06df928 trivial: dell: ignore a false positve for stringop-overread 2022-04-23 08:27:34 +01:00
Sergii Dmytruk
e9f765dc47 plugins/flashrom/fu-flashrom-device.c: create layout on open
This avoids possible reading IFD multiple times and fixes a memory leak
of layout on errors and an unconditional leak in
fu_flashrom_device_prepare(), which didn't call
flashrom_layout_release().

Notice that flashrom_layout_set() call does NOT transfer ownership.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Sergii Dmytruk
e1d708a4ff plugins/flashrom: manage flashrom context at plugin level
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Sergii Dmytruk
ddf4e10d7b plugins/flashrom: enable for 2 Tuxedo laptops
Their ME region in flash can be unlocked manually, give user
instructions on how to do it.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Sergii Dmytruk
e65cb98cc8 plugins/flashrom: add flashrom-specific GUIDs
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Sergii Dmytruk
2bac03eee1 plugins/flashrom: create separate device for ME region
Created only if intel_spi plugin indicates that the region exists by
creating its own device for it.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Richard Hughes
81fbff8445 redfish: Restart the BMC after installing BCM updates 2022-04-19 20:24:59 +01:00
Sergii Dmytruk
523ed0d7b4 plugins/flashrom: make region we're flashing a property
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-19 10:47:41 +01:00
Sergii Dmytruk
b678170ee7 plugins/intel-spi: mark ME region device locked if it's RO
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-19 10:44:46 +01:00
Sergii Dmytruk
294bd648ea trivial: plugins/superio: include prj_name in IT55's to_string
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-19 10:44:28 +01:00
Sergii Dmytruk
dce73cbffb plugins/superio: don't leak chiplet property of device
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-19 10:44:10 +01:00
Richard Hughes
7ec0f11e69 mtd: Use the correct uSWID child for multiple coSWID children 2022-04-18 17:48:52 +01:00
Mario Limonciello
0432cfe537 trivial: uefi: drop unnecessary HAVE_HSI declaration
This appears to have been from before a vfunc was added and isn't
necessary.
2022-04-18 10:01:02 -05:00
Mario Limonciello
1406e42745 trivial: bios: Add an attribute to fail HSI in legacy BIOS mode
Fixes: #4530
2022-04-18 10:01:02 -05:00
Richard Hughes
2d5186622c Add FuProgress to ->prepare and ->cleanup
Some plugins were creating local versions (which were not attached to
the daemon progress in any way) as a workaround as they needed to do
actions that took a long time to complete.
2022-04-15 16:50:06 +01:00
Richard Hughes
a374254d74 redfish: Drop the cache when invalidated 2022-04-15 16:49:48 +01:00
Richard Hughes
08a3fd8b65 redfish: Fix a memory leak when calling ->setup() more than once 2022-04-15 16:49:48 +01:00
Richard Hughes
064cb648c1 redfish: Allow specifying the request type 2022-04-15 07:43:09 +01:00
Richard Hughes
f8f5cd1f25 redfish: Don't add a device to itself when replugging 2022-04-14 13:06:21 +01:00
Mario Limonciello
d19ebccd56 trivial: pci_psp: test an attribute to declare missing data
If the system loads ccp but the ccp driver doesn't export attributes
we should mark the CPU plugin as not supported.
2022-04-14 01:39:22 -05:00
Richard Hughes
3b0d1a6c6b trivial: Ignore the return value of curl_easy_setopt() in most cases
This makes Coverity happy.
2022-04-13 15:08:12 +01:00
Richard Hughes
0b7af7d54b trivial: Ignore the return value of setenv() in most cases
This makes Coverity happy.
2022-04-13 15:08:12 +01:00
Richard Hughes
0f8dffd042 intel-spi: Fix potential integer overflow 2022-04-13 15:08:12 +01:00
Richard Hughes
200302bbc6 redfish: Remove some logically dead code 2022-04-13 15:08:12 +01:00
Richard Hughes
d0c8514c52 wacom-raw: Fix a Coverity false positive
Technically this is an OOB write, but we're deliberately writing into
the next section of the FuWacomRawRequest structure.

Be explicit to avoid Coverity warnings.
2022-04-13 15:08:12 +01:00
Richard Hughes
a7149a4dac genesys: Fix a potential OOB read 2022-04-13 15:08:12 +01:00
Richard Hughes
5fdef8defb wacom-usb: Fix a small memory leak in an error path 2022-04-13 15:08:12 +01:00
Richard Hughes
db07e84fe0 tpm: Fix a small memory leak in an error path 2022-04-13 15:08:12 +01:00
Richard Hughes
b25a3a4294 superio: Fix a small memory leak in an error path 2022-04-13 15:08:12 +01:00
Richard Hughes
34651a18e2 nordic: Fix a small memory leak in an error path 2022-04-13 15:08:12 +01:00
Jierger Zhou
443b6450f0 dfu: modified VID/PID for atlas camera. 2022-04-13 08:12:09 +01:00
Crag Wang
9c8dc29711 dell-dock: probe mst earlier to determine signed payload attr 2022-04-13 00:00:01 -05:00
Mario Limonciello
5d3bcdc2ef trivial: CPU: Mark AMD as supported 2022-04-12 12:23:16 -05:00
Mario Limonciello
cc49eb6503 trivial: msr: align the unencrypted RAM failures to match that of psp plugin 2022-04-12 12:23:16 -05:00
Mario Limonciello
f63a1c7a87 pci_psp/msr: Set obsoletes related to SME and TSME
TSME and SME can technically both be enabled at the same time, but
there is no use in reporting one as enabled and the other disabled.

They share the same attribute, and so if one is enabled, obsolete
it in the other plugin.

Granted; this is a bit of a confusing experience.  You have two attributes
that mean similar but not the same things.  You can technically have SME
and TSME both enabled at the same time, or both disabled at the same time.
2022-04-12 12:23:16 -05:00
Mario Limonciello
1a66818970 Add new plugin for AMD PSP
This plugin reads in values exported by the PSP on supported AMD
SOCs to calculate the system state based on this information
2022-04-12 12:23:16 -05:00
Mario Limonciello
0e3e8ff610 trivial: change Intel debug attributes to generic
As other platforms have features with the same attribute, remove
the Intel generic one.
2022-04-12 10:39:02 -05:00
Richard Hughes
035490d39e modem-manager: Remove the cache item and use a shadow device instead
Fixes https://github.com/fwupd/fwupd/issues/4394
2022-04-12 09:59:19 +01:00
Richard Hughes
bef1d742b3 Allow Capsule-on-Disk to work in more cases 2022-04-12 09:57:44 +01:00