Commit Graph

3484 Commits

Author SHA1 Message Date
Richard Hughes
39a270e1b3 synaptics-prometheus: Set the install duration from a quirk
Yes, it is quick. It's really the time to process one HUGE bulk request...
2019-05-28 17:24:50 +01:00
Richard Hughes
8a5df4dd32 synaptics-prometheus: Don't emit critial warning when updating config firmware 2019-05-28 17:24:50 +01:00
Richard Hughes
5575083677 synaptics-prometheus: Fix missing field in the IOTA reply struct 2019-05-28 17:24:50 +01:00
Richard Hughes
0b3e203ffc Create SECURITY.md 2019-05-28 06:24:41 -05:00
Richard Hughes
10f8d15af1 redfish: Never set NULL device name 2019-05-24 12:57:56 +01:00
Richard Hughes
ebe1d43122 modem-manager: Never set NULL device name 2019-05-24 12:57:56 +01:00
Richard Hughes
501a84d08f ata: Never set NULL device name
Probably fixes https://github.com/hughsie/fwupd/issues/1206
2019-05-24 12:57:56 +01:00
Richard Hughes
3b89ab1dee trivial: Add some parameter guards to FuDevice
Not actually fixing any bug, but it means we crash before we do any damage...
2019-05-24 12:57:56 +01:00
Mario Limonciello
c8bfb40527 trivial: snap: make polkit directories if they don't exist (Fixes: #1205) 2019-05-23 14:29:04 -05:00
Mario Limonciello
057c67a830 trivial: fu-main: clarify missing PK file error
Point people to a wiki page to explain what is happening and how to fix it.
2019-05-23 11:11:04 -05:00
Mario Limonciello
6f352cb7e5 synapticsmst: fix GUID generation (Closes: #1207)
When converting to instances we forgot to add the GUIDs to the device
as well.
2019-05-23 09:52:18 -05:00
Sean-StarLabs
7239c6ab45 Lite Mk II flag for use-shim-unique
Added AMI fix for the "duplicate entry" issue to firmware version 1.0.4 - quirk is needed to install new version
2019-05-23 14:57:17 +01:00
Mario Limonciello
8b8e9d815d trivial: circleci: try to fix automatic snap deployment
Split up the promotion step into a separate workflow with it's own
filters.

According to https://circleci.com/docs/2.0/workflows/#executing-workflows-for-a-git-tag
every dependency needs its own tag filter, so hopefully this should
fix automatic deployment.
2019-05-22 11:00:38 -05:00
Richard Hughes
13800b719e Allow SuperIO updates to be done live
Apparently Star Labs have been using this for some time. It's still important
to reboot after the update has been performed.
2019-05-22 12:54:38 +01:00
Mario Limonciello
568bae29c9 fu-util-common: Support empty proxy strings (Fixes: #1199)
Arch apparently sets all proxies to zero length and this causes
problems for fwupd.
2019-05-21 18:03:24 +01:00
Mario Limonciello
d83f5fe05e trivial: uefi: clarify error message
Help people to debug when their ESP isn't found.
2019-05-20 10:59:54 -07:00
Richard Hughes
d92cccaf13 trivial: Fix non-systemd build 2019-05-20 11:37:09 +01:00
Richard Hughes
150c201f5d trivial: Sync example spec file with downstream 2019-05-20 11:28:19 +01:00
Richard Hughes
22fea218f9 trivial: post release version bump 2019-05-20 11:20:49 +01:00
Richard Hughes
4808c0ebad Release fwupd 1.2.9 2019-05-20 11:17:42 +01:00
Richard Hughes
b30f82fe98 trivial: Add two new translatable strings for new category types 2019-05-20 09:29:24 +01:00
Richard Hughes
3d00522dd3 Check if the system is offline during install, rather than at startup
This splits out the systemd functionality to a new file, but makes no other
logic changes.
2019-05-18 08:02:29 -07:00
Richard Hughes
54e636e96d Prompt the user to shutdown if requried when installing by ID
This matches what is done in the update-all and install cases.
2019-05-18 14:07:23 +01:00
Richard Hughes
0a90626413 Use the correct file extension for the offline updates cache
For a long time these have been cabinet archives, not UEFI update capsules.
2019-05-18 14:07:09 +01:00
Richard Hughes
1877e8682c trivial: Allow using --force to use the wrong daemon version 2019-05-18 14:07:05 +01:00
Richard Hughes
ad755e5450 trivial: Display the correct expected command 2019-05-18 14:06:55 +01:00
Mario Limonciello
12d25460b2 standalone-installer: Be smarter about existing installed fwupd
Allow setting a minimum fwupd version requirement using `--minimum`.

If running on a distro with apt, try to use this to detect an already
installed version and compare what was passed in to `--minimum`.
* If new enough version, use the built in version
* If too old of a version or not specified, require package removal.
2019-05-14 14:14:52 -05:00
Richard Hughes
c7bdded2c6 Add a plugin to update Synaptics Prometheus fingerprint readers 2019-05-14 17:18:55 +01:00
Mario Limonciello
0156b8fa78 trivial: standalone-installer: rename uninstall argument to cleanup 2019-05-08 10:05:31 -05:00
Mario Limonciello
81d83c416c fu-util: Check the daemon version is at least the client version 2019-05-08 10:05:31 -05:00
Mario Limonciello
88f8b7f8e1 fu-util: Check that daemon is started by expected unit
Unexpected behaviors can happen if:
* a snapped daemon is running with a packaged frontend
* a packaged daemon is running with a snapped frontend

This should make sure that if the snap is installed on top of a
packaged frontend that people don't try to mix and match as much.
2019-05-08 10:05:31 -05:00
Mario Limonciello
ea527ca2e7 fu-util-common: when stopping a daemon, check for snap too 2019-05-08 10:05:31 -05:00
Richard Hughes
5cbb5cf908 Allow using --force to trigger a duplicate offline update 2019-05-07 14:30:07 +01:00
Richard Hughes
c3bbfe70a8 trivial: Allow using FuUsbDevice without a GUsbDevice
This allows us to use it more easily in the self tests.
2019-05-07 14:30:07 +01:00
Richard Hughes
069433e97d trivial: Copy the icons if unset for the device child 2019-05-07 14:30:07 +01:00
Richard Hughes
08ba5be69b trivial: Copy the physical ID if unset for the device child 2019-05-07 14:30:07 +01:00
Richard Hughes
59c4d02698 trivial: Ensure the parent ID is up to date if the device ID changes
This includes the case where the device ID is unset, the child gets added and
the parent device ID then gets set. This makes the ordering for adding children
much less fragile.
2019-05-07 14:30:07 +01:00
Richard Hughes
f5d799df19 trivial: Fix typo when setting the parent ID 2019-05-07 14:30:07 +01:00
Richard Hughes
8238de9995 trivial: Disable the flatpak CI build
It's failing for no good reason, and travis is spamming me with emails.
2019-05-07 10:34:55 +01:00
Richard Hughes
dfa9e11bb2 Allow handling FORCE for devices that subclass FuDevice
Pass FwupdInstallFlags down to the vfunc to allow us to check the flags when
parsing the firmware and updating the device.
2019-05-05 15:29:00 -05:00
Richard Hughes
26d3da4074 uefi: Fix a libasan failure when reading a UEFI variable
It seems some older versions of libefi var incorrectly build the 'length' value
in the DP returned from efi_generate_file_device_path(). This means we copy past
the end of the allocated buffer when parsing the efi_update_info_t structure.

This bug seems fixed in efivar git master, and this fix is only going to help
people with older efivar versions. It's probably a good thing to be a bit more
paranoid about EFI variable data anyway.

    DEBUG: UpdateInfo:
           ? 00 01 02 03 04 05 06 07 08 09 0a 0b 0c 0d 0e 0f 10 11 12 13 14 15 16 17 18 19 1a 1b 1c 1d 1e 1f
    ????????????????????????????????????????????????????????????????????????????????????????????????????????
    0x0000 ? 07 00 00 00 20 d9 7b 69 cf 12 a9 4d 83 85 99 69 09 bc 65 59 00 00 05 00 00 00 00 00 00 00 00 00
    0x0020 ? 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 01 00 00 00 04 01 2a 00 01 00 00 00 00 08 00 00
    0x0040 ? 00 00 00 00 00 40 06 00 00 00 00 00 5a aa 97 5a 10 d5 7e 49 99 0b ca 8d 35 4d c8 6d 02 02 04 04
    0x0060 ? 86 00 5c 00 45 00 46 00 49 00 5c 00 66 00 65 00 64 00 6f 00 72 00 61 00 5c 00 66 00 77 00 5c 00
    0x0080 ? 66 00 77 00 75 00 70 00 64 00 2d 00 36 00 39 00 37 00 62 00 64 00 39 00 32 00 30 00 2d 00 31 00
    0x00a0 ? 32 00 63 00 66 00 2d 00 34 00 64 00 61 00 39 00 2d 00 38 00 33 00 38 00 35 00 2d 00 39 00 39 00
    0x00c0 ? 36 00 39 00 30 00 39 00 62 00 63 00 36 00 35 00 35 00 39 00 2e 00 63 00 61 00 70 00 00 00 7f ff
    0x00e0 ? 04 00
    DEBUG: DP type:0x04 subtype:0x01 size:0x002a
    DEBUG: DP type:0x04 subtype:0x04 size:0x0086
    DEBUG: found END_ENTIRE at 0x00aa
    DEBUG: DP length invalid! Truncating from 0x0086 to 0x0080
    DEBUG: DP type:0x7f subtype:0xff size:0x0004
2019-05-02 17:25:34 +01:00
Richard Hughes
8499930a45 trivial: Fix a memory leak found using libasan 2019-05-02 10:46:12 +01:00
Richard Hughes
bb5199b428 trivial: Fix an libasan failure in the dell plugin
Use a buffer of an explicit size to avoid reading junk off the stack.
2019-05-02 10:46:06 +01:00
Richard Hughes
1b83960d88 trivial: Fix some dead code spotted by coverity 2019-05-02 09:59:47 +01:00
Richard Hughes
41c35d084c trivial: Fix a typo spotted by coverity 2019-05-02 09:59:47 +01:00
Richard Hughes
f5a0d24a95 trivial: Fix a missing config.h include in a new source file 2019-05-02 09:59:47 +01:00
Mario Limonciello
e1b4b20978 Dynamically read path to use for /system-update
This allows `fwupdoffline` to work in installations that don't use
`/var/lib/fwupd`.
2019-05-01 09:24:55 -05:00
Richard Hughes
acfa4ef012 Display the remote warning on the console in an easy-to-read way
The lines are almost impossible to read as they are not wrapped and not
delimited from the normal script output. Add a box around to make them stand out:

    ╔══════════════════════════════════════════════════════════════════════════════╗
    ║ The LVFS is a free service that operates as an independent legal entity and  ║
    ║ has no connection with Fedora. Your distributor may not have verified any    ║
    ║ of the firmware updates for compatibility with your system or connected      ║
    ║ devices. All firmware is provided only by the original equipment             ║
    ║ manufacturer.                                                                ║
    ║                                                                              ║
    ║ Enabling this functionality is done at your own risk, which means you have   ║
    ║ to contact your original equipment manufacturer regarding any problems       ║
    ║ caused by these updates. Only problems with the update process itself        ║
    ║ should be filed at https://bugzilla.redhat.com/.                             ║
    ║                                                                              ║
    ╚══════════════════════════════════════════════════════════════════════════════╝

    Agree and enable the remote? [Y|n]:
2019-05-01 14:03:11 +01:00
Mario Limonciello
8be5756edd ata: Set version format to plain for devices obtained from udev
This matches behavior of those obtained by ID command.
2019-04-30 09:31:55 +01:00
Mario Limonciello
12a016b939 trivial: Only apply SmbiosManufacturer to release version for internal
External devices may not use the same VersionFormat.
2019-04-30 09:27:08 +01:00