Commit Graph

8138 Commits

Author SHA1 Message Date
Richard Hughes
1c27131fc6 trivial: Style nit
Co-authored-by: Mario Limonciello <mario.limonciello@amd.com>
2022-09-22 14:24:50 +01:00
Richard Hughes
f60af523e3 trivial: Don't print NULL in GError strings
PVS: Incorrect format: A null pointer is used.
2022-09-22 14:24:50 +01:00
Richard Hughes
d4c589cc04 trivial: Fix -Wunused-variable warning 2022-09-22 14:24:50 +01:00
Richard Hughes
2d2bde2268 trivial: Fix -Wunused-but-set-variable warning 2022-09-22 14:24:50 +01:00
Richard Hughes
b71968d348 trivial: Fix -Wunused-but-set-variable warning 2022-09-22 14:24:50 +01:00
Richard Hughes
7fd8aa6a38 Ignore missing NUL when parsing DS20 quirk data 2022-09-22 14:23:20 +01:00
Victor Cheng
ae74625721 usi-dock: Add initialization retry to ensure flash ready 2022-09-22 13:50:32 +01:00
SonixLeo
2c515f9a7b update the Quirk specifications for our Sonix CAM products 2022-09-22 10:34:43 +01:00
Richard Hughes
2fb81a6482 redfish: Only create users using IPMI when we know it's going to work
Make the IPMI auto-account feature allow-listed on specific vendors as some IPMI
implementations are not specification compliant and do entirely the wrong thing.
2022-09-21 14:22:35 +01:00
Richard Hughes
096364199b trivial: Fix self tests when using -Dgresource_quirks=enabled
We want to also skip the compiled-in GResource quirks if loading the context
with _NO_CACHE.
2022-09-21 12:59:44 +01:00
Richard Hughes
64cf323e57 wacom-raw: Fix maximum szie for AES panels
The latest AES panel G14T is expanded to 0x4000.
2022-09-21 07:29:33 +01:00
Richard Hughes
28fc1a5130 wacom-raw: Correctly finalize Wacom AES devices
The attach behaviour is not common between AES and EMR panels.
2022-09-21 07:29:33 +01:00
Alex
df35215171 Update create_containers.yml
Give packages permission to fix the runner
2022-09-20 11:59:41 -05:00
Alex
76ca69006f Update create_containers.yml
Fix for docker/build-push-action
2022-09-20 10:39:41 -05:00
Alex
86a99e9e45 build: harden create_containers.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-20 10:39:41 -05:00
Khem Raj
e9964a0f96 trivial: Fix compile when using python 3.7 or older
Signed-off-by: Richard Hughes <richard@hughsie.com>
2022-09-20 16:05:13 +01:00
Richard Hughes
9df226ca08 Revert "build: harden create_containers.yml permissions"
This reverts commit 34bc417abf.
2022-09-20 15:17:52 +01:00
Alex
34bc417abf build: harden create_containers.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-20 15:02:34 +01:00
Alex
c76551f381 build: harden main.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-20 15:02:34 +01:00
Richard Hughes
c0b8673faa dbx: Do not show the 'connected devices may not be usable while updating' message 2022-09-20 12:55:00 +01:00
Richard Hughes
b34dc9c1f1 redfish: Set the permissions of redfish.conf at install time
Although typically we set the password using fu_plugin_set_secure_config_value()
or something like Ansible or Puppet -- the user could just edit the file with
vim and we still want the permissions set correctly.
2022-09-20 12:33:03 +01:00
Richard Hughes
0d60fa319f trivial: Fix two gi-docgen issues 2022-09-20 10:16:55 +01:00
Mario Limonciello
fe5d93f7d2 trivial: wait for network to be online to run fwupd-refresh.service 2022-09-19 14:52:42 -05:00
Mario Limonciello
8a90d9bed4 trivial: Add RELEASE steps for flatpak and snap
These are both requiring manual steps now, so document them in the
release process.
2022-09-19 14:32:57 -05:00
Mario Limonciello
8bb10ffaa7 Update the snap build
Use core22 and subsume a bunch of dependencies that can come from the
Ubuntu archive now during build instead.

This doesn't restore the CI functionality yet, but it at least builds
locally for me OK.
2022-09-19 13:33:54 -05:00
Mario Limonciello
4e130ea003 trivial: disable void ci for now 2022-09-19 13:33:54 -05:00
Mario Limonciello
e8ca440bad Add new plugin to display SMU firmware version on AMD APU/CPU
This plugin is read-only, but can be used to tell what version of
SMU firmware is installed.
2022-09-19 06:51:27 -05:00
Richard Hughes
aba96e4a4a pixart-rf: Fix the endianness of the magic
This was probably broken in 0c51630991

Mea culpa.
2022-09-18 12:40:33 +01:00
Richard Hughes
b4f2d10562 trivial: Add some links to the BDP and ESP defines 2022-09-17 13:43:22 +01:00
Richard Hughes
e72ed08b56 Always check the BDP partitions when getting all the possible ESPs
Fixes https://github.com/fwupd/fwupd/issues/5035
2022-09-17 13:41:36 +01:00
Richard Hughes
48beb87faf Copy backend tags to the GUsbDevice when possible.
This allows the backend to identify the specific device for a specific phase.

For instance, there might be a pre-update runtime, a bootloader and a
post-update runtime and allowing tags to be saved to the backend object allows
us to identify each version of the same physical device.

This takes us one step closer to emulating a complete byte-perfect end-to-end
update without actual hardware installed.
2022-09-14 16:54:55 +01:00
Richard Hughes
139188a5b0 Allow adding backend tags to devices
This allows the backend to identify the specific device for a specific phase.

For instance, there might be a pre-update runtime, a bootloader and a
post-update runtime and allowing tags to be saved to the backend object allows
us to identify each version of the same physical device.

This takes us one step closer to emulating a complete byte-perfect end-to-end
update without actual hardware installed.
2022-09-14 16:54:55 +01:00
Mario Limonciello
6ce4244edd trivial: fix reading the microcode version on AMD systems
The kernel will issue a CPUID of 0x1 before reading microcode.
Align this behavior with the MSR plugin.

AMD and Intel align their microcode diffrently in MSR 0x8b.
* Intel it's 4 bytes in.
* AMD it's at the start of the MSR.
2022-09-13 11:10:45 -05:00
Mario Limonciello
fbe9c6444e trivial: fu-util-common: RO devices w/ FW versions are interesting
Sometimes even if fwupd can't upgrade these devices they're
interesting to end users because they may show information that
can otherwise only be obtained by tearing apart firmware or
using extra arguments.

Amend the default behavior to let these show up.
2022-09-13 09:57:29 -05:00
Richard Hughes
891bae783c Show the USB4 NVM device ID in the debug output
Otherwise there's no way to find out what value the big-table-of-data needs.
2022-09-13 14:25:15 +01:00
Richard Hughes
404ab8e3e9 trivial: Rename the internal NvmProductId to NvmModelId to match Intel docs
This preserves sanity when comparing numbers from vendors.
2022-09-13 14:25:15 +01:00
Mario Limonciello
561c8661f8 trivial: convert pci-psp plugin to create and use a device
In general this is a cleanup, means less vfuncs that get called when
devices are added. Beyon the optimization functionally should be a
no-op for fwupd.  It will also potentially storing the version
to the newly created secure processor device in the future.
2022-09-13 07:14:22 -05:00
Richard Hughes
bfebede490 Add support for platform capability descriptors so devices can set quirks
This feature adds support for platform capability BOS descriptors which allows
the device itself to ship quirk data.

Use `sudo fwupdtool get-devices --save-backends=FILENAME` to save fake backend
devices to a file. This allows easy creation of self tests that do not require
physical hardware.
2022-09-13 12:07:35 +01:00
Dylan Van Assche
a8017e0a4f mtd: expose Pine64 PinePhone Pro MTD as Tow-Boot
Pine64 PinePhone Pro has an SPI device which is handled by the MTD
plugin and comes with Tow-Boot pre-installed from the factory.
Expose it as Tow-Boot and mark the firmware type with uSWID for version
extraction. However, it does not provide uSWID data so users have to manually
upgrade to a Tow-Boot version with uSWID data support first.
2022-09-12 14:51:14 +01:00
Richard Hughes
d0edac7b67 trivial: Move to macos-12 for CI 2022-09-12 14:47:51 +01:00
Richard Hughes
84a27ea8b9 Fix a fuzzing crash when parsing malicious FDT data 2022-09-12 13:48:45 +01:00
Richard Hughes
e358cc7bde Set the firmware contents even when subclassing ->parse() 2022-09-10 09:16:05 +01:00
Richard Hughes
e8684d9f65 Check for plugin conflicts slightly quicker 2022-09-09 19:23:29 +01:00
Richard Hughes
ee57012df2 trivial: Work around a clang checker false-positive 2022-09-09 19:23:29 +01:00
Richard Hughes
1dab4f67cf modem-manager: Fix debug format string
PVS: The size_t type argument is expected.
2022-09-09 19:23:29 +01:00
Richard Hughes
e17f41b638 rts54hid: Fix possible unsafe memcpy()
PVS: A call of the 'memcpy' function will lead to underflow of the buffer.
2022-09-09 19:23:29 +01:00
Richard Hughes
d8c464889a logitech-hidpp: Fix possible unsafe memcpy()
PVS: A call of the 'memcpy' function will lead to underflow of the buffer.
2022-09-09 19:23:29 +01:00
Richard Hughes
c19d7d8b9f trivial: Workaround PVS false-positive 2022-09-09 19:23:29 +01:00
Richard Hughes
824f634244 dfu-csr: Fix uploading to devices
This was due to an overzealous sed script running in 90254a5152.

PVS: A call of the 'memcmp' function will lead to underflow of the buffer.
2022-09-09 19:23:29 +01:00
Richard Hughes
f7b4f43744 Fix checking for invalid depth requirements
PVS: It's possible that the 'device_tmp' should be checked here.
2022-09-09 19:23:29 +01:00