Commit Graph

2970 Commits

Author SHA1 Message Date
Richard Hughes
909907455e colorhug: Add the bootloader VID/PID used for the first batch of devices 2022-05-11 12:34:59 +01:00
Richard Hughes
a826f0134a colorhug: Never set a NULL version when the FW inface data is NULL
This fixes updating from ColorHug(1) devices on old firmware versions,
but doesn't affect ColorHug2.
2022-05-11 12:34:59 +01:00
Richard Hughes
861881691e trivial: Fix -Wunused-variable compile warning 2022-05-10 13:12:10 +01:00
Richard Hughes
2870426958 trivial: Fix a critical warning when no flashrom devices are found 2022-05-10 10:39:04 +01:00
Richard Hughes
7d89e85de5 scsi: Support updating firmware on UFS devices
Change-Id: I5573b1890135d1fd3b2f0cb8f95f74cbb3e21abe
2022-05-10 08:20:06 +01:00
Mario Limonciello
118cfd285b trivial: disable bios plugin for Win32 2022-05-09 15:54:51 -05:00
Richard Hughes
d3d7cfa816 Add plugin quirk keys earlier in the startup process
This allows creating the silo when starting the engine with custom
plugin keys such as WacomI2cFlashBaseAddr.

If we move the plugin initialization earlier then we don't get the
HwID matches, so we really do have to split this into a 4-stage startup,
e.g. ->load(), ->init(), ->startup() and ->coldplug().
2022-05-09 11:13:52 +01:00
Richard Hughes
5aefc520b6 redfish: Poll less frequently during cleanup
The BMC can take more than 30 minutes to start (!) if lots of devices
are installed.
2022-05-09 11:00:18 +01:00
Richard Hughes
e90367d854 redfish: hardcode the filedata name to firmware.bin
Unbelievably, using a filename with spaces causes Lenovo XCC to return a message
with InternalError, 'The request failed due to an internal service error.
The service is still operational.'

As we're using a multipart update rather than a legacy HttpPushUriTargetsBusy
PATCHing, hardcoding should be quite safe.
2022-05-09 11:00:18 +01:00
Richard Hughes
fb93b6c51c redfish: Do not mark all updates as UPDATABLE 2022-05-09 11:00:18 +01:00
Richard Hughes
5ebcfa909c redfish: Use actual FuProgress steps for ->cleanup() 2022-05-09 11:00:18 +01:00
Richard Hughes
f0ef6ae05f scsi: Rearchitect the plugin to match a block device
This makes it match the eMMC and SATA plugins, and means we can more easily
walk up to the parent SCSI controller, rather than trying to find the correct
block child.

No functional changes, other than now we also read the disk serial number, and
use one less udev subsystem match.
2022-05-09 07:05:08 +01:00
Mario Limonciello
2232ba2c4c trivial: uefi-recovery: don't build on Windows 2022-05-05 15:38:43 -05:00
Mario Limonciello
1c38d02367 trivial: lenovo-thinklmi: disable plugin build outside linux 2022-05-05 11:51:22 -05:00
Richard Hughes
9f584a234a flashrom: Allow dumping firmware using fwupdtool 2022-05-04 14:10:18 +01:00
Richard Hughes
c0bdb8dd7a flashrom: Only set the BIOS size if not already quirked 2022-05-04 11:11:23 +01:00
Richard Hughes
5ac8594d92 flashrom: Use more ideomatic GLib style 2022-05-04 11:11:23 +01:00
Richard Hughes
539413ca51 parade-lspcon: Fix regression when probing PS175 devices
Fixes https://github.com/fwupd/fwupd/issues/4580
2022-05-02 22:19:38 +01:00
ChangHee (Ryan) Lee
310a513e35
ccgx: modify quirk for HP 2022-04-29 16:55:27 +01:00
Richard Hughes
f81a3e671e synaptics-mst: Read the fw-size in a more safe way 2022-04-28 14:20:13 +01:00
Richard Hughes
beb49d7ac0 trivial: Add fu_common_read_uint24() helper for future code 2022-04-28 14:18:30 +01:00
Richard Hughes
2b81290829 synaptics-prometheus: Add a sanity check to fix a fuzzing failure
Fixes https://oss-fuzz.com/testcase-detail/6232454836387840
2022-04-28 07:24:00 +01:00
Richard Hughes
f5bbd744f5 wacom-usb: Fix a timeout when parsing very corrupt firmware
Fixes https://oss-fuzz.com/testcase-detail/5797345020739584
2022-04-28 07:24:00 +01:00
ChangHee (Ryan) Lee
89cfe97625
ccgx: Fix failure to replug 2022-04-27 12:03:16 +01:00
Richard Hughes
97b33f3472 Use a more suitable icon for USB hubs 2022-04-25 14:49:30 +01:00
Richard Hughes
b7bf0a7611 Do not fallback to audio-card
Let the frontend choose the most appropriate icon if unspecified.
2022-04-25 14:49:30 +01:00
PatriciaJonsson
0570829981
dfu: Add support for FlatFrog devices 2022-04-25 10:36:27 +01:00
Richard Hughes
c1d67be0a5 genesys: Fix a potential buffer overread spotted by Coverity
overrun-buffer-arg: Overrunning array buf of 64 bytes by passing it to
a function which accesses it at byte offset 65 using argument len + 3UL
2022-04-25 07:03:26 +01:00
Richard Hughes
492563d5f2 trivial: Ignore the return value of g_strlcpy() when safe 2022-04-23 10:30:50 +01:00
Richard Hughes
4414866d38 genesys: Remove some dead code 2022-04-23 10:28:16 +01:00
Richard Hughes
45b1a0bbe3 modem-manager: Remove unused variable 2022-04-23 10:28:16 +01:00
Richard Hughes
d32bbb0084 genesys: Remove unused variable 2022-04-23 10:28:16 +01:00
Richard Hughes
c38be3aca6 corsair: Use correct format specifier in error message 2022-04-23 10:28:16 +01:00
Richard Hughes
b7bb9c35dd ch341a: Remove unused variable 2022-04-23 10:28:16 +01:00
Richard Hughes
a1517e4875 dfu: Use the correct icon automatically for USB webcams 2022-04-23 08:56:58 +01:00
Mario Limonciello
b7b06df928 trivial: dell: ignore a false positve for stringop-overread 2022-04-23 08:27:34 +01:00
Sergii Dmytruk
e9f765dc47 plugins/flashrom/fu-flashrom-device.c: create layout on open
This avoids possible reading IFD multiple times and fixes a memory leak
of layout on errors and an unconditional leak in
fu_flashrom_device_prepare(), which didn't call
flashrom_layout_release().

Notice that flashrom_layout_set() call does NOT transfer ownership.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Sergii Dmytruk
e1d708a4ff plugins/flashrom: manage flashrom context at plugin level
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Sergii Dmytruk
ddf4e10d7b plugins/flashrom: enable for 2 Tuxedo laptops
Their ME region in flash can be unlocked manually, give user
instructions on how to do it.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Sergii Dmytruk
e65cb98cc8 plugins/flashrom: add flashrom-specific GUIDs
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Sergii Dmytruk
2bac03eee1 plugins/flashrom: create separate device for ME region
Created only if intel_spi plugin indicates that the region exists by
creating its own device for it.

Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-21 15:39:47 +01:00
Richard Hughes
81fbff8445 redfish: Restart the BMC after installing BCM updates 2022-04-19 20:24:59 +01:00
Sergii Dmytruk
523ed0d7b4 plugins/flashrom: make region we're flashing a property
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-19 10:47:41 +01:00
Sergii Dmytruk
b678170ee7 plugins/intel-spi: mark ME region device locked if it's RO
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-19 10:44:46 +01:00
Sergii Dmytruk
294bd648ea trivial: plugins/superio: include prj_name in IT55's to_string
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-19 10:44:28 +01:00
Sergii Dmytruk
dce73cbffb plugins/superio: don't leak chiplet property of device
Signed-off-by: Sergii Dmytruk <sergii.dmytruk@3mdeb.com>
2022-04-19 10:44:10 +01:00
Richard Hughes
7ec0f11e69 mtd: Use the correct uSWID child for multiple coSWID children 2022-04-18 17:48:52 +01:00
Mario Limonciello
0432cfe537 trivial: uefi: drop unnecessary HAVE_HSI declaration
This appears to have been from before a vfunc was added and isn't
necessary.
2022-04-18 10:01:02 -05:00
Mario Limonciello
1406e42745 trivial: bios: Add an attribute to fail HSI in legacy BIOS mode
Fixes: #4530
2022-04-18 10:01:02 -05:00
Richard Hughes
2d5186622c Add FuProgress to ->prepare and ->cleanup
Some plugins were creating local versions (which were not attached to
the daemon progress in any way) as a workaround as they needed to do
actions that took a long time to complete.
2022-04-15 16:50:06 +01:00