Richard Hughes
df9cc282ec
trivial: Only build the synapticsmst if HAVE_SYNAPTICS is set
2017-01-20 12:52:58 +00:00
Mario Limonciello
72f905d846
trivial: dell: fix test suite
...
Commit cd87fca
broke running the test suite on machines without
UEFI capsule support.
2017-01-19 14:16:23 -06:00
Richard Hughes
67a756c93f
synapticsmst: Refactor away the global state
...
The synapticsmst-common.c file had some global state so that cascade devices
could use the device fd. This made the control flow error prone, and it meant
that the fd could be leaked trivially on any error path.
Moving the fd ownership to the device is the logical place for the control, and
means we can create "connections" to access the main device and the cascade
devices.
This fixes the warnings detected by Coverity.
2017-01-19 13:41:04 +00:00
Richard Hughes
fffa21639b
trivial: unindent a code block
2017-01-19 08:51:16 +00:00
Richard Hughes
d99282f2ca
trivial: Fix an anti-pattern when returning error strings
2017-01-19 08:43:06 +00:00
Richard Hughes
2ef5ae0536
trivial: dell: Fix some intenting that was making coverity unhappy
2017-01-18 08:32:45 +00:00
Richard Hughes
f0a799eabf
Only register the D-Bus service when all devices have been added
...
Poll each plugin, and only register the service when all the delayed coldplug
devices have been added to the device list. This prevents returning an error
when calling "fwupdmgr get-devices" for the very first time.
Resolves: https://github.com/hughsie/fwupd/issues/82
2017-01-18 08:10:32 +00:00
Mario Limonciello
836ff015b3
trivial: synaptics: on new systems show unknown rather than failing
2017-01-17 16:08:04 -06:00
Mario Limonciello
7d5003e643
trivial: synaptics: don't fail on systems with less DP aux nodes
2017-01-17 13:23:46 -06:00
Mario Limonciello
548c6901c4
trivial: synaptics: add missing ID string for Rugged platforms
2017-01-17 12:13:59 -06:00
Mario Limonciello
0ed79d5455
trivial: synaptics: log invalid board IDs
2017-01-17 12:02:15 -06:00
Mario Limonciello
cd87fcae5a
trivial: dell: don't disable plugin if UEFI capsule isn't supported
...
It now supports enabling things for other plugins too, so rather
mark any devices created by Dell as only readable, not flashable
when UEFI capsule is off.
2017-01-17 11:49:33 -06:00
Mario Limonciello
908b17e1fb
trivial: dell: Don't output error domain twice
2017-01-17 11:38:34 -06:00
Mario Limonciello
f48a93546e
trivial: dell: only enable coldplug delay when needed
...
The coldplug delay that Dell uses is only needed for the thunderbolt
and synaptics MST plugins.
2017-01-17 11:35:20 -06:00
Richard Hughes
1b36055416
trivial: Fix example rpm spec file
2017-01-17 15:45:00 +00:00
Richard Hughes
31fd185ecf
trivial: Fix make distcheck
2017-01-17 15:44:52 +00:00
Richard Hughes
6a9c91a083
trivial: Fix a trivial warning in the altos plugin
2017-01-17 15:37:08 +00:00
Richard Hughes
8dafc604e0
trivial: Fix up the typedef'd enum style
2017-01-17 14:15:00 +00:00
Richard Hughes
2153cd0f89
trivial: Use guint8 rather than guchar
...
Although it's probably the same, this matches the other plugins.
2017-01-17 14:10:12 +00:00
Richard Hughes
26aade02d2
trivial: Don't use caps in variable names
2017-01-17 13:21:14 +00:00
Pei-Chen Huang
9225270421
trivial: fix synaptics device scan cascade function
2017-01-17 06:23:45 -06:00
Richard Hughes
3d8d48c896
trivial: Remove boilerplate gtk-doc from plugin
2017-01-17 11:17:29 +00:00
Richard Hughes
0c91cb0a94
trivial: Don't output the error domain twice
2017-01-17 11:17:29 +00:00
Richard Hughes
ae040f77b8
trivial: Fix some indenting in synapticsmst
2017-01-17 11:17:29 +00:00
Richard Hughes
94ce14f317
trivial: Use rc for return codes
...
The variable ret is normally reserved for boolean values.
2017-01-17 08:58:40 +00:00
Richard Hughes
1967c6c9ac
trivial: Fix up some missing return value assignments
...
Spotted by coverity.
2017-01-17 08:54:34 +00:00
Richard Hughes
db0a3cb37f
trivial: Fix up some indent issues spotted by coverity
2017-01-17 08:54:03 +00:00
Richard Hughes
999f66ab13
trivial: Actually set the Unifying device name
2017-01-16 22:00:40 +00:00
Mario Limonciello
f53e4a2d4b
trivial: synapticsmst: only enable plugin if kernel support is present
2017-01-16 15:37:11 -06:00
Mario Limonciello
8eaf6dbcd6
trivial: synapticsmst: don't proceed if device open fails
2017-01-16 15:14:47 -06:00
Pei-Chen Huang
abac1640a5
synapticsmst: Add cascade support
2017-01-16 11:23:43 -06:00
Mario Limonciello
24afb470f2
Introduce plugin for Synaptics MST hubs
2017-01-16 11:23:43 -06:00
Richard Hughes
e3c8832dd0
trivial: Fix a critical warning when removing thunderbolt devices in safe mode
2017-01-11 21:51:21 +00:00
Mario Limonciello
038d386a82
dell: introduce a standalone (noinst) tool to force mode flashes
2017-01-11 15:35:55 -06:00
Richard Hughes
2520b7d1ed
trivial: Add some debugging in the thunderbolt plugin
2017-01-11 17:24:20 +00:00
Richard Hughes
26adb3c819
trivial: Fix a crash when flashing a thunderbolt controller in safe mode
2017-01-11 17:21:10 +00:00
Richard Hughes
ccd78a9703
trivial: Add some sanity guards in plugin-calling functions
2017-01-11 16:57:41 +00:00
Richard Hughes
fcca6f67b2
Include all debug messages when run with --verbose
2017-01-11 16:50:17 +00:00
Richard Hughes
44dee88ad6
trivial: Protect against multiple uses of fu_plugin_alloc_data() in a plugin
2017-01-11 08:31:10 +00:00
Richard Hughes
b21e324c23
trivial: Always call update_cleanup() even when the update action fails
...
In this case we can't return any failure to cleanup and just log the warning
on the console.
2017-01-11 08:29:17 +00:00
Mario Limonciello
0d92e865aa
trivial: thunderbolt: don't allocate new plugin data on rescan
2017-01-10 19:55:12 -06:00
Mario Limonciello
9df75f7206
trivial: dell: move coldplug delay setting to startup()
2017-01-10 17:13:08 -06:00
Richard Hughes
cd35e3c242
trivial: Fix a compile warning when doing a unifying control transfer
2017-01-10 22:10:50 +00:00
Richard Hughes
04ec912b19
trivial: Fix some colorhug function name prefixes
2017-01-10 22:10:50 +00:00
Richard Hughes
b5574b463e
trivial: Fix example spec file
2017-01-10 22:10:50 +00:00
Richard Hughes
932eb397d2
trivial: Fix 'make distcheck'
2017-01-10 22:10:50 +00:00
Mario Limonciello
592ab30b3c
trivial: dell: update_prepare/update_cleanup on only certain plugins
2017-01-10 15:39:25 -06:00
Richard Hughes
23b9c9d78d
trivial: Use the per-plugin cache for the runtime device
...
There is no point having two hash tables doing the same thing...
2017-01-10 16:09:38 +00:00
Richard Hughes
57d18229a1
trivial: Add some more documentation for functions used by plugins
2017-01-10 16:09:32 +00:00
Richard Hughes
4190178f94
trivial: Remove the unused fu_plugin_set_name()
2017-01-10 16:09:32 +00:00