Richard Hughes
f592b06722
dell: Fix the last of the memory leaks in the self tests
...
Fixes: https://github.com/hughsie/fwupd/issues/158
2017-07-24 10:55:03 +01:00
Richard Hughes
4bfcae2921
trivial: Fix a tiny leak in the Dell plugin
2017-07-24 10:51:29 +01:00
Mario Limonciello
5f6a574fd7
fix some more memory leaks in dell plugin ( #158 )
2017-07-21 13:17:47 -05:00
Richard Hughes
3cca1c65c2
trivial: Remove or downgrade some superfluous warnings
...
Fixes bugs like https://github.com/hughsie/fwupd/issues/159
2017-07-21 13:38:27 +01:00
Richard Hughes
061ad8c5e8
trivial: Make fu_dell_detect_dock() slightly more NULL-deref safe
2017-07-19 09:14:56 +01:00
Mario Limonciello
11ca8122c3
Revert "trivial: fix some more memory leaks in dell plugin ( #158 )"
...
This reverts commit 49aba8cd87
.
That was prematurely committed, my apologies.
2017-07-18 16:00:03 -05:00
Mario Limonciello
32899e5ff7
dell: use plugin hash table instead
2017-07-18 15:53:38 -05:00
Mario Limonciello
49aba8cd87
trivial: fix some more memory leaks in dell plugin ( #158 )
2017-07-18 15:53:38 -05:00
Mario Limonciello
d817c53697
Correct a memory leak in Dell plugin ( Fixes #158 )
2017-07-18 10:35:21 -05:00
Mario Limonciello
c29b398ad0
trivial: fix various spelling errors
2017-07-17 13:07:05 -05:00
Mario Limonciello
e68b118044
uefi: test for kernel support during coldplug
...
The kernel offers two interfaces for manipulation of EFI variables.
Make sure that at least one of these is available.
If another interface is added (and supported by efivar) then this
list will need to be appended as well.
This was raised as a potential problem in #100 .
2017-07-10 14:11:22 -05:00
Mario Limonciello
c7e5322454
dell, uefi: Display all errors recorded by efi_error tracing, not just the first one
2017-07-10 14:11:10 -05:00
Richard Hughes
c633edc773
unifying: Don't log a warning when an unknown report is parsed
...
Fixes: https://github.com/hughsie/fwupd/issues/151
2017-07-07 13:42:45 +01:00
Mario Limonciello
8cb067d528
trivial: uefi: whitespace
2017-07-06 12:39:33 -05:00
Mario Limonciello
f043f1f94b
uefi: record boot variables to system log during updates ( #152 )
...
This doesn't strictly resolve the encountered issue, but
it will aide in debugging these types of issues in the future.
2017-07-06 12:37:10 -05:00
Richard Hughes
79acb58c7e
uefi: Fix crash when the product name is NULL
...
...bad things happen when you try to free a const char...
2017-07-06 18:27:01 +01:00
Mario Limonciello
c1a4bd469d
uefi,dell: make error messages from installing capsules useful
...
Before:
$ fwupdmgr install XPS_test.cab
Retrying as an offline update...
Scheduling… UEFI firmware update failed: -1
After:
$ fwupdmgr install XPS_test.cab
Retrying as an offline update...
Scheduling… UEFI firmware update failed: libfwup.c:733 get_paths(): could not find shim or fwup on ESP: No such file or directory
2017-07-06 11:38:33 -05:00
Mario Limonciello
be3a994922
Display UEFI firmware type
...
This will be more important as devices include more than
one entry in the ESRT.
2017-07-05 17:16:18 -05:00
Richard Hughes
822e134e94
unifying: Split up the HID++2.0 and HID++1.0 functionality
2017-07-04 13:19:09 +01:00
Richard Hughes
2a247e85e3
unifying: Allow flashing in bootloader modes
2017-07-03 20:17:50 +01:00
Richard Hughes
07bdf87b86
trivial: Add defines for the 'very-long' register read/write
2017-07-03 20:17:43 +01:00
Richard Hughes
b1af7496b1
unifying: Show the hardware version when the hardware provides this
2017-06-28 14:19:11 +01:00
Richard Hughes
55e6d9a74f
unifying: Only add the feature Root on HID++2.0 devices
2017-06-28 14:18:56 +01:00
Richard Hughes
42b6439892
unifying: Switch to a floating point HID++ version
2017-06-28 14:17:30 +01:00
Richard Hughes
2c1bd0236c
unifying: Only call HID++2.0 features on version 2+ devices
...
Also, ignore HID++1.0 replies from HID++2.0 devices and use the correct
function ID for getDfuStatus to avoid an error.
2017-06-28 12:10:02 +01:00
Richard Hughes
e97c5eb013
unifying: Manually set the HID++ version for runtime devices
2017-06-28 12:09:51 +01:00
Richard Hughes
653119fef8
unifying: Use a longer timeout for some operations
2017-06-28 12:09:51 +01:00
Richard Hughes
22dc937184
unifying: Use __attribute__((packed)) for structs sent to the hardware
2017-06-28 12:09:51 +01:00
Richard Hughes
f21cda4fed
unifying: Clear the feature map when a device is reprobed
2017-06-28 12:09:51 +01:00
Richard Hughes
695d01ed93
unifying: Keep the devices open, closing in finalize
2017-06-28 12:09:51 +01:00
Richard Hughes
c3b5b24287
unifying: Fix a confusing debug message
2017-06-28 12:05:32 +01:00
Richard Hughes
ae15bc2649
unifying: Filter by SwId when making HID++2.0 requests
...
Using the default value of '0' is what the kernel is using (related, libratbag
is using 0x08) and makes hotplug unreliable.
2017-06-28 12:05:32 +01:00
Richard Hughes
668f91419d
unifying: Allow large HID++ version numbers
...
Apparently, '4.3' is a perfectly valid version number.
2017-06-28 12:05:32 +01:00
Richard Hughes
f1399580b5
unifying: Do not allow closing a non-open device
2017-06-28 12:05:32 +01:00
Richard Hughes
38451999ff
unifying: Actually enforce the device_id checks
2017-06-28 12:05:32 +01:00
Richard Hughes
8884676c5d
unifying: Ping before trying to get the feature indexes
...
This reduces log spew for disconnected-but-paired devices.
2017-06-28 12:05:32 +01:00
Richard Hughes
45e3a03d15
trivial: Make a debug message less alarming
2017-06-28 12:05:32 +01:00
Richard Hughes
72975f0077
unifying: Only mark the device as active once the probe has completed
2017-06-24 07:40:38 +01:00
Richard Hughes
765c679498
unifying: Only detach the device if required
2017-06-24 07:24:15 +01:00
Richard Hughes
ed34991bd8
Do not unlock devices when doing VerifyUpdate
...
We used to do this dance to avoid reading the Option ROM on hardware by default
(some faulty hardware would crash...) but now we're doing the verify update in
the daemon there's no need to split this into two steps.
Fixes: https://github.com/hughsie/fwupd/issues/149
2017-06-22 10:37:10 +01:00
Richard Hughes
3045d1ca3f
unifying: Do not poll when we're waiting for device replug
...
If we happen to poll when the device is in the *process* of closing then the
open() fails in a weird way. If we're flashing it's probably a good idea to not
be too clever anyway...
2017-06-22 09:38:10 +01:00
Richard Hughes
7048044156
trivial: Fix up an error message in the unifying code
2017-06-22 09:38:10 +01:00
Richard Hughes
a42dae927c
unifying: Wait for device to re-appear in runtime after attaching
...
This ensures we can flash multiple versions of firmware without an artificial
delay. Also raise the timeout to cope with chains of slow hubs.
2017-06-22 09:37:48 +01:00
Richard Hughes
97fd762b47
unifying: Never allow the USB plugin to claim devices
2017-06-22 09:36:32 +01:00
Richard Hughes
0be13c038a
unifying: Allow a response from CMD_REBOOT
...
It's a race afterall, so some hardware is faster than others...
2017-06-22 09:36:32 +01:00
Mario Limonciello
f3f4390155
Only use the test runner plugin when CI is set in the env ( #148 )
...
This prevents an installed system from showing FakeDevices but
still allows exercising every commit with Travis CI
2017-06-20 13:56:13 -05:00
Richard Hughes
166d42cada
amt: Fix up a small memory leak and remove some goto's
2017-06-19 20:19:32 +01:00
Richard Hughes
9b59676a24
Add a plugin to get the version of the AMT ME interface
2017-06-19 14:01:47 +01:00
Richard Hughes
b53ad36012
trivial: Fix up a number of FALSE/NULL return issues
2017-06-19 13:50:42 +01:00
Richard Hughes
4a2e915e9a
unifying: Use the UFY DeviceID prefix as the PID is not 'USB PIDs' at all.
...
Resolves: https://github.com/hughsie/fwupd/issues/144
2017-06-16 16:45:42 +01:00