Commit Graph

8053 Commits

Author SHA1 Message Date
Mario Limonciello
34dfa86896 trivial: restore libcurl support in snap (Fixes: #5069) 2022-09-22 13:11:42 -05:00
Mario Limonciello
5c284e911a trivial: debian: drop unused lintian override 2022-09-22 11:43:01 -05:00
Mario Limonciello
24a4b322fd trivial: debian: Don't invoke systemd directly for fwupd.postinst 2022-09-22 11:43:01 -05:00
Mario Limonciello
70d34a2fe2 trivial: debian/control: Add explicit depends on adduser
W: fwupd: maintainer-script-needs-depends-on-adduser adduser (does not satisfy adduser) [postinst:91]
2022-09-22 11:43:01 -05:00
Mario Limonciello
8586e25177 trivial: debian: Add symlinks for devhelp to work
Fixes https://www.mit.edu/afs.new/sipb/project/debathena/lintian/www/tags/package-contains-devhelp-file-without-symlink.html
2022-09-22 11:43:01 -05:00
Richard Hughes
c6fde9e085 trivial: Install the host-emulate.d tests in the test package
This fixes the ppc64 Fedora build, as tests are disabled on that arch.
2022-09-22 17:31:42 +01:00
Richard Hughes
5fbc21a535 trivial: Fix the example spec file on i686 2022-09-22 17:31:42 +01:00
Richard Hughes
ec493527c3 trivial: Fix the Pre-boot DMA protection HSI long description
The original string is ambiguous to translate and logically incorrect.
2022-09-22 16:54:26 +01:00
Richard Hughes
49af1667bd trivial: Install the devhelp symlinks relative
We want /usr/share/docs/fwupd/libfwupd for the docs that can be referenced from
index.html, and a symlink of /usr/share/docs/libfwupd for devhelp.

This fixes the rpmbuild warning:

    # absolute symlink: /usr/share/doc/fwupd/libfwupd -> /usr/share/doc/libfwupd
    # absolute symlink: /usr/share/doc/fwupd/libfwupdplugin -> /usr/share/doc/libfwupdplugin
2022-09-22 16:24:56 +01:00
Richard Hughes
713bf04673 trivial: post release version bump 2022-09-22 15:01:15 +01:00
Richard Hughes
456dcb6a68 Release fwupd 1.8.5 2022-09-22 14:58:08 +01:00
Richard Hughes
c73a55faa1 Remove a potential foot-gun when saving config values
If a specific plugin calls fu_plugin_set_secure_config_value() and then
fu_plugin_set_config_value() then we'll save the file with the world-readable
permissions.

Set a plugin flag to say that 'this plugin is storing sensitive details' which
allows us to use the same entrypoint and also fix up any files at startup that
do not have the correct permissions.
2022-09-22 14:47:12 +01:00
Richard Hughes
ea676855f2 Never save the Redfish passwords to a file readable by users
When the redfish plugin automatically creates an OPERATOR user account on the
BMC we save the autogenerated password to /etc/fwupd/redfish.conf, ensuring it
is chmod'ed to 0660 before writing the file with g_key_file_save_to_file().

Under the covers, g_key_file_save_to_file() calls g_file_set_contents() with
the keyfile string data.
I was under the impression that G_FILE_CREATE_REPLACE_DESTINATION was being
used to copy permissions, but alas not.

GLib instead calls g_file_set_contents_full() with the mode hardcoded to 0666,
which undoes the previous chmod().

Use g_file_set_contents_full() with the correct mode for newer GLib versions,
and provide a fallback with the same semantics for older versions.
2022-09-22 14:46:44 +01:00
Richard Hughes
be2311c6c3 trivial: Fix gtk-doc markup issue 2022-09-22 14:34:10 +01:00
Richard Hughes
5d38e0aeea Move the getting the ESP to the context
We now have two plugins getting the ESP values, and we only allow hardcoding
the ESP in uefi_capsule.conf.

Make all this a lot simpler by moving the ESP+BDP code to `FuContext`, which
also means we can handle the override (via the config file) in the engine,
and the override (in the command line tools) using the same mechanism.

Also, automate the migration of the `OverrideESPMountPoint` -> `EspLocation`
when loading the engine.

Fixes https://github.com/fwupd/fwupd/issues/5042
2022-09-22 14:31:06 +01:00
Richard Hughes
1c27131fc6 trivial: Style nit
Co-authored-by: Mario Limonciello <mario.limonciello@amd.com>
2022-09-22 14:24:50 +01:00
Richard Hughes
f60af523e3 trivial: Don't print NULL in GError strings
PVS: Incorrect format: A null pointer is used.
2022-09-22 14:24:50 +01:00
Richard Hughes
d4c589cc04 trivial: Fix -Wunused-variable warning 2022-09-22 14:24:50 +01:00
Richard Hughes
2d2bde2268 trivial: Fix -Wunused-but-set-variable warning 2022-09-22 14:24:50 +01:00
Richard Hughes
b71968d348 trivial: Fix -Wunused-but-set-variable warning 2022-09-22 14:24:50 +01:00
Richard Hughes
7fd8aa6a38 Ignore missing NUL when parsing DS20 quirk data 2022-09-22 14:23:20 +01:00
Victor Cheng
ae74625721 usi-dock: Add initialization retry to ensure flash ready 2022-09-22 13:50:32 +01:00
SonixLeo
2c515f9a7b update the Quirk specifications for our Sonix CAM products 2022-09-22 10:34:43 +01:00
Richard Hughes
2fb81a6482 redfish: Only create users using IPMI when we know it's going to work
Make the IPMI auto-account feature allow-listed on specific vendors as some IPMI
implementations are not specification compliant and do entirely the wrong thing.
2022-09-21 14:22:35 +01:00
Richard Hughes
096364199b trivial: Fix self tests when using -Dgresource_quirks=enabled
We want to also skip the compiled-in GResource quirks if loading the context
with _NO_CACHE.
2022-09-21 12:59:44 +01:00
Richard Hughes
64cf323e57 wacom-raw: Fix maximum szie for AES panels
The latest AES panel G14T is expanded to 0x4000.
2022-09-21 07:29:33 +01:00
Richard Hughes
28fc1a5130 wacom-raw: Correctly finalize Wacom AES devices
The attach behaviour is not common between AES and EMR panels.
2022-09-21 07:29:33 +01:00
Alex
df35215171 Update create_containers.yml
Give packages permission to fix the runner
2022-09-20 11:59:41 -05:00
Alex
76ca69006f Update create_containers.yml
Fix for docker/build-push-action
2022-09-20 10:39:41 -05:00
Alex
86a99e9e45 build: harden create_containers.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-20 10:39:41 -05:00
Khem Raj
e9964a0f96 trivial: Fix compile when using python 3.7 or older
Signed-off-by: Richard Hughes <richard@hughsie.com>
2022-09-20 16:05:13 +01:00
Richard Hughes
9df226ca08 Revert "build: harden create_containers.yml permissions"
This reverts commit 34bc417abf.
2022-09-20 15:17:52 +01:00
Alex
34bc417abf build: harden create_containers.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-20 15:02:34 +01:00
Alex
c76551f381 build: harden main.yml permissions
Signed-off-by: Alex <aleksandrosansan@gmail.com>
2022-09-20 15:02:34 +01:00
Richard Hughes
c0b8673faa dbx: Do not show the 'connected devices may not be usable while updating' message 2022-09-20 12:55:00 +01:00
Richard Hughes
b34dc9c1f1 redfish: Set the permissions of redfish.conf at install time
Although typically we set the password using fu_plugin_set_secure_config_value()
or something like Ansible or Puppet -- the user could just edit the file with
vim and we still want the permissions set correctly.
2022-09-20 12:33:03 +01:00
Richard Hughes
0d60fa319f trivial: Fix two gi-docgen issues 2022-09-20 10:16:55 +01:00
Mario Limonciello
fe5d93f7d2 trivial: wait for network to be online to run fwupd-refresh.service 2022-09-19 14:52:42 -05:00
Mario Limonciello
8a90d9bed4 trivial: Add RELEASE steps for flatpak and snap
These are both requiring manual steps now, so document them in the
release process.
2022-09-19 14:32:57 -05:00
Mario Limonciello
8bb10ffaa7 Update the snap build
Use core22 and subsume a bunch of dependencies that can come from the
Ubuntu archive now during build instead.

This doesn't restore the CI functionality yet, but it at least builds
locally for me OK.
2022-09-19 13:33:54 -05:00
Mario Limonciello
4e130ea003 trivial: disable void ci for now 2022-09-19 13:33:54 -05:00
Mario Limonciello
e8ca440bad Add new plugin to display SMU firmware version on AMD APU/CPU
This plugin is read-only, but can be used to tell what version of
SMU firmware is installed.
2022-09-19 06:51:27 -05:00
Richard Hughes
aba96e4a4a pixart-rf: Fix the endianness of the magic
This was probably broken in 0c51630991

Mea culpa.
2022-09-18 12:40:33 +01:00
Richard Hughes
b4f2d10562 trivial: Add some links to the BDP and ESP defines 2022-09-17 13:43:22 +01:00
Richard Hughes
e72ed08b56 Always check the BDP partitions when getting all the possible ESPs
Fixes https://github.com/fwupd/fwupd/issues/5035
2022-09-17 13:41:36 +01:00
Richard Hughes
48beb87faf Copy backend tags to the GUsbDevice when possible.
This allows the backend to identify the specific device for a specific phase.

For instance, there might be a pre-update runtime, a bootloader and a
post-update runtime and allowing tags to be saved to the backend object allows
us to identify each version of the same physical device.

This takes us one step closer to emulating a complete byte-perfect end-to-end
update without actual hardware installed.
2022-09-14 16:54:55 +01:00
Richard Hughes
139188a5b0 Allow adding backend tags to devices
This allows the backend to identify the specific device for a specific phase.

For instance, there might be a pre-update runtime, a bootloader and a
post-update runtime and allowing tags to be saved to the backend object allows
us to identify each version of the same physical device.

This takes us one step closer to emulating a complete byte-perfect end-to-end
update without actual hardware installed.
2022-09-14 16:54:55 +01:00
Mario Limonciello
6ce4244edd trivial: fix reading the microcode version on AMD systems
The kernel will issue a CPUID of 0x1 before reading microcode.
Align this behavior with the MSR plugin.

AMD and Intel align their microcode diffrently in MSR 0x8b.
* Intel it's 4 bytes in.
* AMD it's at the start of the MSR.
2022-09-13 11:10:45 -05:00
Mario Limonciello
fbe9c6444e trivial: fu-util-common: RO devices w/ FW versions are interesting
Sometimes even if fwupd can't upgrade these devices they're
interesting to end users because they may show information that
can otherwise only be obtained by tearing apart firmware or
using extra arguments.

Amend the default behavior to let these show up.
2022-09-13 09:57:29 -05:00
Richard Hughes
891bae783c Show the USB4 NVM device ID in the debug output
Otherwise there's no way to find out what value the big-table-of-data needs.
2022-09-13 14:25:15 +01:00