Commit Graph

9633 Commits

Author SHA1 Message Date
Richard Hughes
d1bf305d79 trivial: Use g_string_replace() from GLib when available 2023-02-23 13:04:11 -06:00
Richard Hughes
e5cb6dc653 Fix SMBIOS struct parsing when there are three NULs in a row
We need to be careful detecting the end of a string section when the struct
ends with NUL NUL NUL.

Fixes https://github.com/fwupd/fwupd/issues/5509
2023-02-23 13:04:11 -06:00
Valentin David
c17935acf7 snap: allow fwupdmgr to shutdown
When installing a capsule, optional reboot is done by fwupdmgr instead
of fwupd. This means fwupdmgr needs the permission to do that.
2023-02-23 13:04:11 -06:00
Richard Hughes
8aef37fd57 cros-ec: Fix an uninitialized buffer warning from valgrind 2023-02-23 13:04:11 -06:00
Richard Hughes
8e25ec00e2 analogix: Do not check the endpoints before selecting an interface
My Analogix USB device has a Billboard interface, with bNumEndpoints=0.

When emulating the interface is NULL, and in runtime the array can *never* be
NULL, so I think this check was added in error.
2023-02-23 13:04:11 -06:00
Richard Hughes
2b60028a97 ti-tps6598x: Fix a small memory leak when flashing new firmware 2023-02-23 13:04:11 -06:00
Richard Hughes
d064cc740e wacom-usb: Use the device proxy functionality
The wacom-usb plugin was created in a simpler time, before we had the concept
of `FuDevice.proxy`. Switch to the shared code to modernize the code, and also
because setting the proxy conveys other semantics that we need to emulate the
device successfully in the future.
2023-02-23 13:04:11 -06:00
Richard Hughes
7a2207fb28 trivial: Remove the now-unused FWUPD_WAC_EMULATE check 2023-02-23 13:04:11 -06:00
Richard Hughes
63a2bd859f Ensure composite devices all share the same acquiesce delay
We go to great pains to set the parent to the MAX of the child delays, but we
don't actually set the children to have the new parent value.

This means if you update the child device without the parent in the transaction
we don't always wait for all the USB devices to come back -- which is what the
acquiesce delay is designed to do.

Fixes an intermittant device test for the Wacom USB tablet.
2023-02-23 13:04:11 -06:00
Richard Hughes
62c743008f trivial: Ignore device requests when emulated 2023-02-23 13:04:11 -06:00
Richard Hughes
e8e6908246 ccgx: Add support for the CalDigit Element Hub 2023-02-23 13:04:11 -06:00
Richard Hughes
1aac6646f0 ccgx: Detect factory mode and set a non-zero version
The Element Hub (and several other docks that use the CCGX5 DMC reference
design) is in "factory mode" out of the box, displaying a version of `0.0.0.0`

Detect factory mode and set a non-zero version -- using the "real" version if
possible by matching the CCG5 devx base firmware firmware.
2023-02-23 13:04:11 -06:00
Mario Limonciello
47f0732590 trivial: Disable the automatic snap stable promotion
The snap is converted into a confined version, but we need to make
sure that the snapd has promoted into a stable release so that fwupd
snap also works.

We should revert this after that happens.
2023-02-23 13:04:11 -06:00
Richard Hughes
be33aaaf94 Fix fwupdtool firmware-convert to work with image-less formats
Converting 'simple' non-nested formats like Intel Hex into nested formats like
DfuSe needs us to create a binary child firmware to avoid missing data.

Fixes https://github.com/fwupd/fwupd/issues/5493
2023-02-23 13:04:11 -06:00
Richard Hughes
2da924d8bc trivial: Do not return the internal libxmlb error back to the user 2023-02-23 13:04:11 -06:00
Richard Hughes
738f7d3f9b Print errors as JSON objects when using --json
For example:

	$ fwupdmgr local-install --json foo.zip
	{
	  "Error" : {
	    "Domain" : "FwupdError",
	    "Code" : 7,
	    "Message" : "failed to open foo.zip"
	  }
	}

Fixes https://github.com/fwupd/fwupd/issues/5499
2023-02-23 13:04:11 -06:00
Valentin David
37a28e5e1d snap: read the host os-release instead of base snap
This should fix #5485. Depends on https://github.com/snapcore/snapd/pull/12545
2023-02-23 13:04:11 -06:00
Richard Hughes
3a7fa73d0a Optimise getting the list of upgrades using the legacy API
We use GetReleases for all the *possible* releases that could be installed
(although the device might be in UPDATABLE_HIDDEN), and the legacy GetUpgrades
API just wants to know what can be done right now.
2023-02-23 13:04:11 -06:00
Richard Hughes
47f17cfe55 Speed up regenerating the MOTD
This is regenerated on every device hotplug event, and although infrequent
there is no point doing all that CPU-heavy requirement checking for no reason.
2023-02-23 13:04:11 -06:00
Richard Hughes
5374e5a379 wistron-dock: Use only-wait-for-replug to speed up device replug
Also, set the progress steps correctly.
2023-02-23 13:04:11 -06:00
Richard Hughes
7f50cffc2b wistron-dock: Fix critical warning during update 2023-02-23 13:04:11 -06:00
Richard Hughes
e2be6072e5 trivial: Only use clang-format on C source files 2023-02-23 13:04:11 -06:00
Richard Hughes
2fa46d3823 Add support for Quit() in fwupdmgr
This allows us to only shut down the P2P daemon in the installed tests.
The easy fix would have been to use something like:

    gdbus call --address unix:path=/run/fwupd.sock --object-path / --method org.freedesktop.fwupd.Quit'

...but the daemon does not implement an ObjectManager, which gdbus requires.

This worked correctly for so long because the p2p tests were being run after
the bus tests, so shutting down the system daemon had no effect.

Fedora 37 seems to have flipped the order for some reason -- and now it
*sometimes* matters that we were doing the worng thing...
2023-02-23 13:04:11 -06:00
Richard Hughes
ab65987a58 trivial: Fix Fedora CI when it cannot autostart udisks 2023-02-23 13:04:11 -06:00
Richard Hughes
f6d977c354 cros-ec: Clear the bulk transfer buffer to zero before using
This allow us to emulate the device as the buffer contents are now 100%
predictable and replayable.
2023-02-23 13:04:11 -06:00
Richard Hughes
6a75c28bfc trivial: Fix a tiny coverity-spotted memory leak on error 2023-02-23 13:04:11 -06:00
Richard Hughes
8f719cb6b0 Move the Fedora CI job to F37 2023-02-23 13:04:11 -06:00
Richard Hughes
a9dbbc99f7 Use the correct range check when parsing SMBIOS
The SMBIOS specification says:

    Maximum size of SMBIOS Structure Table, pointed to by the
    Structure Table Address, in bytes. The actual size is guaranteed
    to be less or equal to the maximum size.

So, the firmware is actually allowed to return a DMI blob smaller than the
specified size.

Fixes https://github.com/fwupd/fwupd/issues/5486
2023-02-23 13:04:11 -06:00
Richard Hughes
e3c660d203 nvme: Detect and warn users with the broken firmware 3B2QGXA7 2023-02-23 13:04:11 -06:00
Richard Hughes
a82070fe0d trivial: Fix fu-self-test with libgusb from the main branch 2023-02-23 13:04:11 -06:00
Richard Hughes
22be20498f trivial: Fix critical warning when loading an emulated DFU device 2023-02-23 13:04:11 -06:00
Richard Hughes
87e829471c Revert "trivial: Fix clang-format of JSON files for newer versions of clang"
This reverts commit 2eb4357a70.
2023-02-23 13:04:11 -06:00
Richard Hughes
76b47b15a6 trivial: Fix clang-format of JSON files for newer versions of clang
This explains why Mario and I had different precommit settings.
2023-02-23 13:04:11 -06:00
Richard Hughes
82b35eb208 ti-tps6598x: Ignore the 'wrong' USB device class before calling ->setup()
No functional change, but a few less i/o operations when inserting the dock.
2023-02-23 13:04:11 -06:00
Valentin David
e33d6757ff snap: Use common directory for vendor path 2023-02-23 13:04:11 -06:00
Valentin David
0830bfe2f0 snap: Use strict confinement 2023-02-23 13:04:11 -06:00
Valentin David
45babc583b snap: Fix a meson parameter 2023-02-23 13:04:11 -06:00
Valentin David
af5c5a7d51 snap: Remove some unused/redundant dependencies 2023-02-23 13:04:11 -06:00
Valentin David
4664ff4305 snap: Remove dconf 2023-02-23 13:04:11 -06:00
Valentin David
988a6db20e snap: Add missing libraries 2023-02-23 13:04:11 -06:00
Valentin David
25dfb547c3 Optionally disable Polkit check with an environment variable
When running in a confined snap, it is not possible to check whether a
policies have been installed.
2023-02-23 13:04:11 -06:00
Valentin David
ff8b3d26a4 Allow overriding lock directory with an environment variable 2023-02-23 13:04:11 -06:00
Richard Hughes
450d8a02d4 dfu: Use more const buffer data when writing to AVR chips 2023-02-23 13:04:11 -06:00
Richard Hughes
10ffedbe7d dfu: Clear the buffer before getting the status
This makes emulation of DFU devices work as the control transfer data is then
predictable.
2023-02-23 13:04:11 -06:00
Richard Hughes
35000cd93b trivial: Enable USB debugging when backend debugging is enabled 2023-02-23 13:04:11 -06:00
Richard Hughes
13af5989b2 trivial: Use new API in libgusb to better detect USB replug 2023-02-23 13:04:11 -06:00
Richard Hughes
090a7c8b9a Add API to wait for a device
This allows us to ignore all the delays when the device is emulated, with the
idea being to do dozens of device emulations in the CI tests.

Also, do not call fu_progress_sleep() when the device is emulated.
2023-02-23 13:04:11 -06:00
Richard Hughes
11c4636984 Do not invalidate the probe for emulated devices
If the device does not replug, and we change the GUsbDevice because the phase
changed we don't want reprobe the hardware.

If we reprobe then the emulated device will request extra data compared to the
real device, which will cause emulation to fail.
2023-02-23 13:04:11 -06:00
Richard Hughes
bd99bccb1f trivial: Require --force to overwrite files with 'fwupdmgr download' 2023-02-23 13:04:11 -06:00
Richard Hughes
c3f7048e4a Return an error when the pending db could not be updated 2023-02-23 13:04:11 -06:00