Jessica Clarke
646f23edd5
debian: Add quotes around glob
2020-11-16 08:06:48 -06:00
Jessica Clarke
99c37df81c
debian: Remove unnecessary ./ use
2020-11-16 08:06:48 -06:00
Jessica Clarke
f6b1ff0409
debian: Avoid looking like a set -e is missing
...
The exit code for an if is the final command's so single-command if
statements are safe. However, this is rather subtle and could easily be
accidentally overlooked when making future changes. We could add a set
-e to be defensive, but instead let's use the idiomatic way of doing
one-line if statements in shell that always yield the right exit code.
2020-11-16 08:06:48 -06:00
Jessica Clarke
e36ecb42ed
debian: Use uniform spacing around semicolons
2020-11-16 08:06:48 -06:00
Jessica Clarke
ae4ee910b9
debian: Fix another dangerous missing set -e
2020-11-16 08:06:48 -06:00
Jessica Clarke
f69931032e
debian: Build up CONFARGS list rather than individual variables
...
This avoids having a silly line length for the dh_auto_configure
invocation.
2020-11-16 08:06:48 -06:00
Jessica Clarke
227e281cf9
debian: Fix another instance of unusual ifeq syntax
2020-11-16 08:06:48 -06:00
Jessica Clarke
474e4135e8
debian: Fix dangerous lack of set -e
...
Also split the long line whilst here.
2020-11-16 08:06:48 -06:00
Jessica Clarke
8218923985
debian: Check for valgrind in Makefile not shell and don't hard-code path
2020-11-16 08:06:48 -06:00
Jessica Clarke
65b4f61110
debian: Drop pointless dh_shlibdeps override
...
There's no other mention of DHSLIBS in the entire tree so it'll always
be empty.
2020-11-16 08:06:48 -06:00
Jessica Clarke
4b2d77bbe9
debian: Use if/else rather than overriding default values
...
This makes the code easier to follow.
Whilst here use DEB_HOST_ARCH_CPU for the ia64 and use the more
conventional syntax.
2020-11-16 08:06:48 -06:00
Jessica Clarke
43d7c50609
debian: Prefer Makefile substitution over shell substitution
...
This makes the output show what is being run and avoids ugly multi-line
shell commands. It also avoids needlessly polluting the environment.
2020-11-16 08:06:48 -06:00
Jessica Clarke
de55495d95
debian: Check DEB_HOST_ARCH_CPU not DEB_HOST_ARCH for MSR plugin
...
The plugin is CPU-dependent, not kernel, ABI or libc dependent.
This makes x32 build the plugin again.
2020-11-16 08:06:48 -06:00
Emily Miller
937f7401c0
trivial: Add vli tr_gen2 and hyper regression test
2020-11-16 09:28:46 +00:00
Emily Miller
1c4a4dd29c
trivial: tr_gen2 has same rtd21xx as mini dock
2020-11-16 08:50:25 +00:00
Richard Hughes
05efd7b960
trivial: Don't assume a specific page size in the unit tests
...
This was found in the self tests on PPC64.
Fixes https://github.com/fwupd/fwupd/issues/2581
2020-11-15 09:17:08 +00:00
Richard Hughes
b5eddee5f6
bcm57xx: Use PCI function 1 as 0 does not work with the Dell KH08P
2020-11-14 07:56:32 +00:00
Mario Limonciello
e6154b3425
trivial: debian: disable msr plugin on all !x86
...
Fixes build failure on arm64 and armhf
2020-11-14 00:00:11 -06:00
Mario Limonciello
80212a3d0b
trivial: debian: don't hardcode paths in libexec
...
Some architectures won't have `fwupd-detect-cet` and this causes
build failures for those architectures
Fixes build failures on:
ppc64, risvc64, sparc64, powerpc, m68k, ia64, hppa, alpha, s390x,
mipsel, mips64el, armel
2020-11-14 00:00:11 -06:00
Richard Hughes
122104e190
vli: Do not be clever replugging the MSP430 device
...
We don't have to do this since we started counting the composite devices out
and back in, and relying on the parent being set at a specific instance seems
fragile in real-world testing.
2020-11-13 14:22:51 -06:00
Richard Hughes
bcf7a446f6
vli: Make some trivial debugging more specific to help debug an issue
2020-11-13 14:22:51 -06:00
Richard Hughes
d483fcedd5
trivial: Fix a logic thinko to unbreak switch-branch
...
We still want to return TRUE, rather than falling through as if the requirement
type was unknown.
Fixes https://github.com/fwupd/fwupd/issues/2578
2020-11-13 16:21:57 +00:00
Mario Limonciello
fca9a74de0
make gcab optional
2020-11-13 06:17:47 -06:00
Mario Limonciello
90e80e6752
trivial: allow building as a subproject
2020-11-13 06:17:47 -06:00
Mario Limonciello
bdaa080be3
trivial: disable bios plugin outside of systems with uefi
...
Fixes : #2576
2020-11-13 08:19:30 +00:00
Mario Limonciello
56d816a53b
Fall back to FAT32 internal partitions for detecting ESP
...
Fixes #2576
2020-11-12 13:42:21 -06:00
Mario Limonciello
bd60de12be
Add a flag to indicate if packages are supported
...
Anyone can easily add this, but it makes it clearer that by default hand
build, snap, and flatpak are not checked by anyone.
2020-11-11 14:34:59 -06:00
Hsieh-Tseng Shen
b47eee9a8a
uefi: a new option for uefi configuration to use UEFI removable path
...
Per discussion of #2513 , Ubuntu Core was going to use UEFI removable
path as default esp path, and it needs to change some parts around
getting the esp path and searching the shim app path. Also, a new option
"FallbacktoRemovablePath" is added into uefi.conf to be applied in this
case, and it will be false by default.
2020-11-11 13:04:46 -06:00
Mario Limonciello
cceeb75c7b
Add a section to man page on scripting
...
Fixes : #2572
2020-11-11 12:50:13 -06:00
Richard Hughes
e29294d7f2
trivial: Add systemd-devel to fwupd BRs
2020-11-10 20:35:55 +00:00
Richard Hughes
d87edbcc51
trivial: Fix swap self tests
...
This only works if the computer used to run the test also has /dev/nvme0n1p4 as
encrypted swap...
2020-11-10 19:55:33 +00:00
Richard Hughes
eac6edd7c5
synaptics-mst: Improve reliability by waiting 2 seconds after writing data
...
On failure, you get this:
no device found on drm_dp_aux5: Memory query failed: failed to write command
failed to get device after update: failed to wait for detach replug
2020-11-10 13:13:48 +00:00
Mario Limonciello
db15442c7c
trivial: installed-tests: skip tests requiring network by default
...
Most of the installed tests will skip if files needed to be fetched
from network are not available. Do the same thing for fwupdmgr
tests.
Fixes : #2566
2020-11-09 15:11:30 -06:00
Richard Hughes
db4894e863
hailuck: Add an plugin for the Pinebook Pro laptop
...
This is not complete enough for LVFS-usage, but good enough to use with commands
such as fwupdtool. It's likely newer kbd and tp firmware will be required to
integrate with the fwupd in all required ways.
2020-11-09 16:17:34 +00:00
Richard Hughes
fa11ceae9c
trivial: Use the Mini Dock example archives provided by VLI
2020-11-09 09:57:13 +00:00
Richard Hughes
1b6d5e5085
trivial: Ignore failure to close USB device for a missing device
2020-11-07 19:51:45 +00:00
Richard Hughes
b4f8a5dc83
trivial: Ignore failure to release HID interface with a missing device
2020-11-07 19:51:45 +00:00
Richard Hughes
8c415e0568
trivia: Allow controlling HID kernel driver rebind
2020-11-07 19:51:45 +00:00
Richard Hughes
7bb9b1f6e8
trivial: Improve the debugging output for FU_HID_DEVICE_VERBOSE
2020-11-07 19:51:45 +00:00
Richard Hughes
a01fdde628
Allow setting global flags for FuHidDevice
2020-11-07 19:51:45 +00:00
Jan Tojnar
a8b3f9ed57
trivial: fu-engine: skip empty cmdline commands
...
g_strsplit returns an empty vector for an empty string,
which leads to assertion in g_strv_contains when /proc/cmdline
ends with a space.
2020-11-07 19:51:07 +00:00
Richard Hughes
01ba0c1eea
Set the SMBIOS chassis type to portable if a DT battery exists
...
This allows getting the HSI result on a Pinebook Pro laptop.
2020-11-07 08:15:20 +00:00
Richard Hughes
42a5b39385
colorhug: Don't set the version format to triplet at startup
...
The USB revision is BCD if there's no 'FW' vendor data in the descriptor, so
only set the format when we know.
2020-11-07 08:03:24 +00:00
Richard Hughes
4d781ae14f
Revert "If incorporating the version from a subclass, also set the verfmt too"
...
This reverts commit c0dee27b6d
.
2020-11-07 07:57:50 +00:00
Richard Hughes
3e445ece04
Allow components to set the icon from the metadata
...
In this case, we want to set the generic ESRT entry to have the icon 'battery'.
2020-11-06 16:57:21 +00:00
Richard Hughes
11832e10af
trivial: Fix a warning when generating the GtkDoc pages
2020-11-06 13:18:25 +00:00
Richard Hughes
1d0e7fb3bf
colorhug: Fix detection of version on older firmware versions
...
Without the 'FW' version hint in newer firmware versions we fall back to the
BCD USB release which we need to override to triplet.
2020-11-06 13:04:34 +00:00
Richard Hughes
c0dee27b6d
If incorporating the version from a subclass, also set the verfmt too
...
Otherwise we could be left with a device that sets the expected verfmt in the
plugin _init(), but would not be inherited from the subclass. It would have:
Version: 0.2
VersionFormat: triplet
...which makes no sense.
2020-11-06 13:04:34 +00:00
Richard Hughes
0658ae184b
trivial: Remove traces of the UA HSI suffixes
2020-11-06 09:57:03 +00:00
Richard Hughes
e0f9207d3b
trivial: Fix two introspection warnings
2020-11-06 09:57:03 +00:00