From fdfdaed9110af81d2516971972fb61bfa4f1045c Mon Sep 17 00:00:00 2001 From: Mario Limonciello Date: Fri, 5 Aug 2022 14:39:12 -0500 Subject: [PATCH] trivial: bios-attrs: fix a logic bug in lenovo string extraction Several enumeration attributes were missing their final values --- libfwupdplugin/fu-bios-attrs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libfwupdplugin/fu-bios-attrs.c b/libfwupdplugin/fu-bios-attrs.c index 1c59a253a..3ce2109f3 100644 --- a/libfwupdplugin/fu-bios-attrs.c +++ b/libfwupdplugin/fu-bios-attrs.c @@ -205,8 +205,8 @@ fu_bios_attr_fixup_lenovo_thinklmi_bug(FwupdBiosAttr *attr, GError **error) /* last string */ if (possible_vals[i + 1] == NULL && g_strrstr(possible_vals[i], "]") != NULL) { - g_auto(GStrv) stripped_vals = fu_strsplit(possible_vals[1], - strlen(possible_vals[1]), + g_auto(GStrv) stripped_vals = fu_strsplit(possible_vals[i], + strlen(possible_vals[i]), "]", -1); fwupd_bios_attr_add_possible_value(attr, stripped_vals[0]);