From fbb6f7fd66cd75f125b84712aa9c5efabd7d360a Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Tue, 7 Feb 2023 19:12:06 +0000 Subject: [PATCH] Speed up regenerating the MOTD This is regenerated on every device hotplug event, and although infrequent there is no point doing all that CPU-heavy requirement checking for no reason. --- src/fu-engine-helper.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/fu-engine-helper.c b/src/fu-engine-helper.c index faf43eb71..0bfdcbe57 100644 --- a/src/fu-engine-helper.c +++ b/src/fu-engine-helper.c @@ -70,6 +70,8 @@ fu_engine_update_motd(FuEngine *self, GError **error) g_autoptr(GPtrArray) rels = NULL; /* get the releases for this device */ + if (!fu_device_has_flag(dev, FWUPD_DEVICE_FLAG_UPDATABLE)) + continue; rels = fu_engine_get_upgrades(self, request, fwupd_device_get_id(dev), NULL); if (rels == NULL) @@ -80,6 +82,8 @@ fu_engine_update_motd(FuEngine *self, GError **error) for (guint i = 0; i < devices->len; i++) { FwupdDevice *dev = g_ptr_array_index(devices, i); g_autoptr(FwupdRelease) rel = NULL; + if (!fu_device_has_flag(dev, FWUPD_DEVICE_FLAG_UPDATABLE)) + continue; rel = fu_engine_get_release_with_tag(self, request, dev,