diff --git a/libfwupdplugin/fu-i2c-device.c b/libfwupdplugin/fu-i2c-device.c index ec4188be9..5e62efbe2 100644 --- a/libfwupdplugin/fu-i2c-device.c +++ b/libfwupdplugin/fu-i2c-device.c @@ -118,10 +118,6 @@ fu_i2c_device_probe(FuDevice *device, GError **error) g_autoptr(GRegex) regex = NULL; #endif - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_i2c_device_parent_class)->probe(device, error)) - return FALSE; - /* set physical ID */ if (!fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "i2c", error)) return FALSE; diff --git a/plugins/analogix/fu-analogix-device.c b/plugins/analogix/fu-analogix-device.c index 68438820e..c620b9055 100644 --- a/plugins/analogix/fu-analogix-device.c +++ b/plugins/analogix/fu-analogix-device.c @@ -233,9 +233,6 @@ fu_analogix_device_find_interface(FuUsbDevice *device, GError **error) static gboolean fu_analogix_device_probe(FuDevice *device, GError **error) { - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_analogix_device_parent_class)->probe(device, error)) - return FALSE; if (!fu_analogix_device_find_interface(FU_USB_DEVICE(device), error)) { g_prefix_error(error, "failed to find update interface: "); return FALSE; diff --git a/plugins/ata/fu-ata-device.c b/plugins/ata/fu-ata-device.c index 4c5530bff..9d09f0d82 100644 --- a/plugins/ata/fu-ata-device.c +++ b/plugins/ata/fu-ata-device.c @@ -468,10 +468,6 @@ fu_ata_device_probe(FuDevice *device, GError **error) FuAtaDevice *self = FU_ATA_DEVICE(device); GUdevDevice *udev_device = fu_udev_device_get_dev(FU_UDEV_DEVICE(device)); - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_ata_device_parent_class)->probe(device, error)) - return FALSE; - /* check is valid */ if (g_strcmp0(g_udev_device_get_devtype(udev_device), "disk") != 0) { g_set_error(error, diff --git a/plugins/bcm57xx/fu-bcm57xx-device.c b/plugins/bcm57xx/fu-bcm57xx-device.c index dcaa1ab28..2deece35c 100644 --- a/plugins/bcm57xx/fu-bcm57xx-device.c +++ b/plugins/bcm57xx/fu-bcm57xx-device.c @@ -58,10 +58,6 @@ fu_bcm57xx_device_probe(FuDevice *device, GError **error) g_autofree gchar *fn = NULL; g_autoptr(GPtrArray) ifaces = NULL; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_bcm57xx_device_parent_class)->probe(device, error)) - return FALSE; - /* only enumerate number 0 */ if (fu_udev_device_get_number(FU_UDEV_DEVICE(device)) != 0) { g_set_error_literal(error, diff --git a/plugins/bcm57xx/fu-bcm57xx-recovery-device.c b/plugins/bcm57xx/fu-bcm57xx-recovery-device.c index 42c0ef255..18f9cf62c 100644 --- a/plugins/bcm57xx/fu-bcm57xx-recovery-device.c +++ b/plugins/bcm57xx/fu-bcm57xx-recovery-device.c @@ -878,9 +878,6 @@ fu_bcm57xx_recovery_device_init(FuBcm57xxRecoveryDevice *self) static gboolean fu_bcm57xx_recovery_device_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_bcm57xx_recovery_device_parent_class)->probe(device, error)) - return FALSE; return fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "pci", error); } diff --git a/plugins/colorhug/fu-colorhug-device.c b/plugins/colorhug/fu-colorhug-device.c index c3fdd487c..4908258f4 100644 --- a/plugins/colorhug/fu-colorhug-device.c +++ b/plugins/colorhug/fu-colorhug-device.c @@ -333,10 +333,6 @@ fu_colorhug_device_probe(FuDevice *device, GError **error) { FuColorhugDevice *self = FU_COLORHUG_DEVICE(device); - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_colorhug_device_parent_class)->probe(device, error)) - return FALSE; - /* compact memory layout */ if (fu_device_has_private_flag(device, FU_COLORHUG_DEVICE_FLAG_HALFSIZE)) self->start_addr = CH_EEPROM_ADDR_RUNCODE_ALS; diff --git a/plugins/cros-ec/fu-cros-ec-usb-device.c b/plugins/cros-ec/fu-cros-ec-usb-device.c index 1cee86f3a..249bb5a8d 100644 --- a/plugins/cros-ec/fu-cros-ec-usb-device.c +++ b/plugins/cros-ec/fu-cros-ec-usb-device.c @@ -154,10 +154,6 @@ fu_cros_ec_usb_device_probe(FuDevice *device, GError **error) { FuCrosEcUsbDevice *self = FU_CROS_EC_USB_DEVICE(device); - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_cros_ec_usb_device_parent_class)->probe(device, error)) - return FALSE; - /* very much like usb_updater2's usb_findit() */ if (!fu_cros_ec_usb_device_find_interface(FU_USB_DEVICE(device), error)) { diff --git a/plugins/dfu-csr/fu-dfu-csr-device.c b/plugins/dfu-csr/fu-dfu-csr-device.c index cf5339ae9..05d36362c 100644 --- a/plugins/dfu-csr/fu-dfu-csr-device.c +++ b/plugins/dfu-csr/fu-dfu-csr-device.c @@ -397,20 +397,6 @@ fu_dfu_csr_device_download(FuDevice *device, return fu_dfu_csr_device_download_chunk(self, idx, blob_empty, error); } -static gboolean -fu_dfu_csr_device_probe(FuDevice *device, GError **error) -{ - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_dfu_csr_device_parent_class)->probe(device, error)) - return FALSE; - - /* hardcoded */ - fu_device_add_flag(device, FWUPD_DEVICE_FLAG_UPDATABLE); - - /* success */ - return TRUE; -} - static gboolean fu_dfu_csr_device_setup(FuDevice *device, GError **error) { @@ -443,6 +429,7 @@ fu_dfu_csr_device_init(FuDfuCsrDevice *self) { fu_device_add_protocol(FU_DEVICE(self), "com.qualcomm.dfu"); fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_CAN_VERIFY_IMAGE); + fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_UPDATABLE); fu_device_add_internal_flag(FU_DEVICE(self), FU_DEVICE_INTERNAL_FLAG_REPLUG_MATCH_GUID); fu_device_set_firmware_gtype(FU_DEVICE(self), FU_TYPE_DFU_FIRMWARE); fu_device_register_private_flag(FU_DEVICE(self), @@ -459,6 +446,5 @@ fu_dfu_csr_device_class_init(FuDfuCsrDeviceClass *klass) klass_device->dump_firmware = fu_dfu_csr_device_upload; klass_device->attach = fu_dfu_csr_device_attach; klass_device->setup = fu_dfu_csr_device_setup; - klass_device->probe = fu_dfu_csr_device_probe; klass_device->set_progress = fu_dfu_csr_device_set_progress; } diff --git a/plugins/dfu/fu-dfu-device.c b/plugins/dfu/fu-dfu-device.c index f0f29b355..5f89c7233 100644 --- a/plugins/dfu/fu-dfu-device.c +++ b/plugins/dfu/fu-dfu-device.c @@ -1144,10 +1144,6 @@ fu_dfu_device_probe(FuDevice *device, GError **error) FuDfuDevice *self = FU_DFU_DEVICE(device); GUsbDevice *usb_device = fu_usb_device_get_dev(FU_USB_DEVICE(device)); - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_dfu_device_parent_class)->probe(device, error)) - return FALSE; - /* add all the targets */ if (!fu_dfu_device_add_targets(self, error)) { g_prefix_error(error, diff --git a/plugins/ebitdo/fu-ebitdo-device.c b/plugins/ebitdo/fu-ebitdo-device.c index e4bf7d044..181f33de2 100644 --- a/plugins/ebitdo/fu-ebitdo-device.c +++ b/plugins/ebitdo/fu-ebitdo-device.c @@ -631,10 +631,6 @@ fu_ebitdo_device_attach(FuDevice *device, FuProgress *progress, GError **error) static gboolean fu_ebitdo_device_probe(FuDevice *device, GError **error) { - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_ebitdo_device_parent_class)->probe(device, error)) - return FALSE; - /* allowed, but requires manual bootloader step */ fu_device_add_flag(device, FWUPD_DEVICE_FLAG_UPDATABLE); fu_device_set_remove_delay(device, FU_DEVICE_REMOVE_DELAY_USER_REPLUG); diff --git a/plugins/elantp/fu-elantp-hid-device.c b/plugins/elantp/fu-elantp-hid-device.c index 05cf7adcc..53c66e265 100644 --- a/plugins/elantp/fu-elantp-hid-device.c +++ b/plugins/elantp/fu-elantp-hid-device.c @@ -48,10 +48,6 @@ fu_elantp_hid_device_to_string(FuDevice *device, guint idt, GString *str) static gboolean fu_elantp_hid_device_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_elantp_hid_device_parent_class)->probe(device, error)) - return FALSE; - /* check is valid */ if (g_strcmp0(fu_udev_device_get_subsystem(FU_UDEV_DEVICE(device)), "hidraw") != 0) { g_set_error(error, diff --git a/plugins/elantp/fu-elantp-i2c-device.c b/plugins/elantp/fu-elantp-i2c-device.c index 009c418a0..828d79eaa 100644 --- a/plugins/elantp/fu-elantp-i2c-device.c +++ b/plugins/elantp/fu-elantp-i2c-device.c @@ -49,10 +49,6 @@ fu_elantp_i2c_device_to_string(FuDevice *device, guint idt, GString *str) static gboolean fu_elantp_i2c_device_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_elantp_i2c_device_parent_class)->probe(device, error)) - return FALSE; - /* check is valid */ if (g_strcmp0(fu_udev_device_get_subsystem(FU_UDEV_DEVICE(device)), "i2c-dev") != 0) { g_set_error(error, diff --git a/plugins/emmc/fu-emmc-device.c b/plugins/emmc/fu-emmc-device.c index 0f2f8d8c9..4b976bbbc 100644 --- a/plugins/emmc/fu-emmc-device.c +++ b/plugins/emmc/fu-emmc-device.c @@ -144,10 +144,6 @@ fu_emmc_device_probe(FuDevice *device, GError **error) g_autofree gchar *vendor_id = NULL; g_autoptr(GRegex) dev_regex = NULL; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_emmc_device_parent_class)->probe(device, error)) - return FALSE; - udev_parent = g_udev_device_get_parent_with_subsystem(udev_device, "mmc", NULL); if (udev_parent == NULL) { g_set_error_literal(error, FWUPD_ERROR, FWUPD_ERROR_NOT_SUPPORTED, "no MMC parent"); diff --git a/plugins/flashrom/fu-flashrom-device.c b/plugins/flashrom/fu-flashrom-device.c index ef6fa2f52..b144e5490 100644 --- a/plugins/flashrom/fu-flashrom-device.c +++ b/plugins/flashrom/fu-flashrom-device.c @@ -58,10 +58,6 @@ fu_flashrom_device_probe(FuDevice *device, GError **error) const gchar *dev_name = NULL; const gchar *sysfs_path = NULL; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_flashrom_device_parent_class)->probe(device, error)) - return FALSE; - sysfs_path = fu_udev_device_get_sysfs_path(FU_UDEV_DEVICE(device)); if (sysfs_path != NULL) { g_autofree gchar *physical_id = NULL; diff --git a/plugins/gpio/fu-gpio-device.c b/plugins/gpio/fu-gpio-device.c index 42fd7ef29..b8d65b7ef 100644 --- a/plugins/gpio/fu-gpio-device.c +++ b/plugins/gpio/fu-gpio-device.c @@ -33,10 +33,6 @@ fu_gpio_device_to_string(FuDevice *device, guint idt, GString *str) static gboolean fu_gpio_device_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_gpio_device_parent_class)->probe(device, error)) - return FALSE; - /* no device file */ if (fu_udev_device_get_device_file(FU_UDEV_DEVICE(device)) == NULL) { g_set_error_literal(error, diff --git a/plugins/hailuck/fu-hailuck-bl-device.c b/plugins/hailuck/fu-hailuck-bl-device.c index 2aa608b12..ed4179b6f 100644 --- a/plugins/hailuck/fu-hailuck-bl-device.c +++ b/plugins/hailuck/fu-hailuck-bl-device.c @@ -42,10 +42,6 @@ fu_hailuck_bl_device_attach(FuDevice *device, FuProgress *progress, GError **err static gboolean fu_hailuck_bl_device_probe(FuDevice *device, GError **error) { - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_hailuck_bl_device_parent_class)->probe(device, error)) - return FALSE; - /* add instance ID */ fu_device_add_instance_str(device, "MODE", "KBD"); return fu_device_build_instance_id(device, error, "USB", "VID", "PID", "MODE", NULL); diff --git a/plugins/hailuck/fu-hailuck-kbd-device.c b/plugins/hailuck/fu-hailuck-kbd-device.c index 3a477153b..dfda68813 100644 --- a/plugins/hailuck/fu-hailuck-kbd-device.c +++ b/plugins/hailuck/fu-hailuck-kbd-device.c @@ -37,10 +37,6 @@ fu_hailuck_kbd_device_probe(FuDevice *device, GError **error) { g_autoptr(FuHailuckTpDevice) tp_device = fu_hailuck_tp_device_new(FU_DEVICE(device)); - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_hailuck_kbd_device_parent_class)->probe(device, error)) - return FALSE; - /* add extra keyboard-specific GUID */ fu_device_add_instance_str(device, "MODE", "KBD"); if (!fu_device_build_instance_id(device, error, "USB", "VID", "PID", "MODE", NULL)) diff --git a/plugins/logitech-hidpp/fu-logitech-hidpp-device.c b/plugins/logitech-hidpp/fu-logitech-hidpp-device.c index 9f909bd29..1baf225f0 100644 --- a/plugins/logitech-hidpp/fu-logitech-hidpp-device.c +++ b/plugins/logitech-hidpp/fu-logitech-hidpp-device.c @@ -687,16 +687,6 @@ fu_logitech_hidpp_device_probe(FuDevice *device, GError **error) FuLogitechHidPpDevice *self = FU_HIDPP_DEVICE(device); FuLogitechHidPpDevicePrivate *priv = GET_PRIVATE(self); - /* - * FuUdevDevice->probe except for paired devices. We don't want - * paired devices to inherit the logical ids of the receiver. - */ - if (priv->device_idx == HIDPP_DEVICE_IDX_UNSET || - priv->device_idx == HIDPP_DEVICE_IDX_BLE) { - if (!FU_DEVICE_CLASS(fu_logitech_hidpp_device_parent_class)->probe(device, error)) - return FALSE; - } - /* set the physical ID */ if (!fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "hid", error)) return FALSE; diff --git a/plugins/logitech-hidpp/fu-logitech-hidpp-runtime.c b/plugins/logitech-hidpp/fu-logitech-hidpp-runtime.c index 2ed388d5d..617f094a8 100644 --- a/plugins/logitech-hidpp/fu-logitech-hidpp-runtime.c +++ b/plugins/logitech-hidpp/fu-logitech-hidpp-runtime.c @@ -178,10 +178,6 @@ fu_logitech_hidpp_runtime_probe(FuDevice *device, GError **error) g_autoptr(GUdevDevice) udev_parent = NULL; g_autoptr(GUdevDevice) udev_parent_usb_interface = NULL; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_logitech_hidpp_runtime_parent_class)->probe(device, error)) - return FALSE; - /* set the physical ID */ if (!fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "usb", error)) return FALSE; diff --git a/plugins/mtd/fu-mtd-device.c b/plugins/mtd/fu-mtd-device.c index 5d63a7be1..8d445bce0 100644 --- a/plugins/mtd/fu-mtd-device.c +++ b/plugins/mtd/fu-mtd-device.c @@ -113,10 +113,6 @@ fu_mtd_device_probe(FuDevice *device, GError **error) guint64 size = 0; g_autoptr(GError) error_local = NULL; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_mtd_device_parent_class)->probe(device, error)) - return FALSE; - /* set physical ID */ if (!fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "mtd", error)) return FALSE; diff --git a/plugins/nordic-hid/fu-nordic-hid-cfg-channel.c b/plugins/nordic-hid/fu-nordic-hid-cfg-channel.c index 829b87975..2856e2e42 100644 --- a/plugins/nordic-hid/fu-nordic-hid-cfg-channel.c +++ b/plugins/nordic-hid/fu-nordic-hid-cfg-channel.c @@ -930,10 +930,6 @@ fu_nordic_hid_cfg_channel_dfu_start(FuNordicHidCfgChannel *self, static gboolean fu_nordic_hid_cfg_channel_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_nordic_hid_cfg_channel_parent_class)->probe(device, error)) - return FALSE; - return fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "hid", error); } diff --git a/plugins/scsi/fu-scsi-device.c b/plugins/scsi/fu-scsi-device.c index f9d9f7886..b1a877cee 100644 --- a/plugins/scsi/fu-scsi-device.c +++ b/plugins/scsi/fu-scsi-device.c @@ -48,10 +48,6 @@ fu_scsi_device_probe(FuDevice *device, GError **error) g_autoptr(FuUdevDevice) ufshci_parent = NULL; const gchar *subsystem_parents[] = {"pci", "platform", NULL}; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_scsi_device_parent_class)->probe(device, error)) - return FALSE; - /* check is valid */ if (g_strcmp0(g_udev_device_get_devtype(udev_device), "disk") != 0) { g_set_error(error, diff --git a/plugins/steelseries/fu-steelseries-device.c b/plugins/steelseries/fu-steelseries-device.c index 93513663e..da702c3f4 100644 --- a/plugins/steelseries/fu-steelseries-device.c +++ b/plugins/steelseries/fu-steelseries-device.c @@ -110,10 +110,6 @@ fu_steelseries_device_probe(FuDevice *device, GError **error) g_autoptr(GPtrArray) ifaces = NULL; g_autoptr(GPtrArray) endpoints = NULL; - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_steelseries_device_parent_class)->probe(device, error)) - return FALSE; - ifaces = g_usb_device_get_interfaces(usb_device, error); if (ifaces == NULL) return FALSE; diff --git a/plugins/synaptics-rmi/fu-synaptics-rmi-hid-device.c b/plugins/synaptics-rmi/fu-synaptics-rmi-hid-device.c index 89a24f5fb..1ff6e3e9d 100644 --- a/plugins/synaptics-rmi/fu-synaptics-rmi-hid-device.c +++ b/plugins/synaptics-rmi/fu-synaptics-rmi-hid-device.c @@ -494,9 +494,6 @@ fu_synaptics_rmi_hid_device_set_page(FuSynapticsRmiDevice *self, guint8 page, GE static gboolean fu_synaptics_rmi_hid_device_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_synaptics_rmi_hid_device_parent_class)->probe(device, error)) - return FALSE; return fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "hid", error); } diff --git a/plugins/synaptics-rmi/fu-synaptics-rmi-ps2-device.c b/plugins/synaptics-rmi/fu-synaptics-rmi-ps2-device.c index 639bd6ff9..b5cdbd5eb 100644 --- a/plugins/synaptics-rmi/fu-synaptics-rmi-ps2-device.c +++ b/plugins/synaptics-rmi/fu-synaptics-rmi-ps2-device.c @@ -782,10 +782,6 @@ fu_synaptics_rmi_ps2_device_write_bus_select(FuSynapticsRmiDevice *rmi_device, static gboolean fu_synaptics_rmi_ps2_device_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_synaptics_rmi_ps2_device_parent_class)->probe(device, error)) - return FALSE; - /* psmouse is the usual mode, but serio is needed for update */ if (g_strcmp0(fu_udev_device_get_driver(FU_UDEV_DEVICE(device)), "serio_raw") == 0) { fu_device_add_flag(device, FWUPD_DEVICE_FLAG_IS_BOOTLOADER); diff --git a/plugins/thunderbolt/fu-thunderbolt-device.c b/plugins/thunderbolt/fu-thunderbolt-device.c index a8a73e258..14018755d 100644 --- a/plugins/thunderbolt/fu-thunderbolt-device.c +++ b/plugins/thunderbolt/fu-thunderbolt-device.c @@ -449,10 +449,6 @@ fu_thunderbolt_device_probe(FuDevice *device, GError **error) { g_autoptr(FuUdevDevice) udev_parent = NULL; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_thunderbolt_device_parent_class)->probe(device, error)) - return FALSE; - /* if the PCI ID is Intel then it's signed, no idea otherwise */ udev_parent = fu_udev_device_get_parent_with_subsystem(FU_UDEV_DEVICE(device), "pci"); if (udev_parent != NULL) { diff --git a/plugins/thunderbolt/fu-thunderbolt-retimer.c b/plugins/thunderbolt/fu-thunderbolt-retimer.c index d177a57e2..5c12aabe6 100644 --- a/plugins/thunderbolt/fu-thunderbolt-retimer.c +++ b/plugins/thunderbolt/fu-thunderbolt-retimer.c @@ -79,10 +79,6 @@ fu_thunderbolt_retimer_probe(FuDevice *device, GError **error) const gchar *devpath = fu_udev_device_get_sysfs_path(FU_UDEV_DEVICE(device)); g_autofree gchar *physical_id = g_path_get_basename(devpath); - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_thunderbolt_retimer_parent_class)->probe(device, error)) - return FALSE; - /* device */ if (physical_id != NULL) fu_device_set_physical_id(device, physical_id); diff --git a/plugins/tpm/fu-tpm-v1-device.c b/plugins/tpm/fu-tpm-v1-device.c index 873a77986..2622504de 100644 --- a/plugins/tpm/fu-tpm-v1-device.c +++ b/plugins/tpm/fu-tpm-v1-device.c @@ -68,10 +68,6 @@ fu_tpm_v1_device_probe(FuDevice *device, GError **error) g_auto(GStrv) lines = NULL; g_autofree gchar *buf_pcrs = NULL; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_tpm_v1_device_parent_class)->probe(device, error)) - return FALSE; - /* get entire contents */ if (!g_file_get_contents(fu_udev_device_get_device_file(FU_UDEV_DEVICE(device)), &buf_pcrs, diff --git a/plugins/tpm/fu-tpm-v2-device.c b/plugins/tpm/fu-tpm-v2-device.c index 9351d28d3..6c138291f 100644 --- a/plugins/tpm/fu-tpm-v2-device.c +++ b/plugins/tpm/fu-tpm-v2-device.c @@ -26,9 +26,6 @@ G_DEFINE_AUTOPTR_CLEANUP_FUNC(ESYS_CONTEXT, Esys_Finalize_autoptr_cleanup) static gboolean fu_tpm_v2_device_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_tpm_v2_device_parent_class)->probe(device, error)) - return FALSE; return fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "tpm", error); } diff --git a/plugins/uf2/fu-uf2-device.c b/plugins/uf2/fu-uf2-device.c index 625d4f9b7..ac737e920 100644 --- a/plugins/uf2/fu-uf2-device.c +++ b/plugins/uf2/fu-uf2-device.c @@ -317,10 +317,6 @@ fu_uf2_device_probe(FuDevice *device, GError **error) guint64 vid = 0; guint64 pid = 0; - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_uf2_device_parent_class)->probe(device, error)) - return FALSE; - /* check is valid */ tmp = g_udev_device_get_property(udev_device, "ID_BUS"); if (g_strcmp0(tmp, "usb") != 0) { diff --git a/plugins/vli/fu-vli-usbhub-device.c b/plugins/vli/fu-vli-usbhub-device.c index 4ea755f1f..0ac99395b 100644 --- a/plugins/vli/fu-vli-usbhub-device.c +++ b/plugins/vli/fu-vli-usbhub-device.c @@ -628,10 +628,6 @@ fu_vli_usbhub_device_probe(FuDevice *device, GError **error) { guint16 usbver = fu_usb_device_get_spec(FU_USB_DEVICE(device)); - /* FuUsbDevice->probe */ - if (!FU_DEVICE_CLASS(fu_vli_usbhub_device_parent_class)->probe(device, error)) - return FALSE; - /* quirks now applied... */ if (usbver > 0x0300 || fu_device_has_private_flag(device, FU_VLI_USBHUB_DEVICE_FLAG_USB3)) { fu_device_set_summary(device, "USB 3.x hub"); diff --git a/plugins/wacom-raw/fu-wacom-device.c b/plugins/wacom-raw/fu-wacom-device.c index b7473e6d2..2f5b4ee46 100644 --- a/plugins/wacom-raw/fu-wacom-device.c +++ b/plugins/wacom-raw/fu-wacom-device.c @@ -99,10 +99,6 @@ fu_wacom_device_check_mpu(FuWacomDevice *self, GError **error) static gboolean fu_wacom_device_probe(FuDevice *device, GError **error) { - /* FuUdevDevice->probe */ - if (!FU_DEVICE_CLASS(fu_wacom_device_parent_class)->probe(device, error)) - return FALSE; - /* set the physical ID */ return fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "hid", error); }