proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-17 19:38:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: Fix a tiny memory leak for an invalid SREC file

Browse Source 
Fixes https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=38196
This commit is contained in:
Richard Hughes 2021-09-06 20:41:20 +01:00
parent 9c6f676656
commit fa64f8fd30
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
libfwupdplugin/fu-srec-firmware.c
View File

@ -57,6 +57,11 @@ fu_srec_firmware_record_free(FuSrecFirmwareRecord *rcd)
g_free(rcd); g_free(rcd);
} }
#pragma clang diagnostic push
#pragma clang diagnostic ignored "-Wunused-function"
G_DEFINE_AUTOPTR_CLEANUP_FUNC(FuSrecFirmwareRecord, fu_srec_firmware_record_free);
#pragma clang diagnostic pop
/** /**
* fu_srec_firmware_record_new: (skip): * fu_srec_firmware_record_new: (skip):
* @ln: unsigned integer * @ln: unsigned integer
@ -126,7 +131,7 @@ fu_srec_firmware_tokenize(FuFirmware *firmware, GBytes *fw, FwupdInstallFlags fl
data = g_bytes_get_data(fw, &sz); data = g_bytes_get_data(fw, &sz);
lines = fu_common_strnsplit(data, sz, "\n", -1); lines = fu_common_strnsplit(data, sz, "\n", -1);
for (guint ln = 0; lines[ln] != NULL; ln++) { for (guint ln = 0; lines[ln] != NULL; ln++) {
FuSrecFirmwareRecord *rcd; g_autoptr(FuSrecFirmwareRecord) rcd = NULL;
const gchar *line = lines[ln]; const gchar *line = lines[ln];
gsize linesz; gsize linesz;
guint32 rec_addr32; guint32 rec_addr32;
@ -290,7 +295,7 @@ fu_srec_firmware_tokenize(FuFirmware *firmware, GBytes *fw, FwupdInstallFlags fl
fu_byte_array_append_uint8(rcd->buf, tmp); fu_byte_array_append_uint8(rcd->buf, tmp);
} }
} }
g_ptr_array_add(priv->records, rcd); g_ptr_array_add(priv->records, g_steal_pointer(&rcd));
} }
/* no EOF */ /* no EOF */