proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-27 09:12:52 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

synaptics-mst: Read the fw-size in a more safe way

Browse Source
This commit is contained in:
Richard Hughes 2022-04-28 09:30:56 +01:00
parent beb49d7ac0
commit f81a3e671e
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/synaptics-mst/fu-synaptics-mst-device.c
View File

@ -525,7 +525,7 @@ fu_synaptics_mst_device_update_panamera_firmware(FuSynapticsMstDevice *self,
GError **error) GError **error)
{ {
guint16 crc_tmp = 0; guint16 crc_tmp = 0;
guint32 fw_size; guint32 fw_size = 0;
guint32 unit_sz = BLOCK_UNIT; guint32 unit_sz = BLOCK_UNIT;
guint32 write_loops = 0; guint32 write_loops = 0;
guint8 bank_to_update = BANKTAG_1; guint8 bank_to_update = BANKTAG_1;
@ -543,8 +543,14 @@ fu_synaptics_mst_device_update_panamera_firmware(FuSynapticsMstDevice *self,
g_debug("bank to update:%x", bank_to_update); g_debug("bank to update:%x", bank_to_update);
/* get firmware size */ /* get firmware size */
fw_size = 0x410 + (*(payload_data + 0x400) << 24) + (*(payload_data + 0x401) << 16) + if (!fu_common_read_uint32_safe(payload_data,
(*(payload_data + 0x402) << 8) + (*(payload_data + 0x403)); payload_len,
0x400,
&fw_size,
G_LITTLE_ENDIAN,
error))
return FALSE;
fw_size += 0x410;
/* Current max firmware size is 104K */ /* Current max firmware size is 104K */
if (fw_size < payload_len) if (fw_size < payload_len)