proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-06-06 19:13:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

analogix: Do not check the endpoints before selecting an interface

Browse Source 
My Analogix USB device has a Billboard interface, with bNumEndpoints=0.

When emulating the interface is NULL, and in runtime the array can *never* be
NULL, so I think this check was added in error.
This commit is contained in:
Richard Hughes 2023-02-06 15:00:49 +00:00
parent 390796c0d3
commit eff7bfed8e
1 changed files with 0 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/analogix/fu-analogix-device.c
View File

@ -208,11 +208,6 @@ fu_analogix_device_find_interface(FuUsbDevice *device, GError **error)
if (g_usb_interface_get_class(intf) == BILLBOARD_CLASS && if (g_usb_interface_get_class(intf) == BILLBOARD_CLASS &&
g_usb_interface_get_subclass(intf) == BILLBOARD_SUBCLASS && g_usb_interface_get_subclass(intf) == BILLBOARD_SUBCLASS &&
g_usb_interface_get_protocol(intf) == BILLBOARD_PROTOCOL) { g_usb_interface_get_protocol(intf) == BILLBOARD_PROTOCOL) {
g_autoptr(GPtrArray) endpoints = NULL;
endpoints = g_usb_interface_get_endpoints(intf);
if (endpoints == NULL)
continue;
fu_usb_device_add_interface(FU_USB_DEVICE(self), fu_usb_device_add_interface(FU_USB_DEVICE(self),
g_usb_interface_get_number(intf)); g_usb_interface_get_number(intf));
return TRUE; return TRUE;