proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-08 09:13:22 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

realtek-mst: Show the write failure when using --verbose

Browse Source 
Spotted by Coverity.
This commit is contained in:
Richard Hughes 2021-07-10 10:03:25 +01:00
parent f01eb3808c
commit ef807240f7
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
plugins/realtek-mst/fu-realtek-mst-device.c
View File

@ -784,6 +784,8 @@ fu_realtek_mst_device_attach (FuDevice *device, GError **error)
if (!mst_read_register (self, REG_MCU_MODE, &value, error)) if (!mst_read_register (self, REG_MCU_MODE, &value, error))
return FALSE; return FALSE;
if ((value & MCU_MODE_ISP) != 0) { if ((value & MCU_MODE_ISP) != 0) {
g_autoptr(GError) error_local = NULL;
g_debug ("resetting device to exit ISP mode"); g_debug ("resetting device to exit ISP mode");
fu_device_set_status (device, FWUPD_STATUS_DEVICE_RESTART); fu_device_set_status (device, FWUPD_STATUS_DEVICE_RESTART);
@ -792,7 +794,10 @@ fu_realtek_mst_device_attach (FuDevice *device, GError **error)
* no longer in programming mode after giving it time to reset. */ * no longer in programming mode after giving it time to reset. */
if (!mst_read_register (self, 0xEE, &value, error)) if (!mst_read_register (self, 0xEE, &value, error))
return FALSE; return FALSE;
mst_write_register (self, 0xEE, value | 2, NULL); if (!mst_write_register (self, 0xEE, value | 2, &error_local)) {
g_debug ("write spuriously failed, ignoring: %s",
error_local->message);
}
/* allow device some time to reset */ /* allow device some time to reset */
g_usleep (G_USEC_PER_SEC); g_usleep (G_USEC_PER_SEC);