From ee7e76460392372970ff8ca35d9edbe25bd5020b Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Thu, 1 Feb 2018 11:54:26 +0000 Subject: [PATCH] trivial: Do not return failure if a device flag is already set If we have multiple versions of upgrades/downgrades we'll be setting the REPORTED flags for multiple history entries at once. --- src/fu-engine.c | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/src/fu-engine.c b/src/fu-engine.c index 809684894..abb5423d0 100644 --- a/src/fu-engine.c +++ b/src/fu-engine.c @@ -630,13 +630,8 @@ fu_engine_modify_device (FuEngine *self, "key %s not a valid flag", key); return FALSE; } - if (fu_device_has_flag (device, flag)) { - g_set_error_literal (error, - FWUPD_ERROR, - FWUPD_ERROR_NOT_SUPPORTED, - "device already has that flag"); - return FALSE; - } + if (fu_device_has_flag (device, flag)) + return TRUE; if (flag != FWUPD_DEVICE_FLAG_REPORTED && flag != FWUPD_DEVICE_FLAG_NOTIFIED) { g_set_error (error,