proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-27 11:09:28 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fastboot: add quirk to delay operations

Browse Source 
Some devices such as the Quectel EG25-G modem need some breathing room
between fastboot commands. This quirk allows to specify for such devices
a delay which is used after each read or write command.
Without this, the Quectel EG25-G modem's fastboot bootloader
cannot handle this and crashes.
This commit is contained in:
Dylan Van Assche 2021-12-11 16:46:27 +01:00 committed by Richard Hughes
parent c0ec63091d
commit e6121ae3c7
2 changed files with 31 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
plugins/fastboot/README.md
View File

@ -47,6 +47,12 @@ Block size to use for transfers.
Since: 1.2.2
### FastbootOperationDelay
Time in ms to delay after a read or write operation.
Since: 1.7.4
## Vendor ID Security
The vendor ID is set from the USB vendor, for example `USB:0x18D1`

26
plugins/fastboot/fu-fastboot-device.c
View File

@ -19,11 +19,13 @@
#define FASTBOOT_EP_IN 0x81
#define FASTBOOT_EP_OUT 0x01
#define FASTBOOT_CMD_BUFSZ 64 /* bytes */
#define FASTBOOT_US_TO_MS 1000
struct _FuFastbootDevice {
FuUsbDevice parent_instance;
gboolean secure;
guint blocksz;
guint operation_delay;
guint8 intf_nr;
};
@ -92,6 +94,7 @@ fu_fastboot_buffer_dump(const gchar *title, const guint8 *buf, gsize sz)
static gboolean
fu_fastboot_device_write(FuDevice *device, const guint8 *buf, gsize buflen, GError **error)
{
FuFastbootDevice *self = FU_FASTBOOT_DEVICE(device);
GUsbDevice *usb_device = fu_usb_device_get_dev(FU_USB_DEVICE(device));
gboolean ret;
gsize actual_len = 0;
@ -111,6 +114,10 @@ fu_fastboot_device_write(FuDevice *device, const guint8 *buf, gsize buflen, GErr
FASTBOOT_TRANSACTION_TIMEOUT,
NULL,
error);
/* give device some time to handle action */
g_usleep(self->operation_delay * FASTBOOT_US_TO_MS);
if (!ret) {
g_prefix_error(error, "failed to do bulk transfer: ");
return FALSE;
@ -176,6 +183,9 @@ fu_fastboot_device_read(FuDevice *device,
FASTBOOT_TRANSACTION_TIMEOUT,
NULL,
&error_local);
/* give device some time to handle action */
g_usleep(self->operation_delay * FASTBOOT_US_TO_MS);
if (!ret) {
if (g_error_matches(error_local,
G_USB_DEVICE_ERROR,
@ -689,15 +699,27 @@ fu_fastboot_device_set_quirk_kv(FuDevice *device,
GError **error)
{
FuFastbootDevice *self = FU_FASTBOOT_DEVICE(device);
guint64 tmp = 0;
/* load from quirks */
if (g_strcmp0(key, "FastbootBlockSize") == 0) {
guint64 tmp = 0;
if (!fu_common_strtoull_full(value, &tmp, 0x40, 0x100000, error))
return FALSE;
self->blocksz = tmp;
return TRUE;
}
if (g_strcmp0(key, "FastbootBlockSize") == 0) {
if (!fu_common_strtoull_full(value, &tmp, 0x40, 0x100000, error))
return FALSE;
self->blocksz = tmp;
return TRUE;
}
if (g_strcmp0(key, "FastbootOperationDelay") == 0) {
if (!fu_common_strtoull_full(value, &tmp, 0, G_MAXSIZE, error))
return FALSE;
self->operation_delay = tmp;
return TRUE;
}
/* failed */
g_set_error_literal(error, G_IO_ERROR, G_IO_ERROR_NOT_SUPPORTED, "quirk key not supported");
@ -733,6 +755,8 @@ fu_fastboot_device_init(FuFastbootDevice *self)
{
/* this is a safe default, even using USBv1 */
self->blocksz = 512;
/* no delay is applied by default after a read or write operation */
self->operation_delay = 0;
fu_device_add_protocol(FU_DEVICE(self), "com.google.fastboot");
fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_UPDATABLE);
fu_device_add_flag(FU_DEVICE(self), FWUPD_DEVICE_FLAG_IS_BOOTLOADER);