From df297d3ee2d48b0780378d18d9ddf25a194c3e0b Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Sat, 10 Jul 2021 10:05:09 +0100 Subject: [PATCH] superio: Always ensure the version string is NUL terminated Spotted by Coverity --- plugins/superio/fu-superio-it55-device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/superio/fu-superio-it55-device.c b/plugins/superio/fu-superio-it55-device.c index 6b9872230..e93c3e5d4 100644 --- a/plugins/superio/fu-superio-it55-device.c +++ b/plugins/superio/fu-superio-it55-device.c @@ -92,12 +92,12 @@ fu_superio_it55_device_ec_project (FuSuperioDevice *device, GError **error) static gboolean fu_superio_it55_device_ec_version (FuSuperioDevice *self, GError **error) { - gchar version[16] = "1."; + gchar version[16] = { '1', '.', '\0' }; if (!fu_superio_device_ec_write_cmd (self, SIO_CMD_EC_GET_VERSION_STR, error)) return FALSE; - for (guint i = 2; i < sizeof(version) - 1; ++i) { + for (guint i = 2; i < sizeof(version) - 1; i++) { guint8 tmp = 0; if (!fu_superio_device_ec_read_data (self, &tmp, error)) { g_prefix_error (error, "failed to read firmware version: ");