proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-14 04:00:41 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Compare the specified and installed firmare versions

Browse Source
This commit is contained in:
Richard Hughes 2015-03-04 19:26:54 +00:00
parent a2288a3fce
commit def3175655
1 changed files with 48 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

52
src/fu-main.c
View File

@ -258,9 +258,12 @@ fu_main_cab_extract_firmware_cb (GCabFile *file, gpointer user_data)
static gboolean static gboolean
fu_main_update_helper (FuMainAuthHelper *helper, GError **error) fu_main_update_helper (FuMainAuthHelper *helper, GError **error)
{ {
const gchar *guid_tmp; const gchar *tmp;
gint vercmp;
_cleanup_error_free_ GError *error_local = NULL; _cleanup_error_free_ GError *error_local = NULL;
_cleanup_free_ gchar *driver_ver = NULL;
_cleanup_free_ gchar *guid = NULL; _cleanup_free_ gchar *guid = NULL;
_cleanup_free_ gchar *version = NULL;
_cleanup_object_unref_ GCabCabinet *cab = NULL; _cleanup_object_unref_ GCabCabinet *cab = NULL;
_cleanup_object_unref_ GFile *path = NULL; _cleanup_object_unref_ GFile *path = NULL;
_cleanup_object_unref_ GInputStream *stream_buf = NULL; _cleanup_object_unref_ GInputStream *stream_buf = NULL;
@ -346,13 +349,54 @@ fu_main_update_helper (FuMainAuthHelper *helper, GError **error)
error_local->message); error_local->message);
return FALSE; return FALSE;
} }
guid_tmp = fu_device_get_metadata (helper->device, FU_DEVICE_KEY_GUID); tmp = fu_device_get_metadata (helper->device, FU_DEVICE_KEY_GUID);
if (g_strcmp0 (guid, guid_tmp) != 0) { if (g_strcmp0 (guid, tmp) != 0) {
g_set_error (error, g_set_error (error,
FU_ERROR, FU_ERROR,
FU_ERROR_INTERNAL, FU_ERROR_INTERNAL,
"firmware is not for this hw: required %s got %s", "firmware is not for this hw: required %s got %s",
guid_tmp, guid); tmp, guid);
return FALSE;
}
/* get version */
driver_ver = g_key_file_get_string (helper->inf_kf, "Version", "DriverVer", NULL);
if (driver_ver == NULL) {
g_set_error_literal (error,
FU_ERROR,
FU_ERROR_INTERNAL,
"DriverVer is missing");
return FALSE;
}
/* parse the DriverVer */
version = as_utils_parse_driver_version (driver_ver, NULL, &error_local);
if (version == NULL) {
g_set_error (error,
FU_ERROR,
FU_ERROR_INTERNAL,
"Could not parse DriverVer '%s': %s",
driver_ver, error_local->message);
return FALSE;
}
/* compare the versions of what we have installed */
tmp = fu_device_get_metadata (helper->device, FU_DEVICE_KEY_VERSION);
vercmp = as_utils_vercmp (tmp, version);
if (vercmp == 0 && (helper->flags & FU_PROVIDER_UPDATE_FLAG_ALLOW_REINSTALL) == 0) {
g_set_error (error,
FU_ERROR,
FU_ERROR_INTERNAL,
"Specified firmware is already installed '%s'",
tmp);
return FALSE;
}
if (vercmp > 0 && (helper->flags & FU_PROVIDER_UPDATE_FLAG_ALLOW_OLDER) == 0) {
g_set_error (error,
FU_ERROR,
FU_ERROR_INTERNAL,
"Specified firmware is older than installed '%s < %s'",
tmp, version);
return FALSE; return FALSE;
} }