proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-06 02:57:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

tpm-eventlog: Do not return a security attr if there is no TPM device

Browse Source 
There is literally no point in showing two TPM failures.
This commit is contained in:
Richard Hughes 2020-05-18 21:08:49 +01:00 committed by Mario Limonciello
parent 2157468709
commit de8d40d602
1 changed files with 31 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

37
plugins/tpm-eventlog/fu-plugin-tpm-eventlog.c
View File

@ -15,6 +15,7 @@
struct FuPluginData { struct FuPluginData {
GPtrArray *pcr0s; GPtrArray *pcr0s;
gboolean secure_boot_problem; gboolean secure_boot_problem;
gboolean has_device;
gboolean reconstructed; gboolean reconstructed;
}; };
@ -23,6 +24,7 @@ fu_plugin_init (FuPlugin *plugin)
{ {
fu_plugin_alloc_data (plugin, sizeof (FuPluginData)); fu_plugin_alloc_data (plugin, sizeof (FuPluginData));
fu_plugin_add_rule (plugin, FU_PLUGIN_RULE_RUN_BEFORE, "uefi"); fu_plugin_add_rule (plugin, FU_PLUGIN_RULE_RUN_BEFORE, "uefi");
fu_plugin_add_rule (plugin, FU_PLUGIN_RULE_RUN_AFTER, "tpm");
fu_plugin_set_build_hash (plugin, FU_BUILD_HASH); fu_plugin_set_build_hash (plugin, FU_BUILD_HASH);
} }
@ -86,16 +88,19 @@ fu_plugin_coldplug (FuPlugin *plugin, GError **error)
return TRUE; return TRUE;
} }
void static void
fu_plugin_device_registered (FuPlugin *plugin, FuDevice *device) fu_plugin_device_registered_tpm (FuPlugin *plugin, FuDevice *device)
{
FuPluginData *data = fu_plugin_get_data (plugin);
data->has_device = TRUE;
}
static void
fu_plugin_device_registered_uefi (FuPlugin *plugin, FuDevice *device)
{ {
FuPluginData *data = fu_plugin_get_data (plugin); FuPluginData *data = fu_plugin_get_data (plugin);
GPtrArray *checksums; GPtrArray *checksums;
/* only care about UEFI devices from ESRT */
if (g_strcmp0 (fu_device_get_plugin (device), "uefi") != 0)
return;
/* only the system-firmware device gets checksums */ /* only the system-firmware device gets checksums */
checksums = fu_device_get_checksums (device); checksums = fu_device_get_checksums (device);
if (checksums->len == 0) if (checksums->len == 0)
@ -125,12 +130,32 @@ fu_plugin_device_registered (FuPlugin *plugin, FuDevice *device)
"please see https://github.com/fwupd/fwupd/wiki/TPM-PCR0-differs-from-reconstruction"); "please see https://github.com/fwupd/fwupd/wiki/TPM-PCR0-differs-from-reconstruction");
} }
void
fu_plugin_device_registered (FuPlugin *plugin, FuDevice *device)
{
/* only care about UEFI devices from ESRT */
if (g_strcmp0 (fu_device_get_plugin (device), "uefi") == 0) {
fu_plugin_device_registered_uefi (plugin, device);
return;
}
/* detect the system TPM device */
if (g_strcmp0 (fu_device_get_plugin (device), "tpm") == 0) {
fu_plugin_device_registered_tpm (plugin, device);
return;
}
}
void void
fu_plugin_add_security_attrs (FuPlugin *plugin, FuSecurityAttrs *attrs) fu_plugin_add_security_attrs (FuPlugin *plugin, FuSecurityAttrs *attrs)
{ {
FuPluginData *data = fu_plugin_get_data (plugin); FuPluginData *data = fu_plugin_get_data (plugin);
g_autoptr(FwupdSecurityAttr) attr = NULL; g_autoptr(FwupdSecurityAttr) attr = NULL;
/* no TPM device */
if (!data->has_device)
return;
/* create attr */ /* create attr */
attr = fwupd_security_attr_new (FWUPD_SECURITY_ATTR_ID_TPM_RECONSTRUCTION_PCR0); attr = fwupd_security_attr_new (FWUPD_SECURITY_ATTR_ID_TPM_RECONSTRUCTION_PCR0);
fwupd_security_attr_set_plugin (attr, fu_plugin_get_name (plugin)); fwupd_security_attr_set_plugin (attr, fu_plugin_get_name (plugin));