From d99f74f0b748ba8c8b656b7eb6bd365821ad9834 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Fri, 20 Nov 2020 09:54:34 +0000 Subject: [PATCH] Revert "bcm57xx: Use PCI function 1 as 0 does not work with the Dell KH08P" This reverts commit b5eddee5f604885b82bca58560ecd250f9def940. Using pci function 0 works on my Lenovo P50 but not my Lenovo X1. Don't break machines where we are shipping the chip rather than ones where we probably are not, especially when it's probably a kernel bug somewhere. Fixes https://github.com/fwupd/fwupd/issues/2608 --- plugins/bcm57xx/fu-bcm57xx-device.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/plugins/bcm57xx/fu-bcm57xx-device.c b/plugins/bcm57xx/fu-bcm57xx-device.c index 7328084ff..b06cc66bd 100644 --- a/plugins/bcm57xx/fu-bcm57xx-device.c +++ b/plugins/bcm57xx/fu-bcm57xx-device.c @@ -57,8 +57,8 @@ fu_bcm57xx_device_probe (FuUdevDevice *device, GError **error) g_autofree gchar *fn = NULL; g_autoptr(GPtrArray) ifaces = NULL; - /* only enumerate first device */ - if (fu_udev_device_get_number (device) != 1) { + /* only enumerate number 0 */ + if (fu_udev_device_get_number (device) != 0) { g_set_error_literal (error, FWUPD_ERROR, FWUPD_ERROR_NOT_SUPPORTED,