From d8ea8da902493638bbe776ca854c1c17ca0fbcee Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Wed, 19 Feb 2020 15:04:49 +0000 Subject: [PATCH] Do not allow devices that have no vendor ID to be UPDATABLE --- src/fu-engine.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/fu-engine.c b/src/fu-engine.c index ab3cce276..a0b921d3f 100644 --- a/src/fu-engine.c +++ b/src/fu-engine.c @@ -4356,6 +4356,13 @@ fu_engine_add_device (FuEngine *self, FuDevice *device) fu_device_set_update_error (device, "VersionFormat is ambiguous for this device"); } + /* no vendor-id, and so no way to lock it down! */ + if (fu_device_has_flag (device, FWUPD_DEVICE_FLAG_UPDATABLE) && + fu_device_get_vendor_id (device) == NULL) { + fu_device_remove_flag (device, FWUPD_DEVICE_FLAG_UPDATABLE); + fu_device_set_update_error (device, "No vendor ID set"); + } + /* notify all plugins about this new device */ if (!fu_device_has_flag (device, FWUPD_DEVICE_FLAG_REGISTERED)) fu_engine_plugin_device_register (self, device);