proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-08 19:56:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

superio: Never read from port offset zero

Browse Source 
At this point, PM1 IOBAD0 is unset, and thus zero...
This commit is contained in:
Richard Hughes 2019-11-08 17:01:23 +00:00
parent 025fc77d7a
commit d630b5ee66
1 changed files with 0 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
plugins/superio/fu-superio-device.c
View File

@ -263,18 +263,6 @@ fu_superio_device_setup (FuDevice *device, GError **error)
FuSuperioDeviceClass *klass = FU_SUPERIO_DEVICE_GET_CLASS (device); FuSuperioDeviceClass *klass = FU_SUPERIO_DEVICE_GET_CLASS (device);
FuSuperioDevice *self = FU_SUPERIO_DEVICE (device); FuSuperioDevice *self = FU_SUPERIO_DEVICE (device);
FuSuperioDevicePrivate *priv = GET_PRIVATE (self); FuSuperioDevicePrivate *priv = GET_PRIVATE (self);
guint8 tmp = 0x0;
/* check port is valid */
if (!fu_udev_device_pread (FU_UDEV_DEVICE (self), priv->pm1_iobad0, &tmp, error))
return FALSE;
if (tmp != 0xff) {
g_set_error_literal (error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"check port!");
return FALSE;
}
/* check ID is correct */ /* check ID is correct */
if (!fu_superio_device_check_id (self, error)) { if (!fu_superio_device_check_id (self, error)) {