From d56ad5b440f55139a05790d70f76198f28f800ae Mon Sep 17 00:00:00 2001
From: Richard Hughes <richard@hughsie.com>
Date: Mon, 12 Nov 2018 10:48:06 +0000
Subject: [PATCH] trivial: Fix a possible critical warning when parsing invalid
 metadata

---
 src/fu-engine.c | 9 ++++++++-
 1 file changed, 8 insertions(+), 1 deletion(-)

diff --git a/src/fu-engine.c b/src/fu-engine.c
index 98647b25b..8cccdddcf 100644
--- a/src/fu-engine.c
+++ b/src/fu-engine.c
@@ -2543,7 +2543,14 @@ fu_engine_get_releases_for_device (FuEngine *self, FuDevice *device, GError **er
 
 	/* return the compound error */
 	if (releases->len == 0) {
-		g_propagate_error (error, g_steal_pointer (&error_all));
+		if (error_all != NULL) {
+			g_propagate_error (error, g_steal_pointer (&error_all));
+			return NULL;
+		}
+		g_set_error (error,
+			     FWUPD_ERROR,
+			     FWUPD_ERROR_NOTHING_TO_DO,
+			     "No valid releases found for device");
 		return NULL;
 	}
 	return releases;