proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-14 23:24:09 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

nvme: Always require a reboot after applying firmware

Browse Source 
Although we can apply the firmware at runtime, the new firmware isn't going to
be running until the PCIe device has been re-enumerated.
This commit is contained in:
Richard Hughes 2018-09-04 15:12:57 +01:00
parent 8ddc864764
commit cfc1768bf0
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
plugins/nvme/fu-nvme-device.c
View File

@ -216,9 +216,7 @@ fu_nvme_device_parse_cns (FuNvmeDevice *self, const guint8 *buf, gsize sz, GErro
fawr = (buf[260] & 0x10) >> 4; fawr = (buf[260] & 0x10) >> 4;
nfws = (buf[260] & 0x0e) >> 1; nfws = (buf[260] & 0x0e) >> 1;
s1ro = buf[260] & 0x01; s1ro = buf[260] & 0x01;
g_debug ("nr fw slots: %u, slot1 r/o: %u", nfws, s1ro); g_debug ("fawr: %u, nr fw slots: %u, slot1 r/o: %u", fawr, nfws, s1ro);
if (!fawr)
fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_NEEDS_REBOOT);
/* Dell helpfully provide an EFI GUID we can use in the vendor offset, /* Dell helpfully provide an EFI GUID we can use in the vendor offset,
* but don't have a header or any magic we can use -- so check if the * but don't have a header or any magic we can use -- so check if the
@ -369,6 +367,7 @@ fu_nvme_device_init (FuNvmeDevice *self)
{ {
fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_REQUIRE_AC); fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_REQUIRE_AC);
fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_UPDATABLE); fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_UPDATABLE);
fu_device_add_flag (FU_DEVICE (self), FWUPD_DEVICE_FLAG_NEEDS_REBOOT);
fu_device_set_summary (FU_DEVICE (self), "NVM Express Solid State Drive"); fu_device_set_summary (FU_DEVICE (self), "NVM Express Solid State Drive");
fu_device_add_icon (FU_DEVICE (self), "drive-harddisk"); fu_device_add_icon (FU_DEVICE (self), "drive-harddisk");
} }