From c88d4eadf1770c3cf0df25ea2e961df60e2ac5b0 Mon Sep 17 00:00:00 2001 From: Mario Limonciello Date: Wed, 13 May 2020 09:39:35 -0500 Subject: [PATCH] trivial: fu-engine: raise a runtime issue if plugin whitelist set MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit If a plugin whitelist is set, the HSI value will be wrong. ``` $ sudo ./build/src/fwupdtool security --force --plugin-whitelist=tpm Loading… [***************************************] Host Security ID: HSI:1 HSI-1 ✔ TPM: v2.0 Runtime Suffix -U ✘ Firmware Updates: No system device Runtime Suffix -A ✘ Firmware Attestation: No PCR0s Runtime Suffix -! ✔ fwupd plugins: OK ``` --- src/fu-engine.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/fu-engine.c b/src/fu-engine.c index ca0daa214..dd7619ae4 100644 --- a/src/fu-engine.c +++ b/src/fu-engine.c @@ -5045,6 +5045,8 @@ fu_engine_add_security_attrs_tainted (FuEngine *self, FuSecurityAttrs *attrs) fwupd_security_attr_add_flag (attr, FWUPD_SECURITY_ATTR_FLAG_RUNTIME_ISSUE); if (self->tainted) { fwupd_security_attr_set_result (attr, "Tainted"); + } else if (self->plugin_filter->len > 0) { + fwupd_security_attr_set_result (attr, "Disabled plugins"); } else { fwupd_security_attr_add_flag (attr, FWUPD_SECURITY_ATTR_FLAG_SUCCESS); }