proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-05-29 21:51:16 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix a critical warning when parsing an empty kernel cmdline

Browse Source 
Fix the bounds check so we never pass a bufsz of zero to fu_strsplit().

Resolves: https://github.com/fwupd/fwupd/issues/5575
This commit is contained in:
Richard Hughes 2023-02-22 21:14:22 +00:00 committed by Mario Limonciello
parent 2819653a3a
commit c6fa4e97e7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libfwupdplugin/fu-common.c
View File

@ -116,7 +116,7 @@ fu_common_is_live_media(void)
return TRUE; return TRUE;
if (!g_file_get_contents("/proc/cmdline", &buf, &bufsz, NULL)) if (!g_file_get_contents("/proc/cmdline", &buf, &bufsz, NULL))
return FALSE; return FALSE;
if (bufsz == 0) if (bufsz <= 1)
return FALSE; return FALSE;
tokens = fu_strsplit(buf, bufsz - 1, " ", -1); tokens = fu_strsplit(buf, bufsz - 1, " ", -1);
for (guint i = 0; args[i] != NULL; i++) { for (guint i = 0; args[i] != NULL; i++) {