proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-16 20:15:11 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

trivial: fu-util/fu-tool: check for '-' in arguments

Browse Source 
Make sure if something doesn't look like a duck that it's not a duck.
This commit is contained in:
Mario Limonciello 2020-04-20 15:40:11 -05:00 committed by Richard Hughes
parent bc3c241f91
commit c6009f59fe
2 changed files with 21 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/fu-tool.c
View File

@ -645,6 +645,17 @@ fu_util_get_device (FuUtilPrivate *priv, const gchar *id, GError **error)
return NULL; return NULL;
return fu_util_prompt_for_device (priv, devices, error); return fu_util_prompt_for_device (priv, devices, error);
} }
/* did this look like a GUID? */
for (guint i = 0; id[i] != '\0'; i++) {
if (id[i] == '-') {
g_set_error_literal (error,
FWUPD_ERROR,
FWUPD_ERROR_INVALID_ARGS,
"Invalid arguments");
return FALSE;
}
}
return fu_engine_get_device (priv->engine, id, error); return fu_engine_get_device (priv->engine, id, error);
} }

10
src/fu-util.c
View File

@ -1040,6 +1040,16 @@ fu_util_get_device_by_id (FuUtilPrivate *priv, const gchar *id, GError **error)
return NULL; return NULL;
return fu_util_prompt_for_device (priv, devices, error); return fu_util_prompt_for_device (priv, devices, error);
} }
/* did this look like a GUID? */
for (guint i = 0; id[i] != '\0'; i++) {
if (id[i] == '-') {
g_set_error_literal (error,
FWUPD_ERROR,
FWUPD_ERROR_INVALID_ARGS,
"Invalid arguments");
return FALSE;
}
}
return fwupd_client_get_device_by_id (priv->client, id, NULL, error); return fwupd_client_get_device_by_id (priv->client, id, NULL, error);
} }