From c3c50fba4c7fe5513f502d80a7e553969cdec569 Mon Sep 17 00:00:00 2001 From: Richard Hughes Date: Fri, 21 Jul 2017 13:07:00 +0100 Subject: [PATCH] libdfu: Fix a crash if elf32_newehdr() fails --- libdfu/dfu-format-elf.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libdfu/dfu-format-elf.c b/libdfu/dfu-format-elf.c index db108e7b4..7987c39f8 100644 --- a/libdfu/dfu-format-elf.c +++ b/libdfu/dfu-format-elf.c @@ -386,7 +386,10 @@ dfu_firmware_to_elf (DfuFirmware *firmware, GError **error) /* add executable header */ ehdr = elf32_newehdr (e); if (ehdr == NULL) { - g_warning ("failed to create executable header: %s", + g_set_error (error, + DFU_ERROR, + DFU_ERROR_INTERNAL, + "failed to create executable header: %s", elf_errmsg (-1)); return NULL; }