proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-05-20 20:38:35 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

fu-engine: don't expose bootloader version errors to users

Browse Source 
These messages are useful for debugging but not to users.  Many issues
get filed because they're cryptic and users can't do anything about them.

Downgrade the actual messages to debugging in the engine, and just send
back a generic message for clients.

Fixes: #1659
Fixes: #1261
This commit is contained in:
Mario Limonciello 2019-12-12 14:30:27 -06:00 committed by Mario Limonciello
parent a21802acad
commit c23e61296b
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/fu-engine.c
View File

@ -1119,15 +1119,16 @@ fu_engine_check_requirement_firmware (FuEngine *self, XbNode *req,
if (g_strcmp0 (xb_node_get_attr (req, "compare"), "ge") == 0) {
g_set_error (error,
FWUPD_ERROR,
FWUPD_ERROR_INVALID_FILE,
FWUPD_ERROR_NOT_SUPPORTED,
"Not compatible with bootloader version %s, requires >= %s",
version, xb_node_get_attr (req, "version"));
version, xb_node_get_attr (req, "version"));
} else {
g_set_error (error,
FWUPD_ERROR,
FWUPD_ERROR_INVALID_FILE,
"Not compatible with bootloader version: %s",
error_local->message);
g_debug ("Bootloader is not compatible: %s", error_local->message);
g_set_error_literal (error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"Bootloader is not compatible");
}
return FALSE;
}