proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-14 03:25:39 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix probing the Dell TPM (Fixes: #3759)

Browse Source 
Since commit 078beaf, device de-duplication between plugins doesn't
work anymore.  Both the TPM and Dell plugin create a device with an
identical physical ID and no logical ID.  This makes the device list
think whichever plugin probes second is just updating the first.

To avoid this problem, set a logical ID in the Dell plugin, ensuring
that the device ID built from physical + logical is different from the
TPM plugin.

The side effect of this is that both devices will export into the device
list, but the TPM plugin's devices will not be upgradable.
This commit is contained in:
Mario Limonciello 2021-09-16 11:17:08 -05:00 committed by Mario Limonciello
parent 9d37e447a1
commit c0f242258b
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
plugins/dell/fu-plugin-dell.c
View File

@ -761,6 +761,7 @@ fu_plugin_dell_detect_tpm(FuPlugin *plugin, GError **error)
/* build Standard device nodes */
dev = fu_device_new_with_context(ctx);
fu_device_set_physical_id(dev, "DEVNAME=/dev/tpm0");
fu_device_set_logical_id(dev, "UEFI");
fu_device_add_instance_id(dev, tpm_guid_raw);
fu_device_add_instance_id(dev, "system-tpm");
fu_device_set_vendor(dev, "Dell Inc.");