proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-08-16 08:02:06 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Support unsetting specific device flags

Browse Source 
This makes it possible to 'undo' the notification, for example.
This commit is contained in:
Richard Hughes 2023-01-23 16:05:00 +00:00 committed by Mario Limonciello
parent e92bb8a2ac
commit b5a70a70ee
1 changed files with 26 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

44
src/fu-engine.c
View File

@ -1023,26 +1023,34 @@ fu_engine_modify_device(FuEngine *self,
if (device == NULL)
return FALSE;
/* support adding a subset of device flags */
/* support adding and removing a subset of device flags */
if (g_strcmp0(key, "Flags") == 0) {
FwupdDeviceFlags flag = fwupd_device_flag_from_string(value);
if (flag == FWUPD_DEVICE_FLAG_UNKNOWN) {
g_set_error(error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"key %s not a valid flag",
key);
return FALSE;
if (g_str_has_prefix(value, "~")) {
FwupdDeviceFlags flag = fwupd_device_flag_from_string(value + 1);
if (flag == FWUPD_DEVICE_FLAG_NOTIFIED) {
fu_device_remove_flag(device, flag);
} else {
g_set_error(error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"flag %s cannot be unset from client",
key);
return FALSE;
}
} else {
FwupdDeviceFlags flag = fwupd_device_flag_from_string(value);
if (flag == FWUPD_DEVICE_FLAG_REPORTED ||
flag == FWUPD_DEVICE_FLAG_NOTIFIED) {
fu_device_add_flag(device, flag);
} else {
g_set_error(error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"flag %s cannot be set from client",
key);
return FALSE;
}
}
if (flag != FWUPD_DEVICE_FLAG_REPORTED && flag != FWUPD_DEVICE_FLAG_NOTIFIED) {
g_set_error(error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"flag %s cannot be set from client",
key);
return FALSE;
}
fu_device_add_flag(device, flag);
return fu_history_modify_device(self->history, device, error);
}