From b0418d77862d8cdf1aaa9283b7465298bbbb9f54 Mon Sep 17 00:00:00 2001 From: Aleksander Morgado Date: Tue, 24 Nov 2020 09:40:00 +0100 Subject: [PATCH] modem-manager: plug udev client leak The GUdevClient is created when the ModemManager sysfs path is inhibited; we need to make sure we destroy the object once uninhibited, or we'll otherwise create a new one if we're running an additional upgrade operation afterwards. --- plugins/modem-manager/fu-plugin-modem-manager.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/plugins/modem-manager/fu-plugin-modem-manager.c b/plugins/modem-manager/fu-plugin-modem-manager.c index b5b8c00dc..07cf4cb2d 100644 --- a/plugins/modem-manager/fu-plugin-modem-manager.c +++ b/plugins/modem-manager/fu-plugin-modem-manager.c @@ -62,6 +62,8 @@ fu_plugin_mm_uninhibit_device (FuPlugin *plugin) FuPluginData *priv = fu_plugin_get_data (plugin); g_autoptr(FuPluginMmInhibitedDeviceInfo) info = NULL; + g_clear_object (&priv->udev_client); + /* get the device removed from the plugin cache before uninhibiting */ fu_plugin_mm_udev_device_removed (plugin);