From ac760f7a2d90558eba53d923ca7912415ec77272 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ga=C3=ABl=20PORTAY?= Date: Sun, 20 Mar 2022 18:44:53 +0100 Subject: [PATCH] genesys: usbhub: Set dual-image flat in quirk file Some Genesys Logic USB Hub does have support for dual-image. This sets the flag dual-image in the quirk file instead of hardcoding it in the plugin. --- plugins/genesys/fu-genesys-usbhub-device.c | 2 -- plugins/genesys/genesys.quirk | 5 +++-- 2 files changed, 3 insertions(+), 4 deletions(-) diff --git a/plugins/genesys/fu-genesys-usbhub-device.c b/plugins/genesys/fu-genesys-usbhub-device.c index a93f49cde..3dc3d8fd8 100644 --- a/plugins/genesys/fu-genesys-usbhub-device.c +++ b/plugins/genesys/fu-genesys-usbhub-device.c @@ -843,7 +843,6 @@ fu_genesys_usbhub_device_setup(FuDevice *device, GError **error) } else { self->code_size = self->fw_data_total_count; } - fu_device_add_flag(device, FWUPD_DEVICE_FLAG_DUAL_IMAGE); fu_device_set_firmware_size_max(device, 0x8000); break; case ISP_MODEL_HUB_GL3590: @@ -852,7 +851,6 @@ fu_genesys_usbhub_device_setup(FuDevice *device, GError **error) self->fw_bank_addr[0] = 0x0000; self->fw_bank_addr[1] = 0x10000; self->fw_data_total_count = 0x8000; - fu_device_add_flag(device, FWUPD_DEVICE_FLAG_DUAL_IMAGE); fu_device_set_firmware_size_max(device, 0x10000); break; default: diff --git a/plugins/genesys/genesys.quirk b/plugins/genesys/genesys.quirk index 1bb56842f..6d8e50dde 100644 --- a/plugins/genesys/genesys.quirk +++ b/plugins/genesys/genesys.quirk @@ -4,6 +4,7 @@ [USB\VID_03F0&PID_0610] Plugin = genesys Name = HP USB-C Controller +Flags = dual-image GenesysUsbhubSwitchRequest = 0xA1 GenesysUsbhubReadRequest = 0xA2 GenesysUsbhubWriteRequest = 0xA3 @@ -11,7 +12,7 @@ GenesysUsbhubWriteRequest = 0xA3 [USB\VID_03F0&PID_0610&PUBKEY_AB859399-95B8-5817-B521-9AD8CC7F5BD6] Plugin = genesys Name = HP M24fd USB-C Controller -Flags = has-mstar-scaler +Flags = dual-image,has-mstar-scaler GenesysUsbhubSwitchRequest = 0xA1 GenesysUsbhubReadRequest = 0xA2 GenesysUsbhubWriteRequest = 0xA3 @@ -19,7 +20,7 @@ GenesysUsbhubWriteRequest = 0xA3 [USB\VID_03F0&PID_0610&PUBKEY_6BE97D77-C2BA-5AA2-B7DF-B9B318BEC2B5] Plugin = genesys Name = HP M27fd USB-C Controller -Flags = has-mstar-scaler +Flags = dual-image,has-mstar-scaler GenesysUsbhubSwitchRequest = 0xA1 GenesysUsbhubReadRequest = 0xA2 GenesysUsbhubWriteRequest = 0xA3