From a8b3f9ed57eced08748cf46d24f81c4e1e19cb11 Mon Sep 17 00:00:00 2001 From: Jan Tojnar Date: Sat, 7 Nov 2020 16:57:12 +0100 Subject: [PATCH] trivial: fu-engine: skip empty cmdline commands g_strsplit returns an empty vector for an empty string, which leads to assertion in g_strv_contains when /proc/cmdline ends with a space. --- src/fu-engine.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/fu-engine.c b/src/fu-engine.c index c4d031f99..fae00f984 100644 --- a/src/fu-engine.c +++ b/src/fu-engine.c @@ -1620,7 +1620,10 @@ fu_engine_get_report_metadata_kernel_cmdline (GHashTable *hash, GError **error) g_auto(GStrv) tokens = fu_common_strnsplit (buf, bufsz - 1, " ", -1); g_autoptr(GString) cmdline_safe = g_string_new (NULL); for (guint i = 0; tokens[i] != NULL; i++) { - g_auto(GStrv) kv = g_strsplit (tokens[i], "=", 2); + g_auto(GStrv) kv = NULL; + if (strlen (tokens[i]) == 0) + continue; + kv = g_strsplit (tokens[i], "=", 2); if (g_strv_contains (ignore, kv[0])) continue; if (cmdline_safe->len > 0)