proxmox-mirrors/fwupd
1
0
Fork 0
mirror of https://git.proxmox.com/git/fwupd synced 2025-07-25 21:57:47 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

mtd: Do not try to probe recovery read-only partitions

Browse Source 
Ignore devices without a 'flags' file.
This commit is contained in:
Richard Hughes 2022-03-11 15:52:53 +00:00
parent a239dc8ab8
commit a6aef01e49
1 changed files with 17 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
plugins/mtd/fu-mtd-device.c
View File

@ -72,6 +72,7 @@ fu_mtd_device_probe(FuDevice *device, GError **error)
const gchar *vendor; const gchar *vendor;
guint64 flags = 0; guint64 flags = 0;
guint64 size = 0; guint64 size = 0;
g_autoptr(GError) error_local = NULL;
/* FuUdevDevice->probe */ /* FuUdevDevice->probe */
if (!FU_DEVICE_CLASS(fu_mtd_device_parent_class)->probe(device, error)) if (!FU_DEVICE_CLASS(fu_mtd_device_parent_class)->probe(device, error))
@ -81,6 +82,22 @@ fu_mtd_device_probe(FuDevice *device, GError **error)
if (!fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "mtd", error)) if (!fu_udev_device_set_physical_id(FU_UDEV_DEVICE(device), "mtd", error))
return FALSE; return FALSE;
/* flags have to exist */
if (!fu_udev_device_get_sysfs_attr_uint64(FU_UDEV_DEVICE(device),
"flags",
&flags,
&error_local)) {
if (g_error_matches(error_local, G_IO_ERROR, G_IO_ERROR_NOT_FOUND)) {
g_set_error_literal(error,
FWUPD_ERROR,
FWUPD_ERROR_NOT_SUPPORTED,
"no MTD flags");
return FALSE;
}
g_propagate_error(error, g_steal_pointer(&error_local));
return FALSE;
}
/* get name */ /* get name */
name = fu_udev_device_get_sysfs_attr(FU_UDEV_DEVICE(device), "name", NULL); name = fu_udev_device_get_sysfs_attr(FU_UDEV_DEVICE(device), "name", NULL);
if (name != NULL) if (name != NULL)
@ -107,8 +124,6 @@ fu_mtd_device_probe(FuDevice *device, GError **error)
if (!fu_udev_device_get_sysfs_attr_uint64(FU_UDEV_DEVICE(device), "size", &size, error)) if (!fu_udev_device_get_sysfs_attr_uint64(FU_UDEV_DEVICE(device), "size", &size, error))
return FALSE; return FALSE;
fu_device_set_firmware_size_max(device, size); fu_device_set_firmware_size_max(device, size);
if (!fu_udev_device_get_sysfs_attr_uint64(FU_UDEV_DEVICE(device), "flags", &flags, error))
return FALSE;
#ifdef HAVE_MTD_USER_H #ifdef HAVE_MTD_USER_H
if ((flags & MTD_NO_ERASE) == 0) { if ((flags & MTD_NO_ERASE) == 0) {
if (!fu_udev_device_get_sysfs_attr_uint64(FU_UDEV_DEVICE(device), if (!fu_udev_device_get_sysfs_attr_uint64(FU_UDEV_DEVICE(device),