trivial: Fix the FuDeviceInternalFlags conversion funcs

This commit is contained in:
Richard Hughes 2021-06-15 10:00:48 +01:00
parent 39b3140ed3
commit a5a82ba519
2 changed files with 15 additions and 1 deletions

View File

@ -206,6 +206,8 @@ fu_device_internal_flag_to_string (FuDeviceInternalFlags flag)
return "replug-match-guid"; return "replug-match-guid";
if (flag == FU_DEVICE_INTERNAL_FLAG_INHERIT_ACTIVATION) if (flag == FU_DEVICE_INTERNAL_FLAG_INHERIT_ACTIVATION)
return "inherit-activation"; return "inherit-activation";
if (flag == FU_DEVICE_INTERNAL_FLAG_IS_OPEN)
return "is-open";
return NULL; return NULL;
} }
@ -238,8 +240,12 @@ fu_device_internal_flag_from_string (const gchar *flag)
return FU_DEVICE_INTERNAL_FLAG_ENSURE_SEMVER; return FU_DEVICE_INTERNAL_FLAG_ENSURE_SEMVER;
if (g_strcmp0 (flag, "retry-open") == 0) if (g_strcmp0 (flag, "retry-open") == 0)
return FU_DEVICE_INTERNAL_FLAG_RETRY_OPEN; return FU_DEVICE_INTERNAL_FLAG_RETRY_OPEN;
if (g_strcmp0 (flag, "inherit-activation")) if (g_strcmp0 (flag, "replug-match-guid") == 0)
return FU_DEVICE_INTERNAL_FLAG_REPLUG_MATCH_GUID;
if (g_strcmp0 (flag, "inherit-activation") == 0)
return FU_DEVICE_INTERNAL_FLAG_INHERIT_ACTIVATION; return FU_DEVICE_INTERNAL_FLAG_INHERIT_ACTIVATION;
if (g_strcmp0 (flag, "is-open") == 0)
return FU_DEVICE_INTERNAL_FLAG_IS_OPEN;
return FU_DEVICE_INTERNAL_FLAG_UNKNOWN; return FU_DEVICE_INTERNAL_FLAG_UNKNOWN;
} }

View File

@ -1395,6 +1395,14 @@ fu_device_flags_func (void)
{ {
g_autoptr(FuDevice) device = fu_device_new (); g_autoptr(FuDevice) device = fu_device_new ();
/* bitfield */
for (guint64 i = 1; i < FU_DEVICE_INTERNAL_FLAG_UNKNOWN; i *= 2) {
const gchar *tmp = fu_device_internal_flag_to_string (i);
if (tmp == NULL)
break;
g_assert_cmpint (fu_device_internal_flag_from_string (tmp), ==, i);
}
g_assert_cmpint (fu_device_get_flags (device), ==, FWUPD_DEVICE_FLAG_NONE); g_assert_cmpint (fu_device_get_flags (device), ==, FWUPD_DEVICE_FLAG_NONE);
/* remove IS_BOOTLOADER if is a BOOTLOADER */ /* remove IS_BOOTLOADER if is a BOOTLOADER */